pacnpal/Pac-cogs
1
0
Fork 0
mirror of https://github.com/pacnpal/Pac-cogs.git synced 2025-12-20 10:51:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix ffmpeg

Browse Source
This commit is contained in:
pacnpal
2024-11-14 21:53:46 +00:00
parent 6d25ea8e11
commit 41c7926f79
1 changed files with 400 additions and 249 deletions
Download Patch File Download Diff File Expand all files Collapse all files

649
videoarchiver/ffmpeg_manager.py
View File

@@ -83,7 +83,17 @@ class FFmpegManager:
def __init__(self):
self.base_path = Path(__file__).parent / "bin"
self.base_path.mkdir(exist_ok=True)
# Create bin directory with proper permissions if it doesn't exist
try:
self.base_path.mkdir(parents=True, exist_ok=True)
if platform.system() != "Windows":
# Set directory permissions to rwxr-xr-x (755)
self.base_path.chmod(0o755)
logger.info(f"Created bin directory with permissions: {oct(self.base_path.stat().st_mode)[-3:]}")
except Exception as e:
logger.error(f"Failed to create/set permissions on bin directory: {e}")
raise FFmpegError(f"Failed to initialize FFmpeg directory: {e}")
# Get system architecture
self.system = platform.system()
@@ -96,27 +106,20 @@ class FFmpegManager:
if system_ffmpeg:
self.ffmpeg_path = Path(system_ffmpeg)
logger.info(f"Using system FFmpeg: {self.ffmpeg_path}")
else:
# Check for existing FFmpeg in our bin directory
try:
arch_config = self.FFMPEG_URLS[self.system][self.machine]
self.ffmpeg_path = self.base_path / arch_config["bin_name"]
if not self.ffmpeg_path.exists():
# Only download if FFmpeg doesn't exist
self._download_ffmpeg()
if not self._verify_ffmpeg():
raise FFmpegError("Downloaded FFmpeg binary is not functional")
elif not self._verify_ffmpeg():
logger.warning(
"Existing FFmpeg binary not functional, downloading new copy"
)
self._download_ffmpeg()
if not self._verify_ffmpeg():
raise FFmpegError("Downloaded FFmpeg binary is not functional")
except KeyError:
raise FFmpegError(
f"Unsupported system/architecture: {self.system}/{self.machine}"
)
return
# Check for existing FFmpeg in our bin directory
try:
arch_config = self.FFMPEG_URLS[self.system][self.machine]
self.ffmpeg_path = self.base_path / arch_config["bin_name"]
if not self.ffmpeg_path.exists() or not self._verify_ffmpeg():
logger.info("Downloading FFmpeg...")
self._download_ffmpeg()
if not self._verify_ffmpeg():
raise FFmpegError("Downloaded FFmpeg binary is not functional")
except KeyError:
raise FFmpegError(f"Unsupported system/architecture: {self.system}/{self.machine}")
self._gpu_info = self._detect_gpu()
self._cpu_cores = multiprocessing.cpu_count()
@@ -131,14 +134,15 @@ class FFmpegManager:
# Make binary executable on Unix systems
if self.system != "Windows":
try:
self.ffmpeg_path.chmod(
self.ffmpeg_path.stat().st_mode | stat.S_IEXEC
)
current_mode = self.ffmpeg_path.stat().st_mode
# Add execute permission for user (100), maintaining existing permissions
new_mode = current_mode | stat.S_IXUSR | stat.S_IRUSR | stat.S_IWUSR
self.ffmpeg_path.chmod(new_mode)
logger.info(f"Set FFmpeg permissions to: {oct(new_mode)[-3:]}")
except Exception as e:
logger.error(
f"Failed to set FFmpeg executable permissions: {str(e)}"
)
return False
logger.error(f"Failed to set FFmpeg executable permissions: {e}")
# Continue anyway as the file might already have correct permissions
pass
# Test FFmpeg and check for required encoders
result = subprocess.run(
@@ -147,7 +151,7 @@ class FFmpegManager:
stderr=subprocess.PIPE,
timeout=5,
)
if result.returncode != 0:
if attempt < self.MAX_RETRIES - 1:
time.sleep(self.RETRY_DELAY)
@@ -168,12 +172,16 @@ class FFmpegManager:
if encoder not in encoders:
logger.warning(f"Required encoder {encoder} not available")
if encoder != "libx264": # Only warn for GPU encoders
self._gpu_info[encoder.split('_')[1].replace('h264', '')] = False
self._gpu_info[
encoder.split("_")[1].replace("h264", "")
] = False
return True
except Exception as e:
logger.error(f"FFmpeg verification attempt {attempt + 1} failed: {str(e)}")
logger.error(
f"FFmpeg verification attempt {attempt + 1} failed: {e}"
)
if attempt < self.MAX_RETRIES - 1:
time.sleep(self.RETRY_DELAY)
else:
@@ -200,13 +208,19 @@ class FFmpegManager:
# Verify NVENC functionality
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_nvenc",
"-f", "null",
"-"
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_nvenc",
"-f",
"null",
"-",
]
result = subprocess.run(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
result = subprocess.run(
test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE
)
if result.returncode == 0:
gpu_info["nvidia"] = True
except (subprocess.TimeoutExpired, FileNotFoundError):
@@ -221,13 +235,21 @@ class FFmpegManager:
# Verify AMF functionality
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_amf",
"-f", "null",
"-"
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_amf",
"-f",
"null",
"-",
]
result = subprocess.run(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
result = subprocess.run(
test_cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)
if result.returncode == 0:
gpu_info["amd"] = True
except (IOError, OSError):
@@ -246,13 +268,19 @@ class FFmpegManager:
# Verify QSV functionality
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_qsv",
"-f", "null",
"-"
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_qsv",
"-f",
"null",
"-",
]
result = subprocess.run(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
result = subprocess.run(
test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE
)
if result.returncode == 0:
gpu_info["intel"] = True
except (subprocess.TimeoutExpired, FileNotFoundError):
@@ -270,52 +298,76 @@ class FFmpegManager:
["powershell", "-Command", ps_command],
capture_output=True,
text=True,
timeout=10
timeout=10,
)
if result.returncode == 0:
gpu_data = json.loads(result.stdout)
if not isinstance(gpu_data, list):
gpu_data = [gpu_data]
for gpu in gpu_data:
name = gpu.get("Name", "").lower()
if "nvidia" in name:
# Verify NVENC
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_nvenc",
"-f", "null",
"-"
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_nvenc",
"-f",
"null",
"-",
]
result = subprocess.run(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
result = subprocess.run(
test_cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)
if result.returncode == 0:
gpu_info["nvidia"] = True
if "amd" in name or "radeon" in name:
# Verify AMF
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_amf",
"-f", "null",
"-"
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_amf",
"-f",
"null",
"-",
]
result = subprocess.run(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
result = subprocess.run(
test_cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)
if result.returncode == 0:
gpu_info["amd"] = True
if "intel" in name:
# Verify QSV
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_qsv",
"-f", "null",
"-"
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_qsv",
"-f",
"null",
"-",
]
result = subprocess.run(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
result = subprocess.run(
test_cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)
if result.returncode == 0:
gpu_info["intel"] = True
except Exception:
@@ -336,37 +388,61 @@ class FFmpegManager:
if "nvidia" in content:
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_nvenc",
"-f", "null",
"-"
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_nvenc",
"-f",
"null",
"-",
]
result = subprocess.run(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
result = subprocess.run(
test_cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)
if result.returncode == 0:
gpu_info["nvidia"] = True
if "amd" in content or "radeon" in content:
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_amf",
"-f", "null",
"-"
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_amf",
"-f",
"null",
"-",
]
result = subprocess.run(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
result = subprocess.run(
test_cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)
if result.returncode == 0:
gpu_info["amd"] = True
if "intel" in content:
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_qsv",
"-f", "null",
"-"
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_qsv",
"-f",
"null",
"-",
]
result = subprocess.run(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
result = subprocess.run(
test_cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)
if result.returncode == 0:
gpu_info["intel"] = True
except Exception as e:
@@ -381,26 +457,26 @@ class FFmpegManager:
"""Analyze video content for optimal encoding settings"""
try:
probe = ffmpeg.probe(input_path)
video_info = next(s for s in probe['streams'] if s['codec_type'] == 'video')
video_info = next(s for s in probe["streams"] if s["codec_type"] == "video")
# Get video properties
width = int(video_info.get('width', 0))
height = int(video_info.get('height', 0))
fps = eval(video_info.get('r_frame_rate', '30/1'))
duration = float(probe['format'].get('duration', 0))
bitrate = float(probe['format'].get('bit_rate', 0))
width = int(video_info.get("width", 0))
height = int(video_info.get("height", 0))
fps = eval(video_info.get("r_frame_rate", "30/1"))
duration = float(probe["format"].get("duration", 0))
bitrate = float(probe["format"].get("bit_rate", 0))
# Advanced analysis
has_high_motion = False
has_dark_scenes = False
has_complex_scenes = False
# Analyze frame statistics if available
if video_info.get('avg_frame_rate'):
avg_fps = eval(video_info['avg_frame_rate'])
if video_info.get("avg_frame_rate"):
avg_fps = eval(video_info["avg_frame_rate"])
if abs(avg_fps - fps) > 5: # Significant frame rate variation
has_high_motion = True
# Check for dark scenes and complexity
try:
# Sample frames for analysis
@@ -408,50 +484,57 @@ class FFmpegManager:
frames_file = os.path.join(temp_dir, "frames.txt")
sample_cmd = [
str(self.ffmpeg_path),
"-i", input_path,
"-vf", "select='eq(pict_type,I)',signalstats",
"-show_entries", "frame_tags=lavfi.signalstats.YAVG",
"-f", "null", "-"
"-i",
input_path,
"-vf",
"select='eq(pict_type,I)',signalstats",
"-show_entries",
"frame_tags=lavfi.signalstats.YAVG",
"-f",
"null",
"-",
]
result = subprocess.run(sample_cmd, capture_output=True, text=True)
# Analyze brightness levels
dark_frames = 0
total_frames = 0
for line in result.stderr.split('\n'):
if 'YAVG' in line:
avg_brightness = float(line.split('=')[1])
for line in result.stderr.split("\n"):
if "YAVG" in line:
avg_brightness = float(line.split("=")[1])
if avg_brightness < 40: # Dark scene threshold
dark_frames += 1
total_frames += 1
if total_frames > 0 and (dark_frames / total_frames) > 0.2:
has_dark_scenes = True
except Exception as e:
logger.warning(f"Advanced scene analysis failed: {str(e)}")
# Get audio properties
audio_info = next((s for s in probe['streams'] if s['codec_type'] == 'audio'), None)
audio_info = next(
(s for s in probe["streams"] if s["codec_type"] == "audio"), None
)
audio_bitrate = 0
audio_channels = 2
audio_sample_rate = 48000
if audio_info:
audio_bitrate = int(audio_info.get('bit_rate', 0))
audio_channels = int(audio_info.get('channels', 2))
audio_sample_rate = int(audio_info.get('sample_rate', 48000))
audio_bitrate = int(audio_info.get("bit_rate", 0))
audio_channels = int(audio_info.get("channels", 2))
audio_sample_rate = int(audio_info.get("sample_rate", 48000))
return {
'width': width,
'height': height,
'fps': fps,
'duration': duration,
'bitrate': bitrate,
'has_high_motion': has_high_motion,
'has_dark_scenes': has_dark_scenes,
'has_complex_scenes': has_complex_scenes,
'audio_bitrate': audio_bitrate,
'audio_channels': audio_channels,
'audio_sample_rate': audio_sample_rate
"width": width,
"height": height,
"fps": fps,
"duration": duration,
"bitrate": bitrate,
"has_high_motion": has_high_motion,
"has_dark_scenes": has_dark_scenes,
"has_complex_scenes": has_complex_scenes,
"audio_bitrate": audio_bitrate,
"audio_channels": audio_channels,
"audio_sample_rate": audio_sample_rate,
}
except Exception as e:
logger.error(f"Error analyzing video: {str(e)}")
@@ -463,7 +546,7 @@ class FFmpegManager:
"""Get optimal FFmpeg parameters based on hardware and video analysis"""
# Analyze video content
video_info = self._analyze_video(input_path)
# Base parameters
params = {
"c:v": "libx264", # Default to CPU encoding
@@ -479,155 +562,210 @@ class FFmpegManager:
}
# Add advanced encoding parameters
params.update({
"x264opts": "rc-lookahead=60:me=umh:subme=7:ref=4:b-adapt=2:direct=auto",
"tune": "film", # General-purpose tuning
"fastfirstpass": "1", # Fast first pass for two-pass encoding
})
params.update(
{
"x264opts": "rc-lookahead=60:me=umh:subme=7:ref=4:b-adapt=2:direct=auto",
"tune": "film", # General-purpose tuning
"fastfirstpass": "1", # Fast first pass for two-pass encoding
}
)
# Adjust for content type
if video_info.get('has_high_motion'):
params.update({
"tune": "grain", # Better for high motion
"x264opts": params["x264opts"] + ":deblock=-1,-1:psy-rd=1.0:aq-strength=0.8"
})
if video_info.get('has_dark_scenes'):
if video_info.get("has_high_motion"):
params.update(
{
"tune": "grain", # Better for high motion
"x264opts": params["x264opts"]
+ ":deblock=-1,-1:psy-rd=1.0:aq-strength=0.8",
}
)
if video_info.get("has_dark_scenes"):
# Optimize for dark scenes
params.update({
"x264opts": params["x264opts"] + ":aq-mode=3:aq-strength=1.0:deblock=1:1",
"tune": "film" if not video_info.get('has_high_motion') else "grain"
})
params.update(
{
"x264opts": params["x264opts"]
+ ":aq-mode=3:aq-strength=1.0:deblock=1:1",
"tune": (
"film" if not video_info.get("has_high_motion") else "grain"
),
}
)
# GPU-specific optimizations with fallback
if self._gpu_info["nvidia"]:
try:
params.update({
"c:v": "h264_nvenc",
"preset": "p7", # Highest quality NVENC preset
"rc:v": "vbr", # Variable bitrate
"cq:v": "19", # Quality level
"b_ref_mode": "middle",
"spatial-aq": "1",
"temporal-aq": "1",
"rc-lookahead": "32",
"surfaces": "64",
"max_muxing_queue_size": "1024",
"gpu": "any", # Allow any available GPU
})
params.update(
{
"c:v": "h264_nvenc",
"preset": "p7", # Highest quality NVENC preset
"rc:v": "vbr", # Variable bitrate
"cq:v": "19", # Quality level
"b_ref_mode": "middle",
"spatial-aq": "1",
"temporal-aq": "1",
"rc-lookahead": "32",
"surfaces": "64",
"max_muxing_queue_size": "1024",
"gpu": "any", # Allow any available GPU
}
)
# Test NVENC configuration
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_nvenc"
] + [f"-{k}" if len(k) == 1 else f"-{k}" if not v else f"-{k}" f" {v}" for k, v in params.items() if k != "c:v"] + [
"-f", "null",
"-"
]
test_cmd = (
[
str(self.ffmpeg_path),
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_nvenc",
]
+ [
(
f"-{k}"
if len(k) == 1
else f"-{k}" if not v else f"-{k}" f" {v}"
)
for k, v in params.items()
if k != "c:v"
]
+ ["-f", "null", "-"]
)
result = subprocess.run(test_cmd, capture_output=True)
if result.returncode != 0:
raise GPUError("NVENC test failed")
except Exception as e:
logger.error(f"NVENC initialization failed, falling back to CPU: {str(e)}")
logger.error(
f"NVENC initialization failed, falling back to CPU: {str(e)}"
)
self._gpu_info["nvidia"] = False
params["c:v"] = "libx264" # Fallback to CPU
elif self._gpu_info["amd"]:
try:
params.update({
"c:v": "h264_amf",
"quality": "quality",
"rc": "vbr_peak",
"enforce_hrd": "1",
"vbaq": "1",
"preanalysis": "1",
"max_muxing_queue_size": "1024",
})
params.update(
{
"c:v": "h264_amf",
"quality": "quality",
"rc": "vbr_peak",
"enforce_hrd": "1",
"vbaq": "1",
"preanalysis": "1",
"max_muxing_queue_size": "1024",
}
)
# Test AMF configuration
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_amf"
] + [f"-{k}" if len(k) == 1 else f"-{k}" if not v else f"-{k}" f" {v}" for k, v in params.items() if k != "c:v"] + [
"-f", "null",
"-"
]
test_cmd = (
[
str(self.ffmpeg_path),
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_amf",
]
+ [
(
f"-{k}"
if len(k) == 1
else f"-{k}" if not v else f"-{k}" f" {v}"
)
for k, v in params.items()
if k != "c:v"
]
+ ["-f", "null", "-"]
)
result = subprocess.run(test_cmd, capture_output=True)
if result.returncode != 0:
raise GPUError("AMF test failed")
except Exception as e:
logger.error(f"AMF initialization failed, falling back to CPU: {str(e)}")
logger.error(
f"AMF initialization failed, falling back to CPU: {str(e)}"
)
self._gpu_info["amd"] = False
params["c:v"] = "libx264" # Fallback to CPU
elif self._gpu_info["intel"]:
try:
params.update({
"c:v": "h264_qsv",
"preset": "veryslow",
"look_ahead": "1",
"global_quality": "23",
"max_muxing_queue_size": "1024",
})
params.update(
{
"c:v": "h264_qsv",
"preset": "veryslow",
"look_ahead": "1",
"global_quality": "23",
"max_muxing_queue_size": "1024",
}
)
# Test QSV configuration
test_cmd = [
str(self.ffmpeg_path),
"-f", "lavfi",
"-i", "testsrc=duration=1:size=1280x720:rate=30",
"-c:v", "h264_qsv"
] + [f"-{k}" if len(k) == 1 else f"-{k}" if not v else f"-{k}" f" {v}" for k, v in params.items() if k != "c:v"] + [
"-f", "null",
"-"
]
test_cmd = (
[
str(self.ffmpeg_path),
"-f",
"lavfi",
"-i",
"testsrc=duration=1:size=1280x720:rate=30",
"-c:v",
"h264_qsv",
]
+ [
(
f"-{k}"
if len(k) == 1
else f"-{k}" if not v else f"-{k}" f" {v}"
)
for k, v in params.items()
if k != "c:v"
]
+ ["-f", "null", "-"]
)
result = subprocess.run(test_cmd, capture_output=True)
if result.returncode != 0:
raise GPUError("QSV test failed")
except Exception as e:
logger.error(f"QSV initialization failed, falling back to CPU: {str(e)}")
logger.error(
f"QSV initialization failed, falling back to CPU: {str(e)}"
)
self._gpu_info["intel"] = False
params["c:v"] = "libx264" # Fallback to CPU
try:
# Calculate target bitrate
input_size = os.path.getsize(input_path)
duration = video_info.get('duration', 0)
duration = video_info.get("duration", 0)
if duration > 0 and input_size > target_size_bytes:
# Reserve 5% for container overhead
video_size_target = int(target_size_bytes * 0.95)
# Calculate optimal audio bitrate
total_bitrate = (video_size_target * 8) / duration
# Determine audio quality based on content
audio_channels = video_info.get('audio_channels', 2)
audio_channels = video_info.get("audio_channels", 2)
min_audio_bitrate = 64000 * audio_channels # Minimum per channel
max_audio_bitrate = 192000 * audio_channels # Maximum per channel
# Allocate 10-20% for audio depending on content
audio_bitrate = min(
max_audio_bitrate,
max(
min_audio_bitrate,
int(total_bitrate * 0.15) # 15% baseline
)
max(min_audio_bitrate, int(total_bitrate * 0.15)), # 15% baseline
)
# Remaining bitrate for video
video_bitrate = int((video_size_target * 8) / duration - audio_bitrate)
# Set bitrate constraints
params["maxrate"] = str(int(video_bitrate * 1.5)) # Allow 50% overflow
params["bufsize"] = str(int(video_bitrate * 2)) # Double buffer size
params["bufsize"] = str(int(video_bitrate * 2)) # Double buffer size
# Adjust quality based on compression ratio and content
ratio = input_size / target_size_bytes
if ratio > 4:
@@ -639,35 +777,41 @@ class FFmpegManager:
else:
params["crf"] = "20" if params["c:v"] == "libx264" else "19"
params["preset"] = "slow"
# Adjust for dark scenes
if video_info.get('has_dark_scenes'):
if video_info.get("has_dark_scenes"):
if params["c:v"] == "libx264":
params["crf"] = str(max(18, int(params["crf"]) - 2)) # Better quality for dark scenes
params["crf"] = str(
max(18, int(params["crf"]) - 2)
) # Better quality for dark scenes
elif params["c:v"] == "h264_nvenc":
params["cq:v"] = str(max(15, int(params["cq:v"]) - 2))
# Audio settings
params.update({
"c:a": "aac",
"b:a": f"{int(audio_bitrate/1000)}k",
"ar": str(video_info.get('audio_sample_rate', 48000)),
"ac": str(video_info.get('audio_channels', 2)),
})
params.update(
{
"c:a": "aac",
"b:a": f"{int(audio_bitrate/1000)}k",
"ar": str(video_info.get("audio_sample_rate", 48000)),
"ac": str(video_info.get("audio_channels", 2)),
}
)
except Exception as e:
logger.error(f"Error calculating bitrates: {str(e)}")
# Use safe default parameters
params.update({
"crf": "23",
"preset": "medium",
"maxrate": f"{2 * 1024 * 1024}", # 2 Mbps
"bufsize": f"{4 * 1024 * 1024}", # 4 Mbps buffer
"c:a": "aac",
"b:a": "128k",
"ar": "48000",
"ac": "2",
})
params.update(
{
"crf": "23",
"preset": "medium",
"maxrate": f"{2 * 1024 * 1024}", # 2 Mbps
"bufsize": f"{4 * 1024 * 1024}", # 4 Mbps buffer
"c:a": "aac",
"b:a": "128k",
"ar": "48000",
"ac": "2",
}
)
return params
@@ -681,9 +825,12 @@ class FFmpegManager:
)
url = arch_config["url"]
with temp_path_context() as temp_dir:
archive_path = Path(temp_dir) / f"ffmpeg_archive{'.zip' if self.system == 'Windows' else '.tar.xz'}"
archive_path = (
Path(temp_dir)
/ f"ffmpeg_archive{'.zip' if self.system == 'Windows' else '.tar.xz'}"
)
try:
# Download archive with retries
@@ -711,7 +858,9 @@ class FFmpegManager:
if self.system == "Windows":
with zipfile.ZipFile(archive_path, "r") as zip_ref:
ffmpeg_files = [
f for f in zip_ref.namelist() if arch_config["bin_name"] in f
f
for f in zip_ref.namelist()
if arch_config["bin_name"] in f
]
if not ffmpeg_files:
raise DownloadError("FFmpeg binary not found in archive")
@@ -720,7 +869,9 @@ class FFmpegManager:
else:
with tarfile.open(archive_path, "r:xz") as tar_ref:
ffmpeg_files = [
f for f in tar_ref.getnames() if arch_config["bin_name"] in f
f
for f in tar_ref.getnames()
if arch_config["bin_name"] in f
]
if not ffmpeg_files:
raise DownloadError("FFmpeg binary not found in archive")