mirror of
https://github.com/pacnpal/Pac-cogs.git
synced 2025-12-20 10:51:05 -05:00
refactor: Split FFmpeg manager into modular components
- Created ffmpeg package with specialized modules - Improved Docker compatibility using /tmp - Better permission handling - More robust error handling - Separated concerns for easier maintenance - Simplified imports through __init__.py
This commit is contained in:
pacnpal
@@ -1,933 +1,5 @@
|
||||
import os
|
||||
import sys
|
||||
import platform
|
||||
import subprocess
|
||||
import logging
|
||||
import shutil
|
||||
import requests
|
||||
import zipfile
|
||||
import tarfile
|
||||
from pathlib import Path
|
||||
import stat
|
||||
import multiprocessing
|
||||
import ffmpeg
|
||||
import tempfile
|
||||
import json
|
||||
import time
|
||||
from typing import Dict, Optional, Tuple
|
||||
import contextlib
|
||||
"""FFmpeg management module"""
|
||||
|
||||
logger = logging.getLogger("VideoArchiver")
|
||||
from .ffmpeg import FFmpegManager, FFmpegError, GPUError, DownloadError
|
||||
|
||||
class FFmpegError(Exception):
|
||||
"""Base exception for FFmpeg-related errors"""
|
||||
pass
|
||||
|
||||
class GPUError(FFmpegError):
|
||||
"""Raised when GPU operations fail"""
|
||||
pass
|
||||
|
||||
class DownloadError(FFmpegError):
|
||||
"""Raised when FFmpeg download fails"""
|
||||
pass
|
||||
|
||||
@contextlib.contextmanager
|
||||
def temp_path_context():
|
||||
"""Context manager for temporary path creation and cleanup"""
|
||||
# Create a temporary directory using system temp directory
|
||||
temp_dir = tempfile.mkdtemp(prefix="ffmpeg_")
|
||||
try:
|
||||
yield temp_dir
|
||||
finally:
|
||||
try:
|
||||
shutil.rmtree(temp_dir, ignore_errors=True)
|
||||
except Exception as e:
|
||||
logger.error(f"Error cleaning up temp directory {temp_dir}: {e}")
|
||||
|
||||
class FFmpegManager:
|
||||
FFMPEG_URLS = {
|
||||
"Windows": {
|
||||
"x86_64": {
|
||||
"url": "https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-master-latest-win64-gpl.zip",
|
||||
"bin_name": "ffmpeg.exe",
|
||||
}
|
||||
},
|
||||
"Linux": {
|
||||
"x86_64": {
|
||||
"url": "https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-master-latest-linux64-gpl.tar.xz",
|
||||
"bin_name": "ffmpeg",
|
||||
},
|
||||
"aarch64": { # ARM64
|
||||
"url": "https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-master-latest-linuxarm64-gpl.tar.xz",
|
||||
"bin_name": "ffmpeg",
|
||||
},
|
||||
"armv7l": { # ARM32
|
||||
"url": "https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-master-latest-linuxarm32-gpl.tar.xz",
|
||||
"bin_name": "ffmpeg",
|
||||
},
|
||||
},
|
||||
"Darwin": { # macOS
|
||||
"x86_64": {
|
||||
"url": "https://evermeet.cx/ffmpeg/getrelease/zip",
|
||||
"bin_name": "ffmpeg",
|
||||
},
|
||||
"arm64": { # Apple Silicon
|
||||
"url": "https://evermeet.cx/ffmpeg/getrelease/zip",
|
||||
"bin_name": "ffmpeg",
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
MAX_RETRIES = 3
|
||||
RETRY_DELAY = 1 # seconds
|
||||
|
||||
def __init__(self):
|
||||
# Use system temp directory for temporary files
|
||||
self.tmp_path = Path(tempfile.gettempdir()) / "ffmpeg_tmp"
|
||||
try:
|
||||
self.tmp_path.mkdir(parents=True, exist_ok=True)
|
||||
except Exception as e:
|
||||
logger.warning(f"Could not create tmp directory, using system temp: {e}")
|
||||
self.tmp_path = Path(tempfile.gettempdir())
|
||||
|
||||
# Use XDG_DATA_HOME or fallback to ~/.local/share for Linux/macOS
|
||||
if platform.system() in ["Linux", "Darwin"]:
|
||||
xdg_data = os.environ.get("XDG_DATA_HOME", os.path.expanduser("~/.local/share"))
|
||||
self.base_path = Path(xdg_data) / "red-discordbot" / "cogs" / "VideoArchiver" / "bin"
|
||||
else: # Windows
|
||||
appdata = os.environ.get("APPDATA", os.path.expanduser("~/AppData/Roaming"))
|
||||
self.base_path = Path(appdata) / "Red-DiscordBot" / "cogs" / "VideoArchiver" / "bin"
|
||||
|
||||
# Create bin directory with proper permissions if it doesn't exist
|
||||
try:
|
||||
self.base_path.mkdir(parents=True, exist_ok=True)
|
||||
if platform.system() != "Windows":
|
||||
# Try to set directory permissions, but don't fail if we can't
|
||||
try:
|
||||
self.base_path.chmod(0o755)
|
||||
logger.info(f"Created bin directory with permissions: {oct(self.base_path.stat().st_mode)[-3:]}")
|
||||
except Exception as e:
|
||||
logger.warning(f"Could not set bin directory permissions: {e}")
|
||||
except Exception as e:
|
||||
logger.error(f"Failed to create bin directory: {e}")
|
||||
raise FFmpegError(f"Failed to initialize FFmpeg directory: {e}")
|
||||
|
||||
# Get system architecture
|
||||
self.system = platform.system()
|
||||
self.machine = platform.machine().lower()
|
||||
if self.machine == "arm64":
|
||||
self.machine = "aarch64" # Normalize ARM64 naming
|
||||
|
||||
# Try to use system FFmpeg first
|
||||
system_ffmpeg = shutil.which("ffmpeg")
|
||||
if system_ffmpeg:
|
||||
self.ffmpeg_path = Path(system_ffmpeg)
|
||||
logger.info(f"Using system FFmpeg: {self.ffmpeg_path}")
|
||||
return
|
||||
|
||||
# Check for existing FFmpeg in our bin directory
|
||||
try:
|
||||
arch_config = self.FFMPEG_URLS[self.system][self.machine]
|
||||
self.ffmpeg_path = self.base_path / arch_config["bin_name"]
|
||||
|
||||
if not self.ffmpeg_path.exists() or not self._verify_ffmpeg():
|
||||
logger.info("Downloading FFmpeg...")
|
||||
self._download_ffmpeg()
|
||||
if not self._verify_ffmpeg():
|
||||
raise FFmpegError("Downloaded FFmpeg binary is not functional")
|
||||
except KeyError:
|
||||
raise FFmpegError(f"Unsupported system/architecture: {self.system}/{self.machine}")
|
||||
|
||||
self._gpu_info = self._detect_gpu()
|
||||
self._cpu_cores = multiprocessing.cpu_count()
|
||||
|
||||
def _verify_ffmpeg(self) -> bool:
|
||||
"""Verify FFmpeg binary works"""
|
||||
for attempt in range(self.MAX_RETRIES):
|
||||
try:
|
||||
if not self.ffmpeg_path.exists():
|
||||
return False
|
||||
|
||||
# Make binary executable on Unix systems
|
||||
if self.system != "Windows":
|
||||
try:
|
||||
current_mode = self.ffmpeg_path.stat().st_mode
|
||||
# Add execute permission for user (700)
|
||||
new_mode = current_mode | stat.S_IRWXU
|
||||
self.ffmpeg_path.chmod(new_mode)
|
||||
logger.info(f"Set FFmpeg permissions to: {oct(new_mode)[-3:]}")
|
||||
except Exception as e:
|
||||
logger.error(f"Failed to set FFmpeg executable permissions: {e}")
|
||||
# Continue anyway as the file might already have correct permissions
|
||||
pass
|
||||
|
||||
# Test FFmpeg and check for required encoders
|
||||
result = subprocess.run(
|
||||
[str(self.ffmpeg_path), "-encoders"],
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
timeout=5,
|
||||
)
|
||||
|
||||
if result.returncode != 0:
|
||||
if attempt < self.MAX_RETRIES - 1:
|
||||
time.sleep(self.RETRY_DELAY)
|
||||
continue
|
||||
return False
|
||||
|
||||
# Verify encoders are available
|
||||
encoders = result.stdout.decode()
|
||||
required_encoders = ["libx264"] # Base requirement
|
||||
if self._gpu_info["nvidia"]:
|
||||
required_encoders.append("h264_nvenc")
|
||||
if self._gpu_info["amd"]:
|
||||
required_encoders.append("h264_amf")
|
||||
if self._gpu_info["intel"]:
|
||||
required_encoders.append("h264_qsv")
|
||||
|
||||
for encoder in required_encoders:
|
||||
if encoder not in encoders:
|
||||
logger.warning(f"Required encoder {encoder} not available")
|
||||
if encoder != "libx264": # Only warn for GPU encoders
|
||||
self._gpu_info[
|
||||
encoder.split("_")[1].replace("h264", "")
|
||||
] = False
|
||||
|
||||
return True
|
||||
|
||||
except Exception as e:
|
||||
logger.error(
|
||||
f"FFmpeg verification attempt {attempt + 1} failed: {e}"
|
||||
)
|
||||
if attempt < self.MAX_RETRIES - 1:
|
||||
time.sleep(self.RETRY_DELAY)
|
||||
else:
|
||||
return False
|
||||
|
||||
return False
|
||||
|
||||
def _detect_gpu(self) -> dict:
|
||||
"""Detect available GPU and its capabilities"""
|
||||
gpu_info = {"nvidia": False, "amd": False, "intel": False, "arm": False}
|
||||
|
||||
try:
|
||||
if self.system == "Linux":
|
||||
# Check for NVIDIA GPU
|
||||
try:
|
||||
# First check for NVENC capability
|
||||
nvidia_smi = subprocess.run(
|
||||
["nvidia-smi", "-q", "-d", "ENCODER"],
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
timeout=5,
|
||||
)
|
||||
if nvidia_smi.returncode == 0 and b"Encoder" in nvidia_smi.stdout:
|
||||
# Verify NVENC functionality
|
||||
test_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_nvenc",
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(
|
||||
test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_info["nvidia"] = True
|
||||
except (subprocess.TimeoutExpired, FileNotFoundError):
|
||||
pass
|
||||
|
||||
# Check for AMD GPU
|
||||
try:
|
||||
if os.path.exists("/dev/dri/renderD128"):
|
||||
with open("/sys/class/drm/renderD128/device/vendor", "r") as f:
|
||||
vendor = f.read().strip()
|
||||
if vendor == "0x1002": # AMD vendor ID
|
||||
# Verify AMF functionality
|
||||
test_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_amf",
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(
|
||||
test_cmd,
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_info["amd"] = True
|
||||
except (IOError, OSError):
|
||||
pass
|
||||
|
||||
# Check for Intel GPU
|
||||
try:
|
||||
lspci = subprocess.run(
|
||||
["lspci"],
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
timeout=5,
|
||||
)
|
||||
output = lspci.stdout.decode().lower()
|
||||
if "intel" in output and ("vga" in output or "display" in output):
|
||||
# Verify QSV functionality
|
||||
test_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_qsv",
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(
|
||||
test_cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_info["intel"] = True
|
||||
except (subprocess.TimeoutExpired, FileNotFoundError):
|
||||
pass
|
||||
|
||||
# Check for ARM GPU
|
||||
if self.machine in ["aarch64", "armv7l"]:
|
||||
gpu_info["arm"] = True
|
||||
|
||||
elif self.system == "Windows":
|
||||
try:
|
||||
# Use PowerShell to get GPU info
|
||||
ps_command = "Get-WmiObject Win32_VideoController | ConvertTo-Json"
|
||||
result = subprocess.run(
|
||||
["powershell", "-Command", ps_command],
|
||||
capture_output=True,
|
||||
text=True,
|
||||
timeout=10,
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_data = json.loads(result.stdout)
|
||||
if not isinstance(gpu_data, list):
|
||||
gpu_data = [gpu_data]
|
||||
|
||||
for gpu in gpu_data:
|
||||
name = gpu.get("Name", "").lower()
|
||||
if "nvidia" in name:
|
||||
# Verify NVENC
|
||||
test_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_nvenc",
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(
|
||||
test_cmd,
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_info["nvidia"] = True
|
||||
if "amd" in name or "radeon" in name:
|
||||
# Verify AMF
|
||||
test_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(
|
||||
test_cmd,
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_info["amd"] = True
|
||||
if "intel" in name:
|
||||
# Verify QSV
|
||||
test_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_qsv",
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(
|
||||
test_cmd,
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_info["intel"] = True
|
||||
except Exception:
|
||||
# Fallback to dxdiag if PowerShell method fails
|
||||
with temp_path_context() as temp_dir:
|
||||
temp_path = os.path.join(temp_dir, "dxdiag.txt")
|
||||
try:
|
||||
subprocess.run(
|
||||
["dxdiag", "/t", temp_path],
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
timeout=10,
|
||||
)
|
||||
if os.path.exists(temp_path):
|
||||
with open(temp_path, "r", errors="ignore") as f:
|
||||
content = f.read().lower()
|
||||
# Only set GPU flags if we can verify encoder functionality
|
||||
if "nvidia" in content:
|
||||
test_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_nvenc",
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(
|
||||
test_cmd,
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_info["nvidia"] = True
|
||||
if "amd" in content or "radeon" in content:
|
||||
test_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_amf",
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(
|
||||
test_cmd,
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_info["amd"] = True
|
||||
if "intel" in content:
|
||||
test_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_qsv",
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(
|
||||
test_cmd,
|
||||
stdout=subprocess.PIPE,
|
||||
stderr=subprocess.PIPE,
|
||||
)
|
||||
if result.returncode == 0:
|
||||
gpu_info["intel"] = True
|
||||
except Exception as e:
|
||||
logger.error(f"Error during dxdiag GPU detection: {str(e)}")
|
||||
|
||||
except Exception as e:
|
||||
logger.warning(f"GPU detection failed: {str(e)}")
|
||||
|
||||
return gpu_info
|
||||
|
||||
def _analyze_video(self, input_path: str) -> dict:
|
||||
"""Analyze video content for optimal encoding settings"""
|
||||
try:
|
||||
probe = ffmpeg.probe(input_path)
|
||||
video_info = next(s for s in probe["streams"] if s["codec_type"] == "video")
|
||||
|
||||
# Get video properties
|
||||
width = int(video_info.get("width", 0))
|
||||
height = int(video_info.get("height", 0))
|
||||
fps = eval(video_info.get("r_frame_rate", "30/1"))
|
||||
duration = float(probe["format"].get("duration", 0))
|
||||
bitrate = float(probe["format"].get("bit_rate", 0))
|
||||
|
||||
# Advanced analysis
|
||||
has_high_motion = False
|
||||
has_dark_scenes = False
|
||||
has_complex_scenes = False
|
||||
|
||||
# Analyze frame statistics if available
|
||||
if video_info.get("avg_frame_rate"):
|
||||
avg_fps = eval(video_info["avg_frame_rate"])
|
||||
if abs(avg_fps - fps) > 5: # Significant frame rate variation
|
||||
has_high_motion = True
|
||||
|
||||
# Check for dark scenes and complexity
|
||||
try:
|
||||
# Sample frames for analysis
|
||||
with temp_path_context() as temp_dir:
|
||||
frames_file = os.path.join(temp_dir, "frames.txt")
|
||||
sample_cmd = [
|
||||
str(self.ffmpeg_path),
|
||||
"-i",
|
||||
input_path,
|
||||
"-vf",
|
||||
"select='eq(pict_type,I)',signalstats",
|
||||
"-show_entries",
|
||||
"frame_tags=lavfi.signalstats.YAVG",
|
||||
"-f",
|
||||
"null",
|
||||
"-",
|
||||
]
|
||||
result = subprocess.run(sample_cmd, capture_output=True, text=True)
|
||||
|
||||
# Analyze brightness levels
|
||||
dark_frames = 0
|
||||
total_frames = 0
|
||||
for line in result.stderr.split("\n"):
|
||||
if "YAVG" in line:
|
||||
avg_brightness = float(line.split("=")[1])
|
||||
if avg_brightness < 40: # Dark scene threshold
|
||||
dark_frames += 1
|
||||
total_frames += 1
|
||||
|
||||
if total_frames > 0 and (dark_frames / total_frames) > 0.2:
|
||||
has_dark_scenes = True
|
||||
except Exception as e:
|
||||
logger.warning(f"Advanced scene analysis failed: {str(e)}")
|
||||
|
||||
# Get audio properties
|
||||
audio_info = next(
|
||||
(s for s in probe["streams"] if s["codec_type"] == "audio"), None
|
||||
)
|
||||
audio_bitrate = 0
|
||||
audio_channels = 2
|
||||
audio_sample_rate = 48000
|
||||
if audio_info:
|
||||
audio_bitrate = int(audio_info.get("bit_rate", 0))
|
||||
audio_channels = int(audio_info.get("channels", 2))
|
||||
audio_sample_rate = int(audio_info.get("sample_rate", 48000))
|
||||
|
||||
return {
|
||||
"width": width,
|
||||
"height": height,
|
||||
"fps": fps,
|
||||
"duration": duration,
|
||||
"bitrate": bitrate,
|
||||
"has_high_motion": has_high_motion,
|
||||
"has_dark_scenes": has_dark_scenes,
|
||||
"has_complex_scenes": has_complex_scenes,
|
||||
"audio_bitrate": audio_bitrate,
|
||||
"audio_channels": audio_channels,
|
||||
"audio_sample_rate": audio_sample_rate,
|
||||
}
|
||||
except Exception as e:
|
||||
logger.error(f"Error analyzing video: {str(e)}")
|
||||
return {}
|
||||
|
||||
def _get_optimal_ffmpeg_params(
|
||||
self, input_path: str, target_size_bytes: int
|
||||
) -> dict:
|
||||
"""Get optimal FFmpeg parameters based on hardware and video analysis"""
|
||||
# Analyze video content
|
||||
video_info = self._analyze_video(input_path)
|
||||
|
||||
# Base parameters
|
||||
params = {
|
||||
"c:v": "libx264", # Default to CPU encoding
|
||||
"threads": str(self._cpu_cores), # Use all CPU cores
|
||||
"preset": "medium",
|
||||
"crf": "23", # Default quality
|
||||
"maxrate": None,
|
||||
"bufsize": None,
|
||||
"movflags": "+faststart", # Optimize for web playback
|
||||
"profile:v": "high", # High profile for better quality
|
||||
"level": "4.1", # Compatibility level
|
||||
"pix_fmt": "yuv420p", # Standard pixel format
|
||||
}
|
||||
|
||||
# Add advanced encoding parameters
|
||||
params.update(
|
||||
{
|
||||
"x264opts": "rc-lookahead=60:me=umh:subme=7:ref=4:b-adapt=2:direct=auto",
|
||||
"tune": "film", # General-purpose tuning
|
||||
"fastfirstpass": "1", # Fast first pass for two-pass encoding
|
||||
}
|
||||
)
|
||||
|
||||
# Adjust for content type
|
||||
if video_info.get("has_high_motion"):
|
||||
params.update(
|
||||
{
|
||||
"tune": "grain", # Better for high motion
|
||||
"x264opts": params["x264opts"]
|
||||
+ ":deblock=-1,-1:psy-rd=1.0:aq-strength=0.8",
|
||||
}
|
||||
)
|
||||
|
||||
if video_info.get("has_dark_scenes"):
|
||||
# Optimize for dark scenes
|
||||
params.update(
|
||||
{
|
||||
"x264opts": params["x264opts"]
|
||||
+ ":aq-mode=3:aq-strength=1.0:deblock=1:1",
|
||||
"tune": (
|
||||
"film" if not video_info.get("has_high_motion") else "grain"
|
||||
),
|
||||
}
|
||||
)
|
||||
|
||||
# GPU-specific optimizations with fallback
|
||||
if self._gpu_info["nvidia"]:
|
||||
try:
|
||||
params.update(
|
||||
{
|
||||
"c:v": "h264_nvenc",
|
||||
"preset": "p7", # Highest quality NVENC preset
|
||||
"rc:v": "vbr", # Variable bitrate
|
||||
"cq:v": "19", # Quality level
|
||||
"b_ref_mode": "middle",
|
||||
"spatial-aq": "1",
|
||||
"temporal-aq": "1",
|
||||
"rc-lookahead": "32",
|
||||
"surfaces": "64",
|
||||
"max_muxing_queue_size": "1024",
|
||||
"gpu": "any", # Allow any available GPU
|
||||
}
|
||||
)
|
||||
|
||||
# Test NVENC configuration
|
||||
test_cmd = (
|
||||
[
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_nvenc",
|
||||
]
|
||||
+ [
|
||||
(
|
||||
f"-{k}"
|
||||
if len(k) == 1
|
||||
else f"-{k}" if not v else f"-{k}" f" {v}"
|
||||
)
|
||||
for k, v in params.items()
|
||||
if k != "c:v"
|
||||
]
|
||||
+ ["-f", "null", "-"]
|
||||
)
|
||||
result = subprocess.run(test_cmd, capture_output=True)
|
||||
if result.returncode != 0:
|
||||
raise GPUError("NVENC test failed")
|
||||
|
||||
except Exception as e:
|
||||
logger.error(
|
||||
f"NVENC initialization failed, falling back to CPU: {str(e)}"
|
||||
)
|
||||
self._gpu_info["nvidia"] = False
|
||||
params["c:v"] = "libx264" # Fallback to CPU
|
||||
|
||||
elif self._gpu_info["amd"]:
|
||||
try:
|
||||
params.update(
|
||||
{
|
||||
"c:v": "h264_amf",
|
||||
"quality": "quality",
|
||||
"rc": "vbr_peak",
|
||||
"enforce_hrd": "1",
|
||||
"vbaq": "1",
|
||||
"preanalysis": "1",
|
||||
"max_muxing_queue_size": "1024",
|
||||
}
|
||||
)
|
||||
|
||||
# Test AMF configuration
|
||||
test_cmd = (
|
||||
[
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_amf",
|
||||
]
|
||||
+ [
|
||||
(
|
||||
f"-{k}"
|
||||
if len(k) == 1
|
||||
else f"-{k}" if not v else f"-{k}" f" {v}"
|
||||
)
|
||||
for k, v in params.items()
|
||||
if k != "c:v"
|
||||
]
|
||||
+ ["-f", "null", "-"]
|
||||
)
|
||||
result = subprocess.run(test_cmd, capture_output=True)
|
||||
if result.returncode != 0:
|
||||
raise GPUError("AMF test failed")
|
||||
|
||||
except Exception as e:
|
||||
logger.error(
|
||||
f"AMF initialization failed, falling back to CPU: {str(e)}"
|
||||
)
|
||||
self._gpu_info["amd"] = False
|
||||
params["c:v"] = "libx264" # Fallback to CPU
|
||||
|
||||
elif self._gpu_info["intel"]:
|
||||
try:
|
||||
params.update(
|
||||
{
|
||||
"c:v": "h264_qsv",
|
||||
"preset": "veryslow",
|
||||
"look_ahead": "1",
|
||||
"global_quality": "23",
|
||||
"max_muxing_queue_size": "1024",
|
||||
}
|
||||
)
|
||||
|
||||
# Test QSV configuration
|
||||
test_cmd = (
|
||||
[
|
||||
str(self.ffmpeg_path),
|
||||
"-f",
|
||||
"lavfi",
|
||||
"-i",
|
||||
"testsrc=duration=1:size=1280x720:rate=30",
|
||||
"-c:v",
|
||||
"h264_qsv",
|
||||
]
|
||||
+ [
|
||||
(
|
||||
f"-{k}"
|
||||
if len(k) == 1
|
||||
else f"-{k}" if not v else f"-{k}" f" {v}"
|
||||
)
|
||||
for k, v in params.items()
|
||||
if k != "c:v"
|
||||
]
|
||||
+ ["-f", "null", "-"]
|
||||
)
|
||||
result = subprocess.run(test_cmd, capture_output=True)
|
||||
if result.returncode != 0:
|
||||
raise GPUError("QSV test failed")
|
||||
|
||||
except Exception as e:
|
||||
logger.error(
|
||||
f"QSV initialization failed, falling back to CPU: {str(e)}"
|
||||
)
|
||||
self._gpu_info["intel"] = False
|
||||
params["c:v"] = "libx264" # Fallback to CPU
|
||||
|
||||
try:
|
||||
# Calculate target bitrate
|
||||
input_size = os.path.getsize(input_path)
|
||||
duration = video_info.get("duration", 0)
|
||||
|
||||
if duration > 0 and input_size > target_size_bytes:
|
||||
# Reserve 5% for container overhead
|
||||
video_size_target = int(target_size_bytes * 0.95)
|
||||
|
||||
# Calculate optimal audio bitrate
|
||||
total_bitrate = (video_size_target * 8) / duration
|
||||
|
||||
# Determine audio quality based on content
|
||||
audio_channels = video_info.get("audio_channels", 2)
|
||||
min_audio_bitrate = 64000 * audio_channels # Minimum per channel
|
||||
max_audio_bitrate = 192000 * audio_channels # Maximum per channel
|
||||
|
||||
# Allocate 10-20% for audio depending on content
|
||||
audio_bitrate = min(
|
||||
max_audio_bitrate,
|
||||
max(min_audio_bitrate, int(total_bitrate * 0.15)), # 15% baseline
|
||||
)
|
||||
|
||||
# Remaining bitrate for video
|
||||
video_bitrate = int((video_size_target * 8) / duration - audio_bitrate)
|
||||
|
||||
# Set bitrate constraints
|
||||
params["maxrate"] = str(int(video_bitrate * 1.5)) # Allow 50% overflow
|
||||
params["bufsize"] = str(int(video_bitrate * 2)) # Double buffer size
|
||||
|
||||
# Adjust quality based on compression ratio and content
|
||||
ratio = input_size / target_size_bytes
|
||||
if ratio > 4:
|
||||
params["crf"] = "26" if params["c:v"] == "libx264" else "23"
|
||||
params["preset"] = "faster"
|
||||
elif ratio > 2:
|
||||
params["crf"] = "23" if params["c:v"] == "libx264" else "21"
|
||||
params["preset"] = "medium"
|
||||
else:
|
||||
params["crf"] = "20" if params["c:v"] == "libx264" else "19"
|
||||
params["preset"] = "slow"
|
||||
|
||||
# Adjust for dark scenes
|
||||
if video_info.get("has_dark_scenes"):
|
||||
if params["c:v"] == "libx264":
|
||||
params["crf"] = str(
|
||||
max(18, int(params["crf"]) - 2)
|
||||
) # Better quality for dark scenes
|
||||
elif params["c:v"] == "h264_nvenc":
|
||||
params["cq:v"] = str(max(15, int(params["cq:v"]) - 2))
|
||||
|
||||
# Audio settings
|
||||
params.update(
|
||||
{
|
||||
"c:a": "aac",
|
||||
"b:a": f"{int(audio_bitrate/1000)}k",
|
||||
"ar": str(video_info.get("audio_sample_rate", 48000)),
|
||||
"ac": str(video_info.get("audio_channels", 2)),
|
||||
}
|
||||
)
|
||||
|
||||
except Exception as e:
|
||||
logger.error(f"Error calculating bitrates: {str(e)}")
|
||||
# Use safe default parameters
|
||||
params.update(
|
||||
{
|
||||
"crf": "23",
|
||||
"preset": "medium",
|
||||
"maxrate": f"{2 * 1024 * 1024}", # 2 Mbps
|
||||
"bufsize": f"{4 * 1024 * 1024}", # 4 Mbps buffer
|
||||
"c:a": "aac",
|
||||
"b:a": "128k",
|
||||
"ar": "48000",
|
||||
"ac": "2",
|
||||
}
|
||||
)
|
||||
|
||||
return params
|
||||
|
||||
def _download_ffmpeg(self):
|
||||
"""Download and extract FFmpeg binary"""
|
||||
try:
|
||||
arch_config = self.FFMPEG_URLS[self.system][self.machine]
|
||||
except KeyError:
|
||||
raise DownloadError(
|
||||
f"Unsupported system/architecture: {self.system}/{self.machine}"
|
||||
)
|
||||
|
||||
url = arch_config["url"]
|
||||
|
||||
with temp_path_context() as temp_dir:
|
||||
archive_path = (
|
||||
Path(temp_dir)
|
||||
/ f"ffmpeg_archive{'.zip' if self.system == 'Windows' else '.tar.xz'}"
|
||||
)
|
||||
|
||||
try:
|
||||
# Download archive with retries
|
||||
for attempt in range(self.MAX_RETRIES):
|
||||
try:
|
||||
response = requests.get(url, stream=True, timeout=30)
|
||||
response.raise_for_status()
|
||||
with open(archive_path, "wb") as f:
|
||||
for chunk in response.iter_content(chunk_size=8192):
|
||||
f.write(chunk)
|
||||
break
|
||||
except Exception as e:
|
||||
if attempt == self.MAX_RETRIES - 1:
|
||||
raise DownloadError(f"Failed to download FFmpeg: {str(e)}")
|
||||
time.sleep(self.RETRY_DELAY)
|
||||
|
||||
# Remove existing ffmpeg if it exists (handle both file and directory)
|
||||
if self.ffmpeg_path.exists():
|
||||
if self.ffmpeg_path.is_dir():
|
||||
shutil.rmtree(self.ffmpeg_path)
|
||||
else:
|
||||
self.ffmpeg_path.unlink()
|
||||
|
||||
# Extract archive
|
||||
if self.system == "Windows":
|
||||
with zipfile.ZipFile(archive_path, "r") as zip_ref:
|
||||
ffmpeg_files = [
|
||||
f
|
||||
for f in zip_ref.namelist()
|
||||
if arch_config["bin_name"] in f
|
||||
]
|
||||
if not ffmpeg_files:
|
||||
raise DownloadError("FFmpeg binary not found in archive")
|
||||
zip_ref.extract(ffmpeg_files[0], self.base_path)
|
||||
os.rename(self.base_path / ffmpeg_files[0], self.ffmpeg_path)
|
||||
else:
|
||||
with tarfile.open(archive_path, "r:xz") as tar_ref:
|
||||
ffmpeg_files = [
|
||||
f
|
||||
for f in tar_ref.getnames()
|
||||
if arch_config["bin_name"] in f
|
||||
]
|
||||
if not ffmpeg_files:
|
||||
raise DownloadError("FFmpeg binary not found in archive")
|
||||
tar_ref.extract(ffmpeg_files[0], self.base_path)
|
||||
os.rename(self.base_path / ffmpeg_files[0], self.ffmpeg_path)
|
||||
|
||||
# Set executable permissions on Unix systems
|
||||
if self.system != "Windows":
|
||||
try:
|
||||
self.ffmpeg_path.chmod(
|
||||
self.ffmpeg_path.stat().st_mode | stat.S_IEXEC
|
||||
)
|
||||
except Exception as e:
|
||||
logger.error(f"Failed to set executable permissions: {str(e)}")
|
||||
|
||||
except Exception as e:
|
||||
logger.error(f"FFmpeg download/extraction failed: {str(e)}")
|
||||
raise DownloadError(str(e))
|
||||
|
||||
def force_download(self) -> bool:
|
||||
"""Force re-download of FFmpeg binary"""
|
||||
try:
|
||||
# Remove existing binary if it exists
|
||||
if self.ffmpeg_path.exists():
|
||||
try:
|
||||
self.ffmpeg_path.unlink()
|
||||
except Exception as e:
|
||||
logger.error(f"Failed to remove existing FFmpeg: {str(e)}")
|
||||
return False
|
||||
|
||||
# Download new binary
|
||||
self._download_ffmpeg()
|
||||
|
||||
# Verify new binary
|
||||
return self._verify_ffmpeg()
|
||||
except Exception as e:
|
||||
logger.error(f"Failed to force download FFmpeg: {str(e)}")
|
||||
return False
|
||||
|
||||
def get_ffmpeg_path(self) -> str:
|
||||
"""Get path to FFmpeg binary"""
|
||||
if not self.ffmpeg_path.exists():
|
||||
raise FFmpegError("FFmpeg is not available")
|
||||
return str(self.ffmpeg_path)
|
||||
|
||||
def get_compression_params(self, input_path: str, target_size_mb: int) -> dict:
|
||||
"""Get optimal compression parameters for the given input file"""
|
||||
return self._get_optimal_ffmpeg_params(input_path, target_size_mb * 1024 * 1024)
|
||||
__all__ = ['FFmpegManager', 'FFmpegError', 'GPUError', 'DownloadError']
|
||||
|
||||
Reference in New Issue
Block a user