Commit Graph

238 Commits

Author SHA1 Message Date
pacnpal
d80815e9fb fix(ffmpeg): add fallback to absolute imports in binary_manager.py 2024-11-17 22:24:09 +00:00
pacnpal
b9fbb1925f fix(ffmpeg): add fallback to absolute imports in __init__.py 2024-11-17 22:23:25 +00:00
pacnpal
53f071c338 fix(core): add fallback to absolute imports in __init__.py 2024-11-17 22:22:25 +00:00
pacnpal
1a4f56ad90 fix(database): add fallback to absolute imports in __init__.py 2024-11-17 22:21:59 +00:00
pacnpal
e52f088396 fix(database): add fallback to absolute imports in video_archive_db.py 2024-11-17 22:20:36 +00:00
pacnpal
2b0e49b5b0 fix(database): add fallback to absolute imports in schema_manager.py 2024-11-17 22:19:56 +00:00
pacnpal
9d8b83ce78 fix(database): add fallback to absolute imports in connection_manager.py 2024-11-17 22:19:03 +00:00
pacnpal
bd729c2bfc fix(core): add fallback to absolute imports in settings.py 2024-11-17 22:17:10 +00:00
pacnpal
0afb28d492 fix(core): add fallback to absolute imports in response_handler.py 2024-11-17 22:16:33 +00:00
pacnpal
ddaab828fa fix(core): add fallback to absolute imports in lifecycle.py 2024-11-17 22:14:23 +00:00
pacnpal
ba6eb11e81 fix(core): add fallback to absolute imports in initialization.py 2024-11-17 22:13:51 +00:00
pacnpal
e01d89bd94 fix(core): add fallback to absolute imports in guild.py 2024-11-17 22:13:11 +00:00
pacnpal
7a11a88143 fix(core): add fallback to absolute imports in events.py 2024-11-17 22:12:27 +00:00
pacnpal
fe4353ec96 fix(core): add fallback to absolute imports in error_handler.py 2024-11-17 22:11:48 +00:00
pacnpal
6c7f7fd5ad fix(core): add fallback to absolute imports in commands.py 2024-11-17 22:11:11 +00:00
pacnpal
26f173ce72 fix(core): add fallback to absolute imports in cleanup.py 2024-11-17 22:10:44 +00:00
pacnpal
c0c70f346e fix(core): add fallback to absolute imports in base.py 2024-11-17 22:10:12 +00:00
pacnpal
6cba32c6b3 standardized 2024-11-17 22:09:41 +00:00
pacnpal
1c1efff0cf fix(processor): add fallback to absolute imports in cleanup_manager 2024-11-17 22:06:16 +00:00
pacnpal
13c0cbd9d8 fix(processor): add fallback to absolute imports in queue_handler 2024-11-17 22:03:55 +00:00
pacnpal
1ddc4002fa fix(processor): add fallback to absolute imports in message_handler 2024-11-17 21:58:25 +00:00
pacnpal
ca5571750f fix(processor): add fallback to absolute imports in queue_processor 2024-11-17 21:56:25 +00:00
pacnpal
d1b5e4156a fix(core): simplify relative import in core/__init__.py 2024-11-17 21:53:23 +00:00
pacnpal
3fed7a7a6c fix(core): add fallback to absolute imports in component_manager 2024-11-17 21:52:53 +00:00
pacnpal
91e34a6639 fix(processor): correct relative import path for progress_tracker 2024-11-17 21:47:26 +00:00
pacnpal
d9fc0f360f Identified cyclic dependency between processor and utils packages
Created new shared package with centralized progress tracking:

videoarchiver/shared/progress.py
videoarchiver/shared/init.py
Refactored compression_manager.py to use shared progress module instead of importing from processor

Architecture improvements:

Better separation of concerns
Eliminated cyclic dependencies
Centralized progress tracking
Improved maintainability
2024-11-17 21:40:50 +00:00
pacnpal
b8f29341ce fixes 2024-11-17 21:33:12 +00:00
pacnpal
439cf5ff07 Using TYPE_CHECKING for type hints
Moving runtime imports to appropriate locations
Using string literal type annotations
Importing shared utilities through the utils package
2024-11-17 21:24:49 +00:00
pacnpal
e997c6f6b9 Created a proper dependency hierarchy:
core/types.py - Contains shared interfaces and types
queue/types.py - Contains queue-specific types
Components now depend on interfaces rather than concrete implementations
Broke cyclic dependencies:

Removed direct imports between queue_processor.py and manager.py
Removed circular dependencies between core and processor modules
Components now communicate through well-defined interfaces
Improved architecture:

Clear separation of concerns
Better dependency management
More maintainable and testable code
Proper use of dependency injection
2024-11-17 21:11:00 +00:00
pacnpal
063258513e Creating a shared types module (types.py) for common types and interfaces
Updating queue_processor.py to use the shared types
Updating manager.py to use the correct imports and shared types
The cyclic dependency has been resolved by:

Moving shared types to a separate module
Having queue_processor.py only import from shared modules
Having manager.py use the QueueProcessor from queue/processor.py
2024-11-17 20:58:14 +00:00
pacnpal
aa61c738a2 fixed more imports 2024-11-17 20:46:22 +00:00
pacnpal
4fc2afc446 fixed some more imports 2024-11-17 20:43:55 +00:00
pacnpal
ad8a4e3dbe import fix 2024-11-17 20:39:12 +00:00
pacnpal
1fdabee127 Fix: Update processor/__init__.py to use relative imports to resolve ModuleNotFoundError 2024-11-17 20:20:39 +00:00
pacnpal
97dd6d72f2 loads of import fixes 2024-11-17 19:47:18 +00:00
pacnpal
f71e174c0d Fixed incorrect import paths in videoarchiver/utils/__init__.py by removing redundant .utils prefix 2024-11-17 16:27:29 +00:00
pacnpal
b1e3f0c9d6 fixed imports hopefully 2024-11-17 16:22:22 +00:00
pacnpal
3d4d385559 fixed imports hopefully 2024-11-17 16:21:17 +00:00
pacnpal
074b462a1b Updated videoarchiver/__init__.py to include all relevant classes from subdirectories 2024-11-17 16:15:27 +00:00
pacnpal
0db1f31f8f Updated videoarchiver/__init__.py to use relative imports for Red-DiscordBot best practices 2024-11-17 16:11:42 +00:00
pacnpal
29606683d4 Updated videoarchiver/__init__.py to include all imports from cog subdirectories 2024-11-17 16:10:20 +00:00
pacnpal
825ac0ce2c Updated videoarchiver/queue/__init__.py to import all modules from queue and cleaners subdirectory 2024-11-17 16:07:17 +00:00
pacnpal
62c97f0b01 Converted all 'from videoarchiver.' imports to relative imports 2024-11-17 16:05:12 +00:00
pacnpal
c830be2841 videoarchiver/config/validation_manager.py
videoarchiver/config/role_manager.py
videoarchiver/database/connection_manager.py
videoarchiver/database/schema_manager.py
videoarchiver/queue/cleaners/tracking_cleaner.py
videoarchiver/exceptions.py
videoarchiver/processor.py
videoarchiver/commands.py
videoarchiver/update_checker.py
videoarchiver/utils/path_manager.py
videoarchiver/utils/file_ops.py
videoarchiver/processor/message_validator.py
videoarchiver/utils/download_manager.py
2024-11-17 06:12:41 +00:00
pacnpal
973714e281 fix 2024-11-17 03:15:35 +00:00
pacnpal
a5c3101d78 1 2024-11-17 03:12:47 +00:00
pacnpal
4fe45458bf In the core module:
Updated base.py to use absolute imports
Updated cleanup.py to use absolute imports
Updated events.py to use absolute imports
Updated error_handler.py to use absolute imports
Updated guild.py to use absolute imports
Updated initialization.py to use absolute imports
Updated lifecycle.py to use absolute imports
Updated response_handler.py to use absolute imports
Updated settings.py to use absolute imports
In the core/commands module:
Updated archiver_commands.py to use absolute imports
Updated database_commands.py to use absolute imports
Updated settings_commands.py to use absolute imports
Left init.py unchanged as its relative imports are appropriate
In the processor module:
Updated core.py to use absolute imports
Updated processor/init.py to use absolute imports
Updated queue_handler.py to use absolute imports
Updated queue_processor.py to use absolute imports
Updated status_display.py to use absolute imports
Updated cleanup_manager.py to use absolute imports
2024-11-17 02:58:53 +00:00
pacnpal
0d67bcc4a7 lol 2024-11-17 02:10:22 +00:00
pacnpal
247381fc8a Changing the relative import in core.py to use an absolute import path:
from videoarchiver.utils import progress_tracker
Updated the main init.py to properly handle module reloading:
Added 'videoarchiver.processor' and 'videoarchiver.processor.core' to modules_to_reload
Added explicit import and reload of the processor module
These changes ensure that:

The progress_tracker is properly imported from the utils package
All necessary modules are reloaded during initialization
Circular imports are avoided
The package structure maintains proper dependency flow
2024-11-17 01:29:00 +00:00
pacnpal
b10722f05b Moved progress_tracker.py to utils/ as the single source of truth
Implemented proper singleton pattern in ProgressTracker class
Created shared instance in utils/init.py
Updated all files to use relative imports correctly
Removed duplicate progress_tracker.py from processor/
Fixed circular imports by removing ProgressTracker from processor.py re-exports
2024-11-17 01:24:03 +00:00