pacnpal/Roo-Code
1
0
Fork 0
mirror of https://github.com/pacnpal/Roo-Code.git synced 2025-12-20 12:21:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Persist API conversation history locally instead of in state as there seems to be an issue with some messages not being stringifyable

Browse Source
This commit is contained in:
Saoud Rizwan
2024-08-01 15:18:29 -04:00
parent d84e6c6fb1
commit 07f50e63a3
4 changed files with 23 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/providers/ClaudeDevProvider.ts
View File

@@ -440,22 +440,33 @@ export class ClaudeDevProvider implements vscode.WebviewViewProvider {
// conversation history to send in API requests
/*
It seems that some API messages do not comply with vscode state requirements. Either the Anthropic library is manipulating these values somehow in the backend in a way thats creating cyclic references, or the API returns a function or a Symbol as part of the message content.
VSCode docs about state: "The value must be JSON-stringifyable ... value — A value. MUST not contain cyclic references."
For now we'll store the conversation history in memory, and if we need to store in state directly we'd need to do a manual conversion to ensure proper json stringification.
*/
private apiConversationHistory: Anthropic.MessageParam[] = []
async getApiConversationHistory(): Promise<Anthropic.MessageParam[]> {
const history = (await this.getGlobalState(
this.getApiConversationHistoryStateKey()
)) as Anthropic.MessageParam[]
return history || []
// const history = (await this.getGlobalState(
// this.getApiConversationHistoryStateKey()
// )) as Anthropic.MessageParam[]
// return history || []
return this.apiConversationHistory
}
async setApiConversationHistory(history: Anthropic.MessageParam[] | undefined) {
await this.updateGlobalState(this.getApiConversationHistoryStateKey(), history)
// await this.updateGlobalState(this.getApiConversationHistoryStateKey(), history)
this.apiConversationHistory = history || []
}
async addMessageToApiConversationHistory(message: Anthropic.MessageParam): Promise<Anthropic.MessageParam[]> {
const history = await this.getApiConversationHistory()
history.push(message)
await this.setApiConversationHistory(history)
return history
// const history = await this.getApiConversationHistory()
// history.push(message)
// await this.setApiConversationHistory(history)
// return history
this.apiConversationHistory.push(message)
return this.apiConversationHistory
}
/*