Minor fixes

This commit is contained in:
Saoud Rizwan
2024-09-18 12:32:18 -04:00
parent 22bf10420e
commit 3ea20ab8db

View File

@@ -1,5 +1,5 @@
import React, { useEffect, useRef, useState } from "react" import React, { useEffect, useMemo, useRef } from "react"
import { getContextMenuOptions, ContextMenuOptionType, ContextMenuQueryItem } from "../utils/mention-context" import { ContextMenuOptionType, ContextMenuQueryItem, getContextMenuOptions } from "../utils/mention-context"
import { formatFilePathForTruncation } from "./CodeAccordian" import { formatFilePathForTruncation } from "./CodeAccordian"
interface ContextMenuProps { interface ContextMenuProps {
@@ -21,14 +21,12 @@ const ContextMenu: React.FC<ContextMenuProps> = ({
selectedType, selectedType,
queryItems, queryItems,
}) => { }) => {
const [filteredOptions, setFilteredOptions] = useState<ContextMenuQueryItem[]>(
getContextMenuOptions(searchQuery, selectedType, queryItems)
)
const menuRef = useRef<HTMLDivElement>(null) const menuRef = useRef<HTMLDivElement>(null)
useEffect(() => { const filteredOptions = useMemo(
setFilteredOptions(getContextMenuOptions(searchQuery, selectedType, queryItems)) () => getContextMenuOptions(searchQuery, selectedType, queryItems),
}, [searchQuery, selectedType, queryItems]) [searchQuery, selectedType, queryItems]
)
useEffect(() => { useEffect(() => {
if (menuRef.current) { if (menuRef.current) {
@@ -120,6 +118,7 @@ const ContextMenu: React.FC<ContextMenuProps> = ({
maxHeight: "200px", maxHeight: "200px",
overflowY: "auto", overflowY: "auto",
}}> }}>
{/* Can't use virtuoso since it requires fixed height and menu height is dynamic based on # of items */}
{filteredOptions.map((option, index) => ( {filteredOptions.map((option, index) => (
<div <div
key={`${option.type}-${option.value || index}`} key={`${option.type}-${option.value || index}`}