From 5f3ace437981efb78b13b9fe8240c093c0cbda9f Mon Sep 17 00:00:00 2001 From: Matt Rubens Date: Tue, 7 Jan 2025 22:38:54 -0500 Subject: [PATCH] Minor code cleanup --- src/core/webview/ClineProvider.ts | 3 --- webview-ui/src/components/settings/GlamaModelPicker.tsx | 6 ++---- webview-ui/src/components/settings/OpenAiModelPicker.tsx | 6 ++---- .../src/components/settings/OpenRouterModelPicker.tsx | 6 ++---- 4 files changed, 6 insertions(+), 15 deletions(-) diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts index 2e64379..da75d27 100644 --- a/src/core/webview/ClineProvider.ts +++ b/src/core/webview/ClineProvider.ts @@ -889,9 +889,6 @@ export class ClineProvider implements vscode.WebviewViewProvider { await this.postStateToWebview() } } - - // this.postMessageToWebview({ type: "listApiConfig", listApiConfig }) - } catch (error) { console.error("Error delete api configuration:", error) vscode.window.showErrorMessage("Failed to delete api configuration") diff --git a/webview-ui/src/components/settings/GlamaModelPicker.tsx b/webview-ui/src/components/settings/GlamaModelPicker.tsx index 2df9984..fcc3269 100644 --- a/webview-ui/src/components/settings/GlamaModelPicker.tsx +++ b/webview-ui/src/components/settings/GlamaModelPicker.tsx @@ -39,10 +39,8 @@ const GlamaModelPicker: React.FC = () => { useEffect(() => { - if (apiConfiguration?.glamaModelId) { - if (apiConfiguration?.glamaModelId !== searchTerm) { - setSearchTerm(apiConfiguration?.glamaModelId) - } + if (apiConfiguration?.glamaModelId && apiConfiguration?.glamaModelId !== searchTerm) { + setSearchTerm(apiConfiguration?.glamaModelId) } }, [apiConfiguration, searchTerm]) diff --git a/webview-ui/src/components/settings/OpenAiModelPicker.tsx b/webview-ui/src/components/settings/OpenAiModelPicker.tsx index cb8a6a4..1e192ed 100644 --- a/webview-ui/src/components/settings/OpenAiModelPicker.tsx +++ b/webview-ui/src/components/settings/OpenAiModelPicker.tsx @@ -29,10 +29,8 @@ const OpenAiModelPicker: React.FC = () => { } useEffect(() => { - if (apiConfiguration?.openAiModelId) { - if (apiConfiguration?.openAiModelId !== searchTerm) { - setSearchTerm(apiConfiguration?.openAiModelId) - } + if (apiConfiguration?.openAiModelId && apiConfiguration?.openAiModelId !== searchTerm) { + setSearchTerm(apiConfiguration?.openAiModelId) } }, [apiConfiguration, searchTerm]) diff --git a/webview-ui/src/components/settings/OpenRouterModelPicker.tsx b/webview-ui/src/components/settings/OpenRouterModelPicker.tsx index df2883c..b8ba201 100644 --- a/webview-ui/src/components/settings/OpenRouterModelPicker.tsx +++ b/webview-ui/src/components/settings/OpenRouterModelPicker.tsx @@ -38,10 +38,8 @@ const OpenRouterModelPicker: React.FC = () => { }, [apiConfiguration]) useEffect(() => { - if (apiConfiguration?.openRouterModelId) { - if (apiConfiguration?.openRouterModelId !== searchTerm) { - setSearchTerm(apiConfiguration?.openRouterModelId) - } + if (apiConfiguration?.openRouterModelId && apiConfiguration?.openRouterModelId !== searchTerm) { + setSearchTerm(apiConfiguration?.openRouterModelId) } }, [apiConfiguration, searchTerm])