From 7dd161824baf880950d91a0b858c72fe755d9a32 Mon Sep 17 00:00:00 2001
From: sam hoang <samhv.ict@gmail.com>
Date: Mon, 27 Jan 2025 15:04:26 +0700
Subject: [PATCH] refactor: remove redundant experimentConfigs array, use
 experimentConfigsMap directly

---
 src/core/webview/ClineProvider.ts                   | 8 +-------
 src/shared/experiments.ts                           | 2 --
 webview-ui/src/components/settings/SettingsView.tsx | 4 ++--
 3 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts
index 09f4e77..d2db67f 100644
--- a/src/core/webview/ClineProvider.ts
+++ b/src/core/webview/ClineProvider.ts
@@ -40,13 +40,7 @@ import { singleCompletionHandler } from "../../utils/single-completion-handler"
 import { getCommitInfo, searchCommits, getWorkingState } from "../../utils/git"
 import { ConfigManager } from "../config/ConfigManager"
 import { CustomModesManager } from "../config/CustomModesManager"
-import {
-	EXPERIMENT_IDS,
-	experimentConfigs,
-	experiments as Experiments,
-	experimentDefault,
-	ExperimentId,
-} from "../../shared/experiments"
+import { EXPERIMENT_IDS, experiments as Experiments, experimentDefault, ExperimentId } from "../../shared/experiments"
 import { CustomSupportPrompts, supportPrompt } from "../../shared/support-prompt"
 
 import { ACTION_NAMES } from "../CodeActionProvider"
diff --git a/src/shared/experiments.ts b/src/shared/experiments.ts
index 962a32b..0418334 100644
--- a/src/shared/experiments.ts
+++ b/src/shared/experiments.ts
@@ -41,8 +41,6 @@ export const experimentConfigsMap: Record<ExperimentKey, ExperimentConfig> = {
 	},
 }
 
-// Keep the array version for backward compatibility
-export const experimentConfigs = Object.values(experimentConfigsMap)
 export const experimentDefault = Object.fromEntries(
 	Object.entries(experimentConfigsMap).map(([_, config]) => [config.id, config.enabled]),
 ) as Record<ExperimentId, boolean>
diff --git a/webview-ui/src/components/settings/SettingsView.tsx b/webview-ui/src/components/settings/SettingsView.tsx
index b78abd8..0db367f 100644
--- a/webview-ui/src/components/settings/SettingsView.tsx
+++ b/webview-ui/src/components/settings/SettingsView.tsx
@@ -5,7 +5,7 @@ import { validateApiConfiguration, validateModelId } from "../../utils/validate"
 import { vscode } from "../../utils/vscode"
 import ApiOptions from "./ApiOptions"
 import ExperimentalFeature from "./ExperimentalFeature"
-import { experimentConfigs, EXPERIMENT_IDS, experimentConfigsMap } from "../../../../src/shared/experiments"
+import { EXPERIMENT_IDS, experimentConfigsMap } from "../../../../src/shared/experiments"
 import ApiConfigManager from "./ApiConfigManager"
 
 type SettingsViewProps = {
@@ -646,7 +646,7 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
 								</p>
 							</div>
 						)}
-						{experimentConfigs
+						{Object.values(experimentConfigsMap)
 							.filter((config) => config.id !== EXPERIMENT_IDS.DIFF_STRATEGY)
 							.map((config) => (
 								<ExperimentalFeature