Merge pull request #632 from psv2522/sliders-on-newline

fix: Move sliders to newline in settings to avoid horizontal scroll.
This commit is contained in:
Matt Rubens
2025-01-30 01:15:49 -05:00
committed by GitHub

View File

@@ -139,6 +139,20 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
} }
} }
const sliderLabelStyle = {
minWidth: "45px",
textAlign: "right" as const,
lineHeight: "20px",
paddingBottom: "2px",
}
const sliderStyle = {
flexGrow: 1,
maxWidth: "80%",
accentColor: "var(--vscode-button-background)",
height: "2px",
}
return ( return (
<div <div
style={{ style={{
@@ -481,8 +495,9 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
</div> </div>
<div style={{ marginBottom: 15 }}> <div style={{ marginBottom: 15 }}>
<div style={{ display: "flex", flexDirection: "column", gap: "5px" }}>
<span style={{ fontWeight: "500" }}>Screenshot quality</span>
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}> <div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
<span style={{ fontWeight: "500", minWidth: "100px" }}>Screenshot quality</span>
<input <input
type="range" type="range"
min="1" min="1"
@@ -491,12 +506,11 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
value={screenshotQuality ?? 75} value={screenshotQuality ?? 75}
onChange={(e) => setScreenshotQuality(parseInt(e.target.value))} onChange={(e) => setScreenshotQuality(parseInt(e.target.value))}
style={{ style={{
flexGrow: 1, ...sliderStyle,
accentColor: "var(--vscode-button-background)",
height: "2px",
}} }}
/> />
<span style={{ minWidth: "35px", textAlign: "left" }}>{screenshotQuality ?? 75}%</span> <span style={{ ...sliderLabelStyle }}>{screenshotQuality ?? 75}%</span>
</div>
</div> </div>
<p <p
style={{ style={{
@@ -559,8 +573,9 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
<div style={{ marginBottom: 40 }}> <div style={{ marginBottom: 40 }}>
<h3 style={{ color: "var(--vscode-foreground)", margin: "0 0 15px 0" }}>Advanced Settings</h3> <h3 style={{ color: "var(--vscode-foreground)", margin: "0 0 15px 0" }}>Advanced Settings</h3>
<div style={{ marginBottom: 15 }}> <div style={{ marginBottom: 15 }}>
<div style={{ display: "flex", flexDirection: "column", gap: "5px" }}>
<span style={{ fontWeight: "500" }}>Terminal output limit</span>
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}> <div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
<span style={{ fontWeight: "500", minWidth: "150px" }}>Terminal output limit</span>
<input <input
type="range" type="range"
min="100" min="100"
@@ -568,15 +583,10 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
step="100" step="100"
value={terminalOutputLineLimit ?? 500} value={terminalOutputLineLimit ?? 500}
onChange={(e) => setTerminalOutputLineLimit(parseInt(e.target.value))} onChange={(e) => setTerminalOutputLineLimit(parseInt(e.target.value))}
style={{ style={{ ...sliderStyle }}
flexGrow: 1,
accentColor: "var(--vscode-button-background)",
height: "2px",
}}
/> />
<span style={{ minWidth: "45px", textAlign: "left" }}> <span style={{ ...sliderLabelStyle }}>{terminalOutputLineLimit ?? 500}</span>
{terminalOutputLineLimit ?? 500} </div>
</span>
</div> </div>
<p style={{ fontSize: "12px", marginTop: "5px", color: "var(--vscode-descriptionForeground)" }}> <p style={{ fontSize: "12px", marginTop: "5px", color: "var(--vscode-descriptionForeground)" }}>
Maximum number of lines to include in terminal output when executing commands. When exceeded Maximum number of lines to include in terminal output when executing commands. When exceeded
@@ -614,8 +624,10 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
enabled={experiments[EXPERIMENT_IDS.DIFF_STRATEGY] ?? false} enabled={experiments[EXPERIMENT_IDS.DIFF_STRATEGY] ?? false}
onChange={(enabled) => setExperimentEnabled(EXPERIMENT_IDS.DIFF_STRATEGY, enabled)} onChange={(enabled) => setExperimentEnabled(EXPERIMENT_IDS.DIFF_STRATEGY, enabled)}
/> />
<div style={{ display: "flex", alignItems: "center", gap: "5px", marginTop: "15px" }}> <div
<span style={{ fontWeight: "500", minWidth: "100px" }}>Match precision</span> style={{ display: "flex", flexDirection: "column", gap: "5px", marginTop: "15px" }}>
<span style={{ fontWeight: "500" }}>Match precision</span>
<div style={{ display: "flex", alignItems: "center", gap: "5px" }}>
<input <input
type="range" type="range"
min="0.8" min="0.8"
@@ -626,15 +638,14 @@ const SettingsView = ({ onDone }: SettingsViewProps) => {
setFuzzyMatchThreshold(parseFloat(e.target.value)) setFuzzyMatchThreshold(parseFloat(e.target.value))
}} }}
style={{ style={{
flexGrow: 1, ...sliderStyle,
accentColor: "var(--vscode-button-background)",
height: "2px",
}} }}
/> />
<span style={{ minWidth: "35px", textAlign: "left" }}> <span style={{ ...sliderLabelStyle }}>
{Math.round((fuzzyMatchThreshold || 1) * 100)}% {Math.round((fuzzyMatchThreshold || 1) * 100)}%
</span> </span>
</div> </div>
</div>
<p <p
style={{ style={{
fontSize: "12px", fontSize: "12px",