mirror of
https://github.com/pacnpal/Roo-Code.git
synced 2025-12-20 12:21:13 -05:00
Fixes to the auto approve menu
This commit is contained in:
@@ -144,104 +144,6 @@ describe('ChatView - Auto Approval Tests', () => {
|
||||
jest.clearAllMocks()
|
||||
})
|
||||
|
||||
it('defaults autoApprovalEnabled to true if any individual auto-approval flags are true', async () => {
|
||||
render(
|
||||
<ExtensionStateContextProvider>
|
||||
<ChatView
|
||||
isHidden={false}
|
||||
showAnnouncement={false}
|
||||
hideAnnouncement={() => {}}
|
||||
showHistoryView={() => {}}
|
||||
/>
|
||||
</ExtensionStateContextProvider>
|
||||
)
|
||||
|
||||
// Test cases with different individual flags
|
||||
const testCases = [
|
||||
{ alwaysAllowBrowser: true },
|
||||
{ alwaysAllowReadOnly: true },
|
||||
{ alwaysAllowWrite: true },
|
||||
{ alwaysAllowExecute: true },
|
||||
{ alwaysAllowMcp: true }
|
||||
]
|
||||
|
||||
for (const flags of testCases) {
|
||||
// Reset state
|
||||
mockPostMessage({
|
||||
...flags,
|
||||
clineMessages: []
|
||||
})
|
||||
|
||||
// Send an action that should be auto-approved
|
||||
mockPostMessage({
|
||||
...flags,
|
||||
clineMessages: [
|
||||
{
|
||||
type: 'say',
|
||||
say: 'task',
|
||||
ts: Date.now() - 2000,
|
||||
text: 'Initial task'
|
||||
},
|
||||
{
|
||||
type: 'ask',
|
||||
ask: flags.alwaysAllowBrowser ? 'browser_action_launch' :
|
||||
flags.alwaysAllowReadOnly ? 'tool' :
|
||||
flags.alwaysAllowWrite ? 'tool' :
|
||||
flags.alwaysAllowExecute ? 'command' :
|
||||
'use_mcp_server',
|
||||
ts: Date.now(),
|
||||
text: flags.alwaysAllowBrowser ? JSON.stringify({ action: 'launch', url: 'http://example.com' }) :
|
||||
flags.alwaysAllowReadOnly ? JSON.stringify({ tool: 'readFile', path: 'test.txt' }) :
|
||||
flags.alwaysAllowWrite ? JSON.stringify({ tool: 'editedExistingFile', path: 'test.txt' }) :
|
||||
flags.alwaysAllowExecute ? 'npm test' :
|
||||
JSON.stringify({ type: 'use_mcp_tool', serverName: 'test', toolName: 'test' }),
|
||||
partial: false
|
||||
}
|
||||
]
|
||||
})
|
||||
|
||||
// Wait for auto-approval
|
||||
await waitFor(() => {
|
||||
expect(vscode.postMessage).toHaveBeenCalledWith({
|
||||
type: 'askResponse',
|
||||
askResponse: 'yesButtonClicked'
|
||||
})
|
||||
})
|
||||
}
|
||||
|
||||
// Verify no auto-approval when no flags are true
|
||||
jest.clearAllMocks()
|
||||
mockPostMessage({
|
||||
alwaysAllowBrowser: false,
|
||||
alwaysAllowReadOnly: false,
|
||||
alwaysAllowWrite: false,
|
||||
alwaysAllowExecute: false,
|
||||
alwaysAllowMcp: false,
|
||||
clineMessages: [
|
||||
{
|
||||
type: 'say',
|
||||
say: 'task',
|
||||
ts: Date.now() - 2000,
|
||||
text: 'Initial task'
|
||||
},
|
||||
{
|
||||
type: 'ask',
|
||||
ask: 'browser_action_launch',
|
||||
ts: Date.now(),
|
||||
text: JSON.stringify({ action: 'launch', url: 'http://example.com' }),
|
||||
partial: false
|
||||
}
|
||||
]
|
||||
})
|
||||
|
||||
// Wait a bit to ensure no auto-approval happens
|
||||
await new Promise(resolve => setTimeout(resolve, 100))
|
||||
expect(vscode.postMessage).not.toHaveBeenCalledWith({
|
||||
type: 'askResponse',
|
||||
askResponse: 'yesButtonClicked'
|
||||
})
|
||||
})
|
||||
|
||||
it('does not auto-approve any actions when autoApprovalEnabled is false', () => {
|
||||
render(
|
||||
<ExtensionStateContextProvider>
|
||||
|
||||
Reference in New Issue
Block a user