pacnpal/citron
1
0
Fork 0
mirror of https://git.eden-emu.dev/archive/citron synced 2026-03-22 17:46:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(rev): Mistakenly placed 12 instead of 15

Browse Source 
Signed-off-by: Collecting <collecting@noreply.localhost>
This commit is contained in:
Collecting
2026-01-14 04:03:51 +00:00
parent c36557be77
commit 9bccbc5a1e
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/audio_core/renderer/command/command_generator.cpp
View File

@@ -363,14 +363,14 @@ void CommandGenerator::GenerateBiquadFilterEffectCommand(const s16 buffer_offset
EffectInfoBase& effect_info, EffectInfoBase& effect_info,
const s32 node_id) { const s32 node_id) {
u8* raw_params = effect_info.GetParameter(); u8* raw_params = effect_info.GetParameter();
// REV15 introduced the new native float-based Biquad Filter structure (Version 2).
// REV14 and older (including Rev 12 splitter updates) still use the Int16 version.
const bool is_rev15 = render_context.behavior->GetProcessRevision() >= 15;
// Revision 12 introduced the new float-based Biquad Filter if (is_rev15) {
// Revision 11 and older use the original Int16 version
const bool is_rev12 = render_context.behavior->GetProcessRevision() >= 12;
if (is_rev12) {
auto& parameter = *reinterpret_cast<BiquadFilterInfo::ParameterVersion2*>(raw_params); auto& parameter = *reinterpret_cast<BiquadFilterInfo::ParameterVersion2*>(raw_params);
s8 channels = parameter.channel_count; s8 channels = parameter.channel_count;
if (channels > 6 || channels < 0) channels = 0; if (channels > 6 || channels < 0) channels = 0;
@@ -385,10 +385,10 @@ void CommandGenerator::GenerateBiquadFilterEffectCommand(const s16 buffer_offset
command_buffer.GenerateCopyMixBufferCommand(node_id, effect_info, buffer_offset, channel); command_buffer.GenerateCopyMixBufferCommand(node_id, effect_info, buffer_offset, channel);
} }
} }
parameter.state = EffectInfoBase::ParameterState::Updated; // Offset 0x25 parameter.state = EffectInfoBase::ParameterState::Updated;
} else { } else {
auto& parameter = *reinterpret_cast<BiquadFilterInfo::ParameterVersion1*>(raw_params); auto& parameter = *reinterpret_cast<BiquadFilterInfo::ParameterVersion1*>(raw_params);
s8 channels = parameter.channel_count; s8 channels = parameter.channel_count;
if (channels > 6 || channels < 0) channels = 0; if (channels > 6 || channels < 0) channels = 0;
@@ -418,7 +418,7 @@ void CommandGenerator::GenerateBiquadFilterEffectCommand(const s16 buffer_offset
command_buffer.GenerateCopyMixBufferCommand(node_id, effect_info, buffer_offset, channel); command_buffer.GenerateCopyMixBufferCommand(node_id, effect_info, buffer_offset, channel);
} }
} }
parameter.state = EffectInfoBase::ParameterState::Updated; // Offset 0x17 parameter.state = EffectInfoBase::ParameterState::Updated;
} }
} }