pacnpal/citron
1
0
Fork 0
mirror of https://git.eden-emu.dev/archive/citron synced 2026-03-23 01:56:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(renderer): TAA graphical artifacts and pixel noise on AMD hardware

Browse Source 
Signed-off-by: Collecting <collecting@noreply.localhost>
This commit is contained in:
Collecting
2026-01-08 03:10:29 +00:00
parent 051bf4b6b8
commit b15302cf24
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/video_core/renderer_vulkan/present/taa.cpp
View File

@@ -286,6 +286,17 @@ void TAA::UploadImages(Scheduler& scheduler) {
if (m_images_ready) { if (m_images_ready) {
return; return;
} }
scheduler.Record([&](vk::CommandBuffer cmdbuf) {
for (auto& image : m_dynamic_images) {
ClearColorImage(cmdbuf, *image.image);
ClearColorImage(cmdbuf, *image.previous_image);
ClearColorImage(cmdbuf, *image.motion_image);
ClearColorImage(cmdbuf, *image.depth_image);
}
});
scheduler.Finish();
m_images_ready = true; m_images_ready = true;
} }
@@ -326,6 +337,10 @@ void TAA::Draw(Scheduler& scheduler, size_t image_index, VkImage* inout_image,
// Copy current frame to previous frame for next iteration // Copy current frame to previous frame for next iteration
scheduler.Record([this, &image](vk::CommandBuffer cmdbuf) { scheduler.Record([this, &image](vk::CommandBuffer cmdbuf) {
// Transition images for copying
TransitionImageLayout(cmdbuf, *image.image, VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL);
TransitionImageLayout(cmdbuf, *image.previous_image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL);
const VkImageCopy copy_region{ const VkImageCopy copy_region{
.srcSubresource = {VK_IMAGE_ASPECT_COLOR_BIT, 0, 0, 1}, .srcSubresource = {VK_IMAGE_ASPECT_COLOR_BIT, 0, 0, 1},
.srcOffset = {0, 0, 0}, .srcOffset = {0, 0, 0},
@@ -335,8 +350,12 @@ void TAA::Draw(Scheduler& scheduler, size_t image_index, VkImage* inout_image,
}; };
cmdbuf.CopyImage(*image.image, VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, cmdbuf.CopyImage(*image.image, VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL,
*image.previous_image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, *image.previous_image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
copy_region); copy_region);
// Transition back to general use for the next frame
TransitionImageLayout(cmdbuf, *image.image, VK_IMAGE_LAYOUT_GENERAL);
TransitionImageLayout(cmdbuf, *image.previous_image, VK_IMAGE_LAYOUT_GENERAL);
}); });
*inout_image = *image.image; *inout_image = *image.image;
@@ -345,4 +364,4 @@ void TAA::Draw(Scheduler& scheduler, size_t image_index, VkImage* inout_image,
m_current_frame++; m_current_frame++;
} }
} // namespace Vulkan } // namespace Vulkan