pacnpal/django-anymail
1
0
Fork 0
mirror of https://github.com/pacnpal/django-anymail.git synced 2025-12-20 03:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Postmark: fix silent failures for send-time validation errors

Browse Source 
Postmark uses their ErrorCode 300 to report several different
send-time validation errors, some of which identify invalid
recipients that need to be handled specially, but many of which
are ordinary API errors.

Rework the logic for parsing ErrorCode 300 error messages:
Handle only "Invalid 'To'" or "Error parsing 'To'" (or 'Cc'
or 'Bcc') as recipient errors. Otherwise raise an API error.

Fixes #238 silent failure when sending with long metadata keys.
This commit is contained in:
Mike Edmunds
2021-05-19 13:15:34 -07:00
committed by GitHub
parent b1a4f9809a
commit 44754c908e
3 changed files with 59 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tests/test_postmark_backend.py
View File

@@ -709,6 +709,19 @@ class PostmarkBackendRecipientsRefusedTests(PostmarkBackendMockAPITestCase):
status = msg.anymail_status
self.assertEqual(status.recipients['Invalid@LocalHost'].status, 'invalid')
def test_recipients_parse_error(self):
self.set_mock_response(
status_code=422,
raw=b"""{
"ErrorCode": 300,
"Message": "Error parsing 'Cc': Illegal email domain '+' in address 'user@+'."
}""")
msg = mail.EmailMessage('Subject', 'Body', 'from@example.com', cc=["user@+"])
with self.assertRaises(AnymailRecipientsRefused):
msg.send()
status = msg.anymail_status
self.assertEqual(status.recipients['user@+'].status, 'invalid')
def test_from_email_invalid(self):
# Invalid 'From' address generates same Postmark ErrorCode 300 as invalid 'To',
# but should raise a different Anymail error
@@ -720,6 +733,33 @@ class PostmarkBackendRecipientsRefusedTests(PostmarkBackendMockAPITestCase):
with self.assertRaises(AnymailAPIError):
msg.send()
def test_reply_to_invalid(self):
# Make sure 'Reply-To' error doesn't get caught in invalid 'To' logic:
self.set_mock_response(
status_code=422,
raw=b"""{
"ErrorCode": 300,
"Message": "Error parsing 'Reply-To': Illegal email domain '+' in address 'invalid@+'."}
""")
msg = mail.EmailMessage('Subject', 'Body', 'from@example.com', ['to@example.com'],
reply_to=["invalid@+"])
with self.assertRaisesMessage(AnymailAPIError, "Error parsing 'Reply-To'"):
msg.send()
def test_errorcode_300(self):
# Various other problems generate same Postmark ErrorCode 300 as invalid 'To',
# but should raise ordinary API errors
self.set_mock_response(
status_code=422,
raw=b"""{
"ErrorCode": 300,
"Message": "Invalid metadata content. Field names are limited to 20 characters..."
}""")
msg = mail.EmailMessage('Subject', 'Body', 'from@example.com', ['to@example.com'])
msg.metadata = {"this-key-name-is-too-long": "data"}
with self.assertRaisesMessage(AnymailAPIError, "Invalid metadata content"):
msg.send()
def test_fail_silently(self):
self.set_mock_response(
status_code=422,