mirror of
https://github.com/pacnpal/django-anymail.git
synced 2025-12-20 11:51:05 -05:00
Don't access MANDRILL_API_URL setting at module level
Move MANDRILL_API_URL setting lookup into Djrill backend init (where it's used). Because "modules should not in general use settings stored in django.conf.settings at the top level". https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/#use-of-django-conf-settings
This commit is contained in:
@@ -5,7 +5,7 @@ from django.core.exceptions import ImproperlyConfigured
|
||||
from django.core.mail.backends.base import BaseEmailBackend
|
||||
from django.core.mail.message import sanitize_address, DEFAULT_ATTACHMENT_MIME_TYPE
|
||||
|
||||
from djrill import MANDRILL_API_URL, MandrillAPIError, NotSupportedByMandrillError, __version__
|
||||
from djrill import MandrillAPIError, NotSupportedByMandrillError, __version__
|
||||
|
||||
from base64 import b64encode
|
||||
from datetime import date, datetime
|
||||
@@ -47,7 +47,7 @@ class DjrillBackend(BaseEmailBackend):
|
||||
"""
|
||||
super(DjrillBackend, self).__init__(**kwargs)
|
||||
self.api_key = getattr(settings, "MANDRILL_API_KEY", None)
|
||||
self.api_url = MANDRILL_API_URL
|
||||
self.api_url = getattr(settings, "MANDRILL_API_URL", "https://mandrillapp.com/api/1.0")
|
||||
self.session = None
|
||||
self.global_settings = {}
|
||||
for setting_key in getattr(settings, "MANDRILL_SETTINGS", {}):
|
||||
|
||||
Reference in New Issue
Block a user