pacnpal/django-anymail
1
0
Fork 0
mirror of https://github.com/pacnpal/django-anymail.git synced 2025-12-20 03:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Properly encode path components used to construct API URLs

Browse Source 
Resolves #144 and similar potential issues
This commit is contained in:
medmunds
2019-02-23 15:27:41 -08:00
parent 578bad9a57
commit dabbdad3bd
4 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/test_mailgun_backend.py
View File

@@ -565,7 +565,7 @@ class MailgunBackendAnymailFeatureTests(MailgunBackendMockAPITestCase):
# (which returns a cryptic 200-OK "Mailgun Magnificent API" response).
self.message.from_email = "<from@example.com/invalid>"
with self.assertRaisesMessage(AnymailError,
"Invalid sender domain 'example.com/invalid'"):
"Invalid '/' in sender domain 'example.com/invalid'"):
self.message.send()
@override_settings(ANYMAIL_MAILGUN_SENDER_DOMAIN='example.com%2Finvalid')
@@ -573,9 +573,16 @@ class MailgunBackendAnymailFeatureTests(MailgunBackendMockAPITestCase):
# See previous test. Also, note that Mailgun unquotes % encoding *before*
# extracting the sender domain (so %2f is just as bad as '/')
with self.assertRaisesMessage(AnymailError,
"Invalid sender domain 'example.com%2Finvalid'"):
"Invalid '/' in sender domain 'example.com%2Finvalid'"):
self.message.send()
@override_settings(ANYMAIL_MAILGUN_SENDER_DOMAIN='example.com # oops')
def test_encode_sender_domain(self):
# See previous tests. For anything other than slashes, we let Mailgun detect
# the problem (but must properly encode the domain in the API URL)
self.message.send()
self.assert_esp_called('/example.com%20%23%20oops/messages')
def test_default_omits_options(self):
"""Make sure by default we don't send any ESP-specific options.