From 29fb04d03dcf5045b4d08f58f60265ba229a49e4 Mon Sep 17 00:00:00 2001
From: "gpt-engineer-app[bot]"
 <159125892+gpt-engineer-app[bot]@users.noreply.github.com>
Date: Tue, 21 Oct 2025 16:01:45 +0000
Subject: [PATCH] Fix feature path catch blocks

---
 src/components/admin/MarkdownEditor.tsx           |  2 +-
 src/components/admin/NovuMigrationUtility.tsx     |  2 +-
 src/components/admin/ProfileAuditLog.tsx          |  2 +-
 src/components/admin/SystemActivityLog.tsx        |  2 +-
 src/components/admin/TestDataGenerator.tsx        | 11 ++++++-----
 src/components/homepage/ContentTabs.tsx           |  2 +-
 src/components/homepage/FeaturedParks.tsx         |  2 +-
 src/components/parks/ParkGrid.tsx                 |  2 +-
 src/components/profile/AddRideCreditDialog.tsx    |  2 +-
 src/components/profile/RideCreditCard.tsx         |  6 +++---
 src/components/profile/UserBlockButton.tsx        |  2 +-
 src/components/profile/UserReviewsList.tsx        |  2 +-
 src/components/reviews/ReviewForm.tsx             |  2 +-
 src/components/reviews/ReviewsList.tsx            |  2 +-
 src/hooks/moderation/useEntityCache.ts            |  5 +++--
 src/hooks/moderation/useModerationFilters.ts      |  8 ++++----
 src/hooks/moderation/useModerationQueueManager.ts |  6 +++---
 src/hooks/moderation/usePagination.ts             |  4 ++--
 src/hooks/moderation/useProfileCache.ts           |  4 ++--
 src/hooks/useAutocompleteData.ts                  | 14 +++++++-------
 20 files changed, 42 insertions(+), 40 deletions(-)

diff --git a/src/components/admin/MarkdownEditor.tsx b/src/components/admin/MarkdownEditor.tsx
index 07f2223d..682f6681 100644
--- a/src/components/admin/MarkdownEditor.tsx
+++ b/src/components/admin/MarkdownEditor.tsx
@@ -154,7 +154,7 @@ export function MarkdownEditor({
                   if (!imageUrl) throw new Error('Failed to generate image URL');
                   
                   return imageUrl;
-                } catch (error) {
+                } catch (error: unknown) {
                   console.error('Image upload failed:', error);
                   throw new Error(error instanceof Error ? error.message : 'Failed to upload image');
                 }
diff --git a/src/components/admin/NovuMigrationUtility.tsx b/src/components/admin/NovuMigrationUtility.tsx
index 733a4392..e3456fab 100644
--- a/src/components/admin/NovuMigrationUtility.tsx
+++ b/src/components/admin/NovuMigrationUtility.tsx
@@ -72,7 +72,7 @@ export function NovuMigrationUtility() {
         title: "Migration completed",
         description: `Successfully migrated ${successCount} users. ${failureCount} failures.`,
       });
-    } catch (error) {
+    } catch (error: unknown) {
       const errorMsg = getErrorMessage(error);
       toast({
         variant: "destructive",
diff --git a/src/components/admin/ProfileAuditLog.tsx b/src/components/admin/ProfileAuditLog.tsx
index e9a2dd17..6e0fc49d 100644
--- a/src/components/admin/ProfileAuditLog.tsx
+++ b/src/components/admin/ProfileAuditLog.tsx
@@ -29,7 +29,7 @@ export function ProfileAuditLog() {
 
       if (error) throw error;
       setLogs((data || []) as AuditLogEntry[]);
-    } catch (error) {
+    } catch (error: unknown) {
       handleError(error, { action: 'Load audit logs' });
     } finally {
       setLoading(false);
diff --git a/src/components/admin/SystemActivityLog.tsx b/src/components/admin/SystemActivityLog.tsx
index 38ce618c..000c0b74 100644
--- a/src/components/admin/SystemActivityLog.tsx
+++ b/src/components/admin/SystemActivityLog.tsx
@@ -191,7 +191,7 @@ export const SystemActivityLog = forwardRef<SystemActivityLogRef, SystemActivity
           type: filterType === 'all' ? undefined : filterType,
         });
         setActivities(data);
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Error loading system activities:', error);
       } finally {
         setIsLoading(false);
diff --git a/src/components/admin/TestDataGenerator.tsx b/src/components/admin/TestDataGenerator.tsx
index 3b94fc40..3cd96a11 100644
--- a/src/components/admin/TestDataGenerator.tsx
+++ b/src/components/admin/TestDataGenerator.tsx
@@ -11,6 +11,7 @@ import { Collapsible, CollapsibleContent, CollapsibleTrigger } from '@/component
 import { AlertDialog, AlertDialogAction, AlertDialogCancel, AlertDialogContent, AlertDialogDescription, AlertDialogFooter, AlertDialogHeader, AlertDialogTitle, AlertDialogTrigger } from '@/components/ui/alert-dialog';
 import { supabase } from '@/integrations/supabase/client';
 import { useToast } from '@/hooks/use-toast';
+import { getErrorMessage } from '@/lib/errorHandler';
 import { Beaker, CheckCircle, ChevronDown, Trash2, AlertTriangle } from 'lucide-react';
 import { clearTestData, getTestDataStats } from '@/lib/testDataGenerator';
 
@@ -87,7 +88,7 @@ export function TestDataGenerator() {
     try {
       const data = await getTestDataStats();
       setStats(data);
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Failed to load stats:', error);
     }
   };
@@ -149,11 +150,11 @@ export function TestDataGenerator() {
       });
       
       await loadStats();
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Generation error:', error);
       toast({
         title: "Generation failed",
-        description: error.message || "Failed to generate test data",
+        description: getErrorMessage(error),
         variant: "destructive",
       });
     } finally {
@@ -173,11 +174,11 @@ export function TestDataGenerator() {
         description: `Removed ${deleted} test submissions`
       });
       setResults(null);
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Clear error:', error);
       toast({
         title: 'Clear Failed',
-        description: error.message,
+        description: getErrorMessage(error),
         variant: 'destructive'
       });
     } finally {
diff --git a/src/components/homepage/ContentTabs.tsx b/src/components/homepage/ContentTabs.tsx
index b08a22ae..427e85ff 100644
--- a/src/components/homepage/ContentTabs.tsx
+++ b/src/components/homepage/ContentTabs.tsx
@@ -91,7 +91,7 @@ export function ContentTabs() {
       setRecentRides(recentRidesData || []);
       setRecentChanges(processedChanges);
       setRecentlyOpened(combinedOpened);
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error fetching content:', error);
     } finally {
       setLoading(false);
diff --git a/src/components/homepage/FeaturedParks.tsx b/src/components/homepage/FeaturedParks.tsx
index 1da17ec5..5444c99a 100644
--- a/src/components/homepage/FeaturedParks.tsx
+++ b/src/components/homepage/FeaturedParks.tsx
@@ -41,7 +41,7 @@ export function FeaturedParks() {
 
       setTopRatedParks(topRated || []);
       setMostRidesParks(mostRides || []);
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error fetching featured parks:', error);
     } finally {
       setLoading(false);
diff --git a/src/components/parks/ParkGrid.tsx b/src/components/parks/ParkGrid.tsx
index b2efab30..45723f69 100644
--- a/src/components/parks/ParkGrid.tsx
+++ b/src/components/parks/ParkGrid.tsx
@@ -40,7 +40,7 @@ export function ParkGrid() {
 
       if (error) throw error;
       setParks(data || []);
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error fetching parks:', error);
     } finally {
       setLoading(false);
diff --git a/src/components/profile/AddRideCreditDialog.tsx b/src/components/profile/AddRideCreditDialog.tsx
index ce898b6a..e9f536a2 100644
--- a/src/components/profile/AddRideCreditDialog.tsx
+++ b/src/components/profile/AddRideCreditDialog.tsx
@@ -68,7 +68,7 @@ export function AddRideCreditDialog({ userId, open, onOpenChange, onSuccess }: A
       handleReset();
       onSuccess(data.id); // Pass the new ID
       onOpenChange(false);
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error adding credit:', error);
       toast.error(getErrorMessage(error));
     } finally {
diff --git a/src/components/profile/RideCreditCard.tsx b/src/components/profile/RideCreditCard.tsx
index 8f8508ca..0ce697c2 100644
--- a/src/components/profile/RideCreditCard.tsx
+++ b/src/components/profile/RideCreditCard.tsx
@@ -68,7 +68,7 @@ export function RideCreditCard({ credit, position, maxPosition, viewMode, isEdit
       setIsEditing(false);
       // Optimistic update - pass specific changes
       onUpdate(credit.id, { ride_count: editCount });
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error updating count:', error);
       toast.error(getErrorMessage(error));
     } finally {
@@ -91,7 +91,7 @@ export function RideCreditCard({ credit, position, maxPosition, viewMode, isEdit
       if (error) throw error;
 
       toast.success('Ride count increased');
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error incrementing count:', error);
       toast.error(getErrorMessage(error));
       // Rollback on error
@@ -111,7 +111,7 @@ export function RideCreditCard({ credit, position, maxPosition, viewMode, isEdit
     try {
       await onReorder(credit.id, editPosition);
       toast.success('Position updated');
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error changing position:', error);
       toast.error(getErrorMessage(error));
       setEditPosition(position);
diff --git a/src/components/profile/UserBlockButton.tsx b/src/components/profile/UserBlockButton.tsx
index ffd6ccfc..047e3c53 100644
--- a/src/components/profile/UserBlockButton.tsx
+++ b/src/components/profile/UserBlockButton.tsx
@@ -43,7 +43,7 @@ export function UserBlockButton({ targetUserId, targetUsername, variant = 'outli
       });
 
       setReason('');
-    } catch (error) {
+    } catch (error: unknown) {
       const errorMsg = getErrorMessage(error);
       console.error('Error blocking user:', errorMsg);
       toast({
diff --git a/src/components/profile/UserReviewsList.tsx b/src/components/profile/UserReviewsList.tsx
index 963b5c89..651955de 100644
--- a/src/components/profile/UserReviewsList.tsx
+++ b/src/components/profile/UserReviewsList.tsx
@@ -93,7 +93,7 @@ export function UserReviewsList({ userId, reviewCount }: UserReviewsListProps) {
 
       if (error) throw error;
       setReviews(data || []);
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error fetching reviews:', error);
       toast.error(getErrorMessage(error));
     } finally {
diff --git a/src/components/reviews/ReviewForm.tsx b/src/components/reviews/ReviewForm.tsx
index 6f3b75b7..55c3f8dd 100644
--- a/src/components/reviews/ReviewForm.tsx
+++ b/src/components/reviews/ReviewForm.tsx
@@ -120,7 +120,7 @@ export function ReviewForm({
       setRating(0);
       setPhotos([]);
       onReviewSubmitted();
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error submitting review:', error);
       toast({
         title: "Error",
diff --git a/src/components/reviews/ReviewsList.tsx b/src/components/reviews/ReviewsList.tsx
index acd55b7d..7f013f68 100644
--- a/src/components/reviews/ReviewsList.tsx
+++ b/src/components/reviews/ReviewsList.tsx
@@ -62,7 +62,7 @@ export function ReviewsList({ entityType, entityId, entityName }: ReviewsListPro
 
       const { data } = await query;
       setReviews((data || []) as ReviewWithProfile[]);
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Error fetching reviews:', error);
     } finally {
       setLoading(false);
diff --git a/src/hooks/moderation/useEntityCache.ts b/src/hooks/moderation/useEntityCache.ts
index 98b1d826..1d9ab80f 100644
--- a/src/hooks/moderation/useEntityCache.ts
+++ b/src/hooks/moderation/useEntityCache.ts
@@ -2,6 +2,7 @@ import { useRef, useCallback } from 'react';
 import { supabase } from '@/integrations/supabase/client';
 import { createTableQuery } from '@/lib/supabaseHelpers';
 import { logger } from '@/lib/logger';
+import { getErrorMessage } from '@/lib/errorHandler';
 import { MODERATION_CONSTANTS } from '@/lib/moderation/constants';
 import type { Database } from '@/integrations/supabase/types';
 
@@ -183,8 +184,8 @@ export function useEntityCache() {
       }
 
       return data || [];
-    } catch (error) {
-      logger.error(`Failed to bulk fetch ${type}:`, error);
+    } catch (error: unknown) {
+      logger.error(`Failed to bulk fetch ${type}:`, { error: getErrorMessage(error) });
       return [];
     }
   }, [getCached, setCached, getUncachedIds]);
diff --git a/src/hooks/moderation/useModerationFilters.ts b/src/hooks/moderation/useModerationFilters.ts
index dc38d828..4503fa6a 100644
--- a/src/hooks/moderation/useModerationFilters.ts
+++ b/src/hooks/moderation/useModerationFilters.ts
@@ -132,7 +132,7 @@ export function useModerationFilters(
       if (saved) {
         return JSON.parse(saved);
       }
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Failed to load persisted filters:', error);
     }
     
@@ -151,7 +151,7 @@ export function useModerationFilters(
           return parsed;
         }
       }
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Failed to load persisted sort:', error);
     }
     
@@ -193,7 +193,7 @@ export function useModerationFilters(
             activeTab,
           })
         );
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Failed to persist filters:', error);
       }
     }
@@ -204,7 +204,7 @@ export function useModerationFilters(
     if (persist) {
       try {
         localStorage.setItem(`${storageKey}_sort`, JSON.stringify(sortConfig));
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Failed to persist sort:', error);
       }
     }
diff --git a/src/hooks/moderation/useModerationQueueManager.ts b/src/hooks/moderation/useModerationQueueManager.ts
index fc6cc73d..3f94c641 100644
--- a/src/hooks/moderation/useModerationQueueManager.ts
+++ b/src/hooks/moderation/useModerationQueueManager.ts
@@ -330,7 +330,7 @@ export function useModerationQueueManager(config: ModerationQueueManagerConfig):
       
       // Refresh stats to update counts
       queue.refreshStats();
-      } catch (error) {
+      } catch (error: unknown) {
         const errorMsg = getErrorMessage(error);
         console.error("Error deleting submission:", errorMsg);
 
@@ -371,7 +371,7 @@ export function useModerationQueueManager(config: ModerationQueueManagerConfig):
         queue.refreshStats();
 
         setItems((prev) => prev.filter((i) => i.id !== item.id));
-      } catch (error) {
+      } catch (error: unknown) {
         const errorMsg = getErrorMessage(error);
         console.error("Error resetting submission:", errorMsg);
         toast({
@@ -439,7 +439,7 @@ export function useModerationQueueManager(config: ModerationQueueManagerConfig):
         
         // Refresh stats to update counts
         queue.refreshStats();
-      } catch (error) {
+      } catch (error: unknown) {
         const errorMsg = getErrorMessage(error);
         console.error("Error retrying failed items:", errorMsg);
         toast({
diff --git a/src/hooks/moderation/usePagination.ts b/src/hooks/moderation/usePagination.ts
index 0fd045de..a29d7e3f 100644
--- a/src/hooks/moderation/usePagination.ts
+++ b/src/hooks/moderation/usePagination.ts
@@ -121,7 +121,7 @@ export function usePagination(config: PaginationConfig = {}): PaginationState {
       if (saved) {
         return JSON.parse(saved);
       }
-    } catch (error) {
+    } catch (error: unknown) {
       console.error('Failed to load pagination state:', error);
     }
     
@@ -157,7 +157,7 @@ export function usePagination(config: PaginationConfig = {}): PaginationState {
             pageSize,
           })
         );
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Failed to persist pagination state:', error);
       }
     }
diff --git a/src/hooks/moderation/useProfileCache.ts b/src/hooks/moderation/useProfileCache.ts
index cd6c29f6..66da9d07 100644
--- a/src/hooks/moderation/useProfileCache.ts
+++ b/src/hooks/moderation/useProfileCache.ts
@@ -118,8 +118,8 @@ export function useProfileCache() {
       }
 
       return data || [];
-    } catch (error) {
-      logger.error('Failed to bulk fetch profiles:', error);
+    } catch (error: unknown) {
+      logger.error('Failed to bulk fetch profiles:', { error: getErrorMessage(error) });
       return [];
     }
   }, [getCached, setCached, getUncachedIds]);
diff --git a/src/hooks/useAutocompleteData.ts b/src/hooks/useAutocompleteData.ts
index 3c58d48a..17e17ab9 100644
--- a/src/hooks/useAutocompleteData.ts
+++ b/src/hooks/useAutocompleteData.ts
@@ -27,7 +27,7 @@ export function useCountries() {
             value: country.toLowerCase().replace(/\s+/g, '_')
           }))
         );
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Error fetching countries:', error);
         setCountries([]);
       } finally {
@@ -72,7 +72,7 @@ export function useStatesProvinces(country?: string) {
             value: state.toLowerCase().replace(/\s+/g, '_')
           }))
         );
-      } catch (error) {
+        } catch (error: unknown) {
         console.error('Error fetching states/provinces:', error);
         setStatesProvinces([]);
       } finally {
@@ -108,7 +108,7 @@ export function useManufacturers() {
             value: company.id
           }))
         );
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Error fetching manufacturers:', error);
         setManufacturers([]);
       } finally {
@@ -149,7 +149,7 @@ export function useRideModels(manufacturerId?: string) {
             value: model.id
           }))
         );
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Error fetching ride models:', error);
         setRideModels([]);
       } finally {
@@ -188,7 +188,7 @@ export function useCompanyHeadquarters() {
             value: hq.toLowerCase().replace(/\s+/g, '_')
           }))
         );
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Error fetching headquarters:', error);
         setHeadquarters([]);
       } finally {
@@ -224,7 +224,7 @@ export function useOperators() {
             value: company.id
           }))
         );
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Error fetching operators:', error);
         setOperators([]);
       } finally {
@@ -260,7 +260,7 @@ export function usePropertyOwners() {
             value: company.id
           }))
         );
-      } catch (error) {
+      } catch (error: unknown) {
         console.error('Error fetching property owners:', error);
         setPropertyOwners([]);
       } finally {