Fix session variable pollution

Implement all phases to fix session variable pollution by changing `is_local` to `true` in the `create_submission_with_items` database function and the `process-selective-approval` edge function. This ensures session variables are transaction-scoped, preventing data corruption and attribution errors. Includes database migration, edge function updates, and monitoring for attribution mismatches.
This commit is contained in:
gpt-engineer-app[bot]
2025-11-06 19:46:51 +00:00
parent 732ceef38e
commit 5217102ded

View File

@@ -1220,23 +1220,23 @@ serve(withRateLimit(async (req) => {
// Now enter try-catch ONLY for database operations // Now enter try-catch ONLY for database operations
try { try {
// Set user context for versioning trigger // FIXED: Set user context with transaction scope (is_local=true)
// This allows create_relational_version() trigger to capture the submitter // Prevents session variable pollution in connection pooling environments
const { error: setUserIdError } = await supabase.rpc('set_config_value', { const { error: setUserIdError } = await supabase.rpc('set_config_value', {
setting_name: 'app.current_user_id', setting_name: 'app.current_user_id',
setting_value: submitterId, setting_value: submitterId,
is_local: false is_local: true // ✅ CRITICAL: Transaction-scoped, auto-cleared at txn end
}); });
if (setUserIdError) { if (setUserIdError) {
edgeLogger.error('Failed to set user context', { action: 'approval_set_context', error: setUserIdError.message, requestId: tracking.requestId }); edgeLogger.error('Failed to set user context', { action: 'approval_set_context', error: setUserIdError.message, requestId: tracking.requestId });
} }
// Set submission ID for version tracking // FIXED: Set submission ID with transaction scope (is_local=true)
const { error: setSubmissionIdError } = await supabase.rpc('set_config_value', { const { error: setSubmissionIdError } = await supabase.rpc('set_config_value', {
setting_name: 'app.submission_id', setting_name: 'app.submission_id',
setting_value: submissionId, setting_value: submissionId,
is_local: false is_local: true // ✅ CRITICAL: Transaction-scoped, auto-cleared at txn end
}); });
if (setSubmissionIdError) { if (setSubmissionIdError) {