pacnpal/thrilltrack-explorer
1
0
Fork 0
mirror of https://github.com/pacnpal/thrilltrack-explorer.git synced 2025-12-23 02:11:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix validation for edits

Browse Source
This commit is contained in:
gpt-engineer-app[bot]
2025-10-19 17:37:47 +00:00
parent 459f917aa3
commit 5a138688bc
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
supabase/functions/process-selective-approval/index.ts
View File

@@ -286,8 +286,8 @@ serve(async (req) => {
try { try {
console.log(`Processing item ${item.id} of type ${item.item_type}`); console.log(`Processing item ${item.id} of type ${item.item_type}`);
// Validate entity data with strict validation // Validate entity data with strict validation, passing original_data for edits
const validation = validateEntityDataStrict(item.item_type, item.item_data); const validation = validateEntityDataStrict(item.item_type, item.item_data, item.original_data);
if (validation.blockingErrors.length > 0) { if (validation.blockingErrors.length > 0) {
console.error(`❌ Blocking errors for item ${item.id}:`, validation.blockingErrors); console.error(`❌ Blocking errors for item ${item.id}:`, validation.blockingErrors);

13
supabase/functions/process-selective-approval/validation.ts
View File

@@ -20,7 +20,8 @@ export interface StrictValidationResult {
*/ */
export function validateEntityDataStrict( export function validateEntityDataStrict(
entityType: string, entityType: string,
data: any data: any,
originalData?: any
): StrictValidationResult { ): StrictValidationResult {
const result: StrictValidationResult = { const result: StrictValidationResult = {
valid: true, valid: true,
@@ -78,7 +79,10 @@ export function validateEntityDataStrict(
if (!data.status) { if (!data.status) {
result.blockingErrors.push('Status is required'); result.blockingErrors.push('Status is required');
} }
if (data.location_id === null || data.location_id === undefined) { // For edits, check if location exists in either new or original data
const hasLocation = data.location_id !== null && data.location_id !== undefined;
const hadLocation = originalData?.location_id !== null && originalData?.location_id !== undefined;
if (!hasLocation && !hadLocation) {
result.blockingErrors.push('Location is required for parks'); result.blockingErrors.push('Location is required for parks');
} }
if (data.opening_date && data.closing_date) { if (data.opening_date && data.closing_date) {
@@ -97,7 +101,10 @@ export function validateEntityDataStrict(
if (!data.status) { if (!data.status) {
result.blockingErrors.push('Status is required'); result.blockingErrors.push('Status is required');
} }
if (data.park_id === null || data.park_id === undefined) { // For edits, check if park exists in either new or original data
const hasPark = data.park_id !== null && data.park_id !== undefined;
const hadPark = originalData?.park_id !== null && originalData?.park_id !== undefined;
if (!hasPark && !hadPark) {
result.blockingErrors.push('Park is required for rides'); result.blockingErrors.push('Park is required for rides');
} }
if (data.max_speed_kmh && (data.max_speed_kmh < 0 || data.max_speed_kmh > 300)) { if (data.max_speed_kmh && (data.max_speed_kmh < 0 || data.max_speed_kmh > 300)) {