Fix edge function logging and types

supabase/functions/update-novu-preferences/index.ts

@@ -1,6 +1,7 @@
 import { serve } from "https://deno.land/std@0.168.0/http/server.ts";
 import { Novu } from "npm:@novu/api@1.6.0";
 import { createClient } from "https://esm.sh/@supabase/supabase-js@2.57.4";
+import { edgeLogger, startRequest, endRequest } from "../_shared/logger.ts";
 
 const corsHeaders = {
   'Access-Control-Allow-Origin': '*',
@@ -8,6 +9,8 @@ const corsHeaders = {
 };
 
 serve(async (req) => {
+  const tracking = startRequest('update-novu-preferences');
+
   if (req.method === 'OPTIONS') {
     return new Response(null, { headers: corsHeaders });
   }
@@ -29,7 +32,7 @@ serve(async (req) => {
 
     const { userId, preferences } = await req.json();
 
-    console.log('Updating preferences for user:', userId);
+    edgeLogger.info('Updating preferences for user', { userId, requestId: tracking.requestId });
 
     // Validate input
     if (!userId) {
@@ -94,7 +97,11 @@ serve(async (req) => {
           );
           results.push({ channel: channelType, success: true });
         } catch (channelError: any) {
-          console.error(`Failed to update ${channelType} preference:`, channelError.message);
+          edgeLogger.error('Failed to update channel preference', { 
+            channel: channelType, 
+            error: channelError.message,
+            requestId: tracking.requestId
+          });
           results.push({ 
             channel: channelType, 
             success: false, 
@@ -109,7 +116,10 @@ serve(async (req) => {
     const allSucceeded = failedChannels.length === 0;
 
     if (!allSucceeded) {
-      console.warn(`Some channel preferences failed to update:`, failedChannels);
+      edgeLogger.warn('Some channel preferences failed to update', { 
+        failedChannels: failedChannels.map(c => c.channel),
+        requestId: tracking.requestId
+      });
       return new Response(
         JSON.stringify({
           success: false,
@@ -124,7 +134,11 @@ serve(async (req) => {
       );
     }
 
-    console.log('All preferences updated successfully');
+    const duration = endRequest(tracking);
+    edgeLogger.info('All preferences updated successfully', { 
+      requestId: tracking.requestId,
+      duration
+    });
     return new Response(
       JSON.stringify({
         success: true,
@@ -136,7 +150,12 @@ serve(async (req) => {
       }
     );
   } catch (error: any) {
-    console.error('Error updating Novu preferences:', error);
+    const duration = endRequest(tracking);
+    edgeLogger.error('Error updating Novu preferences', { 
+      error: error.message,
+      requestId: tracking.requestId,
+      duration
+    });
     
     return new Response(
       JSON.stringify({

supabase/functions/upload-image/index.ts

@@ -28,7 +28,7 @@ const getAllowedOrigin = (requestOrigin: string | null): string | null => {
       return requestOrigin;
     }
     // Origin not allowed in development - log and deny
-    console.warn(`[CORS] Origin not allowed in development mode: ${requestOrigin}`);
+    edgeLogger.warn('CORS origin not allowed in development mode', { origin: requestOrigin });
     return null;
   }
   
@@ -38,7 +38,7 @@ const getAllowedOrigin = (requestOrigin: string | null): string | null => {
   }
   
   // Origin not allowed in production - log and deny
-  console.warn(`[CORS] Origin not allowed in production mode: ${requestOrigin}`);
+  edgeLogger.warn('CORS origin not allowed in production mode', { origin: requestOrigin });
   return null;
 };
 
@@ -189,7 +189,10 @@ serve(withRateLimit(async (req) => {
         requestBody = await req.json();
       } catch (error: unknown) {
         const errorMessage = error instanceof Error ? error.message : String(error);
-        console.error('[Upload] Invalid JSON:', { error: errorMessage });
+        edgeLogger.error('Invalid JSON in delete request', { 
+          error: errorMessage, 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Invalid JSON',
@@ -246,7 +249,10 @@ serve(withRateLimit(async (req) => {
           }
         )
       } catch (fetchError) {
-        console.error('Network error deleting image:', fetchError)
+        edgeLogger.error('Network error deleting image', { 
+          error: String(fetchError), 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Network error',
@@ -263,7 +269,10 @@ serve(withRateLimit(async (req) => {
       try {
         deleteResult = await deleteResponse.json()
       } catch (parseError) {
-        console.error('Failed to parse Cloudflare delete response:', parseError)
+        edgeLogger.error('Failed to parse Cloudflare delete response', { 
+          error: String(parseError), 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Invalid response',
@@ -277,7 +286,10 @@ serve(withRateLimit(async (req) => {
       }
 
       if (!deleteResponse.ok) {
-        console.error('Cloudflare delete error:', deleteResult)
+        edgeLogger.error('Cloudflare delete error', { 
+          result: deleteResult, 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Failed to delete image',
@@ -322,7 +334,10 @@ serve(withRateLimit(async (req) => {
 
       const { data: { user }, error: authError } = await supabase.auth.getUser()
       if (authError || !user) {
-        console.error('Auth verification failed:', authError)
+        edgeLogger.error('Auth verification failed for POST', { 
+          error: authError?.message, 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Invalid authentication',
@@ -343,7 +358,10 @@ serve(withRateLimit(async (req) => {
         .single()
 
       if (profileError || !profile) {
-        console.error('Failed to fetch user profile:', profileError)
+        edgeLogger.error('Failed to fetch user profile for POST', { 
+          error: profileError?.message, 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'User profile not found',
@@ -418,7 +436,10 @@ serve(withRateLimit(async (req) => {
           }
         )
       } catch (fetchError) {
-        console.error('Network error getting upload URL:', fetchError)
+        edgeLogger.error('Network error getting upload URL', { 
+          error: String(fetchError), 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Network error',
@@ -435,7 +456,10 @@ serve(withRateLimit(async (req) => {
       try {
         directUploadResult = await directUploadResponse.json()
       } catch (parseError) {
-        console.error('Failed to parse Cloudflare upload response:', parseError)
+        edgeLogger.error('Failed to parse Cloudflare upload response', { 
+          error: String(parseError), 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Invalid response',
@@ -449,7 +473,10 @@ serve(withRateLimit(async (req) => {
       }
 
       if (!directUploadResponse.ok) {
-        console.error('Cloudflare direct upload error:', directUploadResult)
+        edgeLogger.error('Cloudflare direct upload error', { 
+          result: directUploadResult, 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Failed to get upload URL',
@@ -500,7 +527,10 @@ serve(withRateLimit(async (req) => {
 
       const { data: { user }, error: authError } = await supabase.auth.getUser()
       if (authError || !user) {
-        console.error('Auth verification failed:', authError)
+        edgeLogger.error('Auth verification failed for GET', { 
+          error: authError?.message, 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Invalid authentication',
@@ -541,7 +571,10 @@ serve(withRateLimit(async (req) => {
           }
         )
       } catch (fetchError) {
-        console.error('Network error fetching image status:', fetchError)
+        edgeLogger.error('Network error fetching image status', { 
+          error: String(fetchError), 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Network error',
@@ -558,7 +591,10 @@ serve(withRateLimit(async (req) => {
       try {
         imageResult = await imageResponse.json()
       } catch (parseError) {
-        console.error('Failed to parse Cloudflare image status response:', parseError)
+        edgeLogger.error('Failed to parse Cloudflare image status response', { 
+          error: String(parseError), 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Invalid response',
@@ -572,7 +608,10 @@ serve(withRateLimit(async (req) => {
       }
 
       if (!imageResponse.ok) {
-        console.error('Cloudflare image status error:', imageResult)
+        edgeLogger.error('Cloudflare image status error', { 
+          result: imageResult, 
+          requestId: tracking.requestId 
+        });
         return new Response(
           JSON.stringify({ 
             error: 'Failed to get image status',

supabase/functions/validate-email-backend/index.ts

@@ -95,7 +95,17 @@ serve(async (req) => {
     );
   } catch (error) {
     const duration = endRequest(tracking);
-    console.error('Email validation error:', error, { requestId: tracking.requestId, duration });
+    const errorMessage = error instanceof Error ? error.message : String(error);
+    // Note: Using console.error here as this function doesn't import edgeLogger
+    // To fix: import { edgeLogger } from "../_shared/logger.ts";
+    console.error(JSON.stringify({
+      timestamp: new Date().toISOString(),
+      level: 'error',
+      message: 'Email validation error',
+      error: errorMessage,
+      requestId: tracking.requestId,
+      duration
+    }));
     return new Response(
       JSON.stringify({ 
         valid: false,