Fix remaining compliance violations

This commit is contained in:
gpt-engineer-app[bot]
2025-11-03 18:47:59 +00:00
parent 6efb6dda66
commit 7663205512
9 changed files with 131 additions and 83 deletions

View File

@@ -1,5 +1,6 @@
import { serve } from "https://deno.land/std@0.190.0/http/server.ts";
import { Novu } from "npm:@novu/api@1.6.0";
import { edgeLogger } from '../_shared/logger.ts';
const corsHeaders = {
'Access-Control-Allow-Origin': '*',
@@ -189,7 +190,7 @@ serve(async (req) => {
}
}
console.log('Creating Novu subscriber:', { subscriberId, email, firstName });
edgeLogger.info('Creating Novu subscriber', { subscriberId, email: '***', firstName, requestId: tracking.requestId });
const subscriber = await novu.subscribers.identify(subscriberId, {
email,
@@ -201,18 +202,26 @@ serve(async (req) => {
});
const duration = endRequest(tracking);
console.log('Subscriber created successfully:', subscriber.data, { requestId: tracking.requestId, duration });
edgeLogger.info('Subscriber created successfully', {
subscriberId: subscriber.data._id,
requestId: tracking.requestId,
duration
});
// Add subscriber to "users" topic for global announcements
try {
console.log('Adding subscriber to "users" topic...', { subscriberId });
edgeLogger.info('Adding subscriber to users topic', { subscriberId, requestId: tracking.requestId });
await novu.topics.addSubscribers('users', {
subscribers: [subscriberId],
});
console.log('Successfully added subscriber to "users" topic', { subscriberId });
} catch (topicError: any) {
edgeLogger.info('Successfully added subscriber to users topic', { subscriberId, requestId: tracking.requestId });
} catch (topicError: unknown) {
// Non-blocking - log error but don't fail the request
console.error('Failed to add subscriber to "users" topic:', topicError.message, { subscriberId });
edgeLogger.error('Failed to add subscriber to users topic', {
error: topicError instanceof Error ? topicError.message : String(topicError),
subscriberId,
requestId: tracking.requestId
});
}
return new Response(
@@ -226,9 +235,13 @@ serve(async (req) => {
status: 200,
}
);
} catch (error: any) {
} catch (error: unknown) {
const duration = endRequest(tracking);
console.error('Error creating Novu subscriber:', error, { requestId: tracking.requestId, duration });
edgeLogger.error('Error creating Novu subscriber', {
error: error instanceof Error ? error.message : String(error),
requestId: tracking.requestId,
duration
});
return new Response(
JSON.stringify({