Refactor: Improve validation schemas

src/components/settings/PasswordUpdateDialog.tsx

@@ -1,7 +1,6 @@
 import { useState, useEffect } from 'react';
 import { useForm } from 'react-hook-form';
 import { zodResolver } from '@hookform/resolvers/zod';
-import { z } from 'zod';
 import {
   Dialog,
   DialogContent,
@@ -19,15 +18,9 @@ import { Loader2, Shield, CheckCircle2 } from 'lucide-react';
 import { InputOTP, InputOTPGroup, InputOTPSlot } from '@/components/ui/input-otp';
 import { TurnstileCaptcha } from '@/components/auth/TurnstileCaptcha';
 import { useTheme } from '@/components/theme/ThemeProvider';
+import { passwordSchema } from '@/lib/validation';
 
-const passwordSchema = z.object({
-  currentPassword: z.string().min(1, 'Current password is required'),
-  newPassword: z.string().min(8, 'Password must be at least 8 characters'),
-  confirmPassword: z.string()
-}).refine(data => data.newPassword === data.confirmPassword, {
-  message: "Passwords don't match",
-  path: ["confirmPassword"]
-});
+import { z } from 'zod';
 
 type PasswordFormData = z.infer<typeof passwordSchema>;
 
@@ -124,11 +117,20 @@ export function PasswordUpdateDialog({ open, onOpenChange, onSuccess }: Password
         await updatePasswordWithNonce(data.newPassword, generatedNonce);
       }
     } catch (error: any) {
-      toast({
-        title: 'Authentication Error',
-        description: error.message || 'Incorrect password. Please try again.',
-        variant: 'destructive'
-      });
+      // Handle rate limiting specifically
+      if (error.message?.includes('rate limit') || error.status === 429) {
+        toast({
+          title: 'Too Many Attempts',
+          description: 'Please wait a few minutes before trying again.',
+          variant: 'destructive'
+        });
+      } else {
+        toast({
+          title: 'Authentication Error',
+          description: error.message || 'Incorrect password. Please try again.',
+          variant: 'destructive'
+        });
+      }
     } finally {
       setLoading(false);
     }
@@ -280,6 +282,9 @@ export function PasswordUpdateDialog({ open, onOpenChange, onSuccess }: Password
                   placeholder="Enter your new password"
                   disabled={loading}
                 />
+                <p className="text-xs text-muted-foreground">
+                  Must be 8+ characters with uppercase, lowercase, number, and special character
+                </p>
                 {form.formState.errors.newPassword && (
                   <p className="text-sm text-destructive">
                     {form.formState.errors.newPassword.message}
@@ -348,6 +353,7 @@ export function PasswordUpdateDialog({ open, onOpenChange, onSuccess }: Password
                   value={totpCode}
                   onChange={setTotpCode}
                   disabled={loading}
+                  onPaste={(e) => e.preventDefault()}
                 >
                   <InputOTPGroup>
                     <InputOTPSlot index={0} />