From 7f273a20826a3fc8905d5f35a2704da6c44a91d3 Mon Sep 17 00:00:00 2001
From: "gpt-engineer-app[bot]"
 <159125892+gpt-engineer-app[bot]@users.noreply.github.com>
Date: Wed, 15 Oct 2025 19:55:26 +0000
Subject: [PATCH] Refactor: Rename timeline event to milestone

---
 src/lib/entitySubmissionHelpers.ts            |  4 +-
 .../process-selective-approval/index.ts       |  3 +-
 ...1_c71e7003-6b30-4e1e-84de-7f4afec701bc.sql | 45 +++++++++++++++++++
 3 files changed, 49 insertions(+), 3 deletions(-)
 create mode 100644 supabase/migrations/20251015195451_c71e7003-6b30-4e1e-84de-7f4afec701bc.sql

diff --git a/src/lib/entitySubmissionHelpers.ts b/src/lib/entitySubmissionHelpers.ts
index cd5bda8a..21e058a2 100644
--- a/src/lib/entitySubmissionHelpers.ts
+++ b/src/lib/entitySubmissionHelpers.ts
@@ -940,7 +940,7 @@ export async function submitTimelineEvent(
     .from('content_submissions')
     .insert({
       user_id: userId,
-      submission_type: 'timeline_event',
+      submission_type: 'milestone',
       content,
       status: 'pending',
       approval_mode: 'full',
@@ -1030,7 +1030,7 @@ export async function submitTimelineEventUpdate(
     .from('content_submissions')
     .insert({
       user_id: userId,
-      submission_type: 'timeline_event',
+      submission_type: 'milestone',
       content,
       status: 'pending',
       approval_mode: 'full',
diff --git a/supabase/functions/process-selective-approval/index.ts b/supabase/functions/process-selective-approval/index.ts
index 8e8735f8..6e075bca 100644
--- a/supabase/functions/process-selective-approval/index.ts
+++ b/supabase/functions/process-selective-approval/index.ts
@@ -290,7 +290,8 @@ serve(async (req) => {
             await deletePhoto(supabase, resolvedData);
             entityId = resolvedData.photo_id;
             break;
-          case 'timeline_event':
+          case 'milestone':
+          case 'timeline_event': // Keep for backward compatibility
             entityId = await createTimelineEvent(supabase, resolvedData, submitterId, authenticatedUserId, submissionId);
             break;
           default:
diff --git a/supabase/migrations/20251015195451_c71e7003-6b30-4e1e-84de-7f4afec701bc.sql b/supabase/migrations/20251015195451_c71e7003-6b30-4e1e-84de-7f4afec701bc.sql
new file mode 100644
index 00000000..10b591e4
--- /dev/null
+++ b/supabase/migrations/20251015195451_c71e7003-6b30-4e1e-84de-7f4afec701bc.sql
@@ -0,0 +1,45 @@
+-- Fix entity_timeline_events event_type constraint to include 'opening'
+ALTER TABLE public.entity_timeline_events 
+DROP CONSTRAINT IF EXISTS entity_timeline_events_event_type_check;
+
+ALTER TABLE public.entity_timeline_events 
+ADD CONSTRAINT entity_timeline_events_event_type_check 
+CHECK (event_type IN (
+  'name_change',
+  'operator_change', 
+  'owner_change',
+  'location_change',
+  'status_change',
+  'opening',
+  'closure',
+  'reopening',
+  'renovation',
+  'expansion',
+  'acquisition',
+  'milestone',
+  'other'
+));
+
+-- Add 'milestone' to content_submissions submission_type constraint
+ALTER TABLE public.content_submissions 
+DROP CONSTRAINT IF EXISTS content_submissions_submission_type_check;
+
+ALTER TABLE public.content_submissions 
+ADD CONSTRAINT content_submissions_submission_type_check 
+CHECK (submission_type IN (
+  'park', 
+  'ride', 
+  'review', 
+  'photo', 
+  'manufacturer', 
+  'operator', 
+  'designer', 
+  'property_owner',
+  'photo_edit',
+  'photo_delete',
+  'ride_model',
+  'milestone'
+));
+
+COMMENT ON CONSTRAINT content_submissions_submission_type_check ON public.content_submissions IS 
+'milestone submissions are for entity timeline/historical events';
\ No newline at end of file