Refactor: Implement full error logging

src/components/settings/PrivacyTab.tsx

@@ -8,7 +8,6 @@ import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@
 import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';
 import { Separator } from '@/components/ui/separator';
 import { handleError, handleSuccess, AppError } from '@/lib/errorHandler';
-import { logger } from '@/lib/logger';
 import { useAuth } from '@/hooks/useAuth';
 import { useProfile } from '@/hooks/useProfile';
 import { supabase } from '@/lib/supabaseClient';
@@ -50,12 +49,6 @@ export function PrivacyTab() {
         .maybeSingle();
       
       if (error && error.code !== 'PGRST116') {
-        logger.error('Failed to fetch privacy preferences', {
-          userId: user.id,
-          action: 'fetch_privacy_preferences',
-          error: error.message,
-          errorCode: error.code
-        });
         throw error;
       }
       
@@ -72,19 +65,12 @@ export function PrivacyTab() {
             ...parseResult.data
           });
         } else {
-          logger.warn('Invalid privacy settings, reinitializing with defaults');
           await initializePreferences();
         }
       } else {
         await initializePreferences();
       }
     } catch (error: unknown) {
-      logger.error('Error fetching privacy preferences', {
-        userId: user.id,
-        action: 'fetch_privacy_preferences',
-        error: error instanceof Error ? error.message : String(error)
-      });
-      
       handleError(error, {
         action: 'Load privacy settings',
         userId: user.id
@@ -104,11 +90,6 @@ export function PrivacyTab() {
         }]);
       
       if (error) {
-        logger.error('Failed to initialize privacy preferences', {
-          userId: user.id,
-          action: 'initialize_privacy_preferences',
-          error: error.message
-        });
         throw error;
       }
       
@@ -121,12 +102,6 @@ export function PrivacyTab() {
       ...DEFAULT_PRIVACY_SETTINGS
     });
     } catch (error: unknown) {
-      logger.error('Error initializing privacy preferences', {
-        userId: user.id,
-        action: 'initialize_privacy_preferences',
-        error: error instanceof Error ? error.message : String(error)
-      });
-      
       handleError(error, {
         action: 'Initialize privacy settings',
         userId: user.id
@@ -154,12 +129,6 @@ export function PrivacyTab() {
         .eq('user_id', user.id);
       
       if (profileError) {
-        logger.error('Failed to update profile privacy', {
-          userId: user.id,
-          action: 'update_profile_privacy',
-          error: profileError.message,
-          errorCode: profileError.code
-        });
         throw profileError;
       }
       
@@ -176,12 +145,6 @@ export function PrivacyTab() {
         }]);
       
       if (prefsError) {
-        logger.error('Failed to update privacy preferences', {
-          userId: user.id,
-          action: 'update_privacy_preferences',
-          error: prefsError.message,
-          errorCode: prefsError.code
-        });
         throw prefsError;
       }
       
@@ -200,22 +163,11 @@ export function PrivacyTab() {
       await refreshProfile();
       setPreferences(privacySettings);
       
-      logger.info('Privacy settings updated successfully', {
-        userId: user.id,
-        action: 'update_privacy_settings'
-      });
-      
       handleSuccess(
         'Privacy settings updated',
         'Your privacy preferences have been successfully saved.'
       );
     } catch (error: unknown) {
-      logger.error('Failed to update privacy settings', {
-        userId: user.id,
-        action: 'update_privacy_settings',
-        error: error instanceof Error ? error.message : String(error)
-      });
-      
     if (error instanceof z.ZodError) {
       handleError(
         new AppError(

src/components/settings/SecurityTab.tsx

@@ -24,7 +24,6 @@ import {
 import type { UserIdentity, OAuthProvider } from '@/types/identity';
 import type { AuthSession } from '@/types/auth';
 import { supabase } from '@/lib/supabaseClient';
-import { logger } from '@/lib/logger';
 import { SessionRevokeConfirmDialog } from './SessionRevokeConfirmDialog';
 
 export function SecurityTab() {
@@ -57,11 +56,6 @@ export function SecurityTab() {
       const hasEmailProvider = fetchedIdentities.some(i => i.provider === 'email');
       setHasPassword(hasEmailProvider);
     } catch (error: unknown) {
-      logger.error('Failed to load identities', {
-        userId: user?.id,
-        action: 'load_identities',
-        error: error instanceof Error ? error.message : String(error)
-      });
       handleError(error, { action: 'Load connected accounts', userId: user?.id });
     } finally {
       setLoadingIdentities(false);
@@ -159,11 +153,6 @@ export function SecurityTab() {
       
       setSessions((data as AuthSession[]) || []);
     } catch (error: unknown) {
-      logger.error('Failed to fetch sessions', {
-        userId: user.id,
-        action: 'fetch_sessions',
-        error: error instanceof Error ? error.message : String(error)
-      });
       handleError(error, {
         action: 'Load active sessions',
         userId: user.id
@@ -190,12 +179,6 @@ export function SecurityTab() {
     const { error } = await supabase.rpc('revoke_my_session', { session_id: sessionToRevoke.id });
     
     if (error) {
-      logger.error('Failed to revoke session', {
-        userId: user?.id,
-        action: 'revoke_session',
-        sessionId: sessionToRevoke.id,
-        error: error.message
-      });
       handleError(error, { action: 'Revoke session', userId: user?.id });
     } else {
       handleSuccess('Success', 'Session revoked successfully');