Implement Phase 3C error logging

This commit is contained in:
gpt-engineer-app[bot]
2025-11-04 19:39:55 +00:00
parent 162d288cb0
commit a9334c7a3a
13 changed files with 179 additions and 210 deletions

View File

@@ -14,7 +14,7 @@ import type {
} from '@/types/auth';
import { setStepUpRequired, setAuthMethod, clearAllAuthFlags } from './sessionFlags';
import { logger } from './logger';
import { getErrorMessage } from './errorHandler';
import { getErrorMessage, handleNonCriticalError } from './errorHandler';
/**
* Extract AAL level from session using Supabase API
@@ -37,9 +37,8 @@ export async function getSessionAal(session: Session | null): Promise<AALLevel>
});
if (error) {
logger.error('[AuthService] Error getting AAL', {
action: 'get_session_aal',
error: error.message
handleNonCriticalError(error, {
action: 'Get session AAL',
});
return 'aal1';
}
@@ -48,10 +47,8 @@ export async function getSessionAal(session: Session | null): Promise<AALLevel>
logger.log('[AuthService] Returning AAL', { level });
return level;
} catch (error: unknown) {
const errorMessage = getErrorMessage(error);
logger.error('[AuthService] Exception getting AAL', {
action: 'get_session_aal',
error: errorMessage
handleNonCriticalError(error, {
action: 'Get session AAL exception',
});
return 'aal1';
}
@@ -65,9 +62,8 @@ export async function getEnrolledFactors(): Promise<MFAFactor[]> {
const { data, error } = await supabase.auth.mfa.listFactors();
if (error) {
logger.error('[AuthService] Error listing factors', {
action: 'get_enrolled_factors',
error: error.message
handleNonCriticalError(error, {
action: 'List MFA factors',
});
return [];
}
@@ -83,10 +79,8 @@ export async function getEnrolledFactors(): Promise<MFAFactor[]> {
updated_at: f.updated_at,
}));
} catch (error: unknown) {
const errorMessage = getErrorMessage(error);
logger.error('[AuthService] Exception listing factors', {
action: 'get_enrolled_factors',
error: errorMessage
handleNonCriticalError(error, {
action: 'List MFA factors exception',
});
return [];
}
@@ -135,21 +129,18 @@ export async function verifyMfaRequired(userId: string): Promise<boolean> {
.in('role', ['admin', 'moderator']);
if (error) {
logger.error('[AuthService] Error checking roles', {
action: 'verify_mfa_required',
handleNonCriticalError(error, {
action: 'Verify MFA required',
userId,
error: error.message
});
return false;
}
return (data?.length || 0) > 0;
} catch (error: unknown) {
const errorMessage = getErrorMessage(error);
logger.error('[AuthService] Exception checking roles', {
action: 'verify_mfa_required',
handleNonCriticalError(error, {
action: 'Verify MFA required exception',
userId,
error: errorMessage
});
return false;
}
@@ -207,15 +198,13 @@ export async function handlePostAuthFlow(
},
};
} catch (error: unknown) {
const errorMessage = getErrorMessage(error);
logger.error('[AuthService] Error in post-auth flow', {
action: 'handle_post_auth_flow',
authMethod,
error: errorMessage
handleNonCriticalError(error, {
action: 'Handle post-auth flow',
metadata: { authMethod },
});
return {
success: false,
error: errorMessage,
error: getErrorMessage(error),
};
}
}
@@ -234,10 +223,9 @@ export async function verifyMfaUpgrade(session: Session | null): Promise<MFAChal
const currentAal = await getSessionAal(session);
if (currentAal !== 'aal2') {
logger.error('[AuthService] MFA verification failed', {
action: 'verify_mfa_upgrade',
expectedAal: 'aal2',
actualAal: currentAal
handleNonCriticalError(new Error('MFA verification failed'), {
action: 'Verify MFA upgrade',
metadata: { expectedAal: 'aal2', actualAal: currentAal },
});
await logAuthEvent(session.user.id, 'mfa_verification_failed', {
expected_aal: 'aal2',
@@ -282,20 +270,15 @@ async function logAuthEvent(
});
if (error) {
logger.error('[AuthService] Error logging auth event', {
action: 'log_auth_event',
eventAction: action,
userId,
error: error.message
handleNonCriticalError(error, {
action: 'Log auth event',
metadata: { eventAction: action, userId },
});
}
} catch (error: unknown) {
const errorMessage = getErrorMessage(error);
logger.error('[AuthService] Exception logging auth event', {
action: 'log_auth_event',
eventAction: action,
userId,
error: errorMessage
handleNonCriticalError(error, {
action: 'Log auth event exception',
metadata: { eventAction: action, userId },
});
}
}