Refactor: Implement Phase 2 improvements

This commit is contained in:
gpt-engineer-app[bot]
2025-10-15 12:06:51 +00:00
parent 0434aa95ee
commit cdd6b0bbd5
6 changed files with 107 additions and 89 deletions

View File

@@ -85,6 +85,9 @@ export interface ModerationFilters {
/** Reset sort to default */
resetSort: () => void;
/** Reset pagination to page 1 (callback) */
onFilterChange?: () => void;
}
/**
@@ -106,7 +109,9 @@ export interface ModerationFilters {
* </Select>
* ```
*/
export function useModerationFilters(config: ModerationFiltersConfig = {}): ModerationFilters {
export function useModerationFilters(
config: ModerationFiltersConfig & { onFilterChange?: () => void } = {}
): ModerationFilters {
const {
initialEntityFilter = 'all',
initialStatusFilter = 'pending',
@@ -115,6 +120,7 @@ export function useModerationFilters(config: ModerationFiltersConfig = {}): Mode
persist = true,
storageKey = 'moderationQueue_filters',
initialSortConfig = { field: 'created_at', direction: 'asc' },
onFilterChange,
} = config;
// Load persisted filters on mount
@@ -204,23 +210,26 @@ export function useModerationFilters(config: ModerationFiltersConfig = {}): Mode
}
}, [sortConfig, persist, storageKey]);
// Set entity filter with logging
// Set entity filter with logging and pagination reset
const setEntityFilter = useCallback((filter: EntityFilter) => {
logger.log('🔍 Entity filter changed:', filter);
setEntityFilterState(filter);
}, []);
onFilterChange?.();
}, [onFilterChange]);
// Set status filter with logging
// Set status filter with logging and pagination reset
const setStatusFilter = useCallback((filter: StatusFilter) => {
logger.log('🔍 Status filter changed:', filter);
setStatusFilterState(filter);
}, []);
onFilterChange?.();
}, [onFilterChange]);
// Set active tab with logging
// Set active tab with logging and pagination reset
const setActiveTab = useCallback((tab: QueueTab) => {
logger.log('🔍 Tab changed:', tab);
setActiveTabState(tab);
}, []);
onFilterChange?.();
}, [onFilterChange]);
// Sort callbacks
const setSortConfig = useCallback((config: SortConfig) => {
@@ -283,5 +292,6 @@ export function useModerationFilters(config: ModerationFiltersConfig = {}): Mode
sortBy,
toggleSortDirection,
resetSort,
onFilterChange,
};
}

View File

@@ -0,0 +1,71 @@
import { useEffect } from 'react';
import { useNavigate } from 'react-router-dom';
import { useAuth } from './useAuth';
import { useUserRole } from './useUserRole';
import { useRequireMFA } from './useRequireMFA';
export interface AdminGuardState {
/** Whether auth/role/MFA checks are still loading */
isLoading: boolean;
/** Whether user is authenticated and authorized */
isAuthorized: boolean;
/** Whether user needs to enroll in MFA */
needsMFA: boolean;
/** Current authenticated user */
user: any;
}
/**
* Consolidated admin guard hook for all admin pages
*
* Handles:
* - Authentication check (redirects to /auth)
* - Role authorization check (redirects to /)
* - MFA enrollment check
* - Loading states
*
* @param requireMFA - Whether to enforce MFA requirement (default: true)
* @returns AdminGuardState with loading, authorization, and MFA status
*
* @example
* ```tsx
* const { isLoading, isAuthorized, needsMFA } = useAdminGuard();
*
* if (isLoading) return <LoadingSkeleton />;
* if (!isAuthorized) return null;
* if (needsMFA) return <MFARequiredAlert />;
*
* return <AdminContent />;
* ```
*/
export function useAdminGuard(requireMFA: boolean = true): AdminGuardState {
const { user, loading: authLoading } = useAuth();
const { isModerator, loading: roleLoading } = useUserRole();
const { needsEnrollment, loading: mfaLoading } = useRequireMFA();
const navigate = useNavigate();
// Auto-redirect based on auth state
useEffect(() => {
if (!authLoading && !roleLoading) {
if (!user) {
navigate('/auth');
} else if (!isModerator()) {
navigate('/');
}
}
}, [user, authLoading, roleLoading, navigate, isModerator]);
const isLoading = authLoading || roleLoading || mfaLoading;
const isAuthorized = !!user && isModerator();
const needsMFA = requireMFA && needsEnrollment;
return {
isLoading,
isAuthorized,
needsMFA,
user,
};
}