feat: Implement comprehensive validation error handling

src/hooks/moderation/useModerationActions.ts

@@ -171,42 +171,93 @@ export function useModerationActions(config: ModerationActionsConfig): Moderatio
               });
               
               // Run validation on all items
-              const validationResults = await validateMultipleItems(itemsWithData);
-              
-              // Check for blocking errors
-              const itemsWithBlockingErrors = itemsWithData.filter(item => {
-                const result = validationResults.get(item.id);
-                return result && result.blockingErrors.length > 0;
-              });
-              
-              // CRITICAL: Block approval if any item has blocking errors
-              if (itemsWithBlockingErrors.length > 0) {
-                const errorDetails = itemsWithBlockingErrors.map(item => {
+              try {
+                const validationResults = await validateMultipleItems(itemsWithData);
+                
+                // Check for blocking errors
+                const itemsWithBlockingErrors = itemsWithData.filter(item => {
                   const result = validationResults.get(item.id);
-                  return `${item.item_type}: ${result?.blockingErrors[0]?.message || 'Unknown error'}`;
-                }).join(', ');
-                
-                toast({
-                  title: 'Cannot Approve - Validation Errors',
-                  description: `${itemsWithBlockingErrors.length} item(s) have blocking errors that must be fixed first. ${errorDetails}`,
-                  variant: 'destructive',
+                  return result && result.blockingErrors.length > 0;
                 });
                 
-                // Return early - do NOT proceed with approval
-                return;
-              }
-              
-              // Check for warnings (optional - can proceed but inform user)
-              const itemsWithWarnings = itemsWithData.filter(item => {
-                const result = validationResults.get(item.id);
-                return result && result.warnings.length > 0;
-              });
-              
-              if (itemsWithWarnings.length > 0) {
-                logger.info('Approval proceeding with warnings', {
-                  submissionId: item.id,
-                  warningCount: itemsWithWarnings.length
+                // CRITICAL: Block approval if any item has blocking errors
+                if (itemsWithBlockingErrors.length > 0) {
+                  // Log detailed blocking errors
+                  itemsWithBlockingErrors.forEach(item => {
+                    const result = validationResults.get(item.id);
+                    logger.error('Validation blocking approval', {
+                      submissionId: item.id,
+                      itemId: item.id,
+                      itemType: item.item_type,
+                      blockingErrors: result?.blockingErrors
+                    });
+                  });
+                  
+                  const errorDetails = itemsWithBlockingErrors.map(item => {
+                    const result = validationResults.get(item.id);
+                    const itemName = (item.item_data as any)?.name || item.item_type;
+                    const errors = result?.blockingErrors.map(e => `${e.field}: ${e.message}`).join(', ');
+                    return `${itemName} - ${errors}`;
+                  }).join('; ');
+                  
+                  throw new Error(`Validation failed: ${errorDetails}`);
+                }
+                
+                // Check for warnings (optional - can proceed but inform user)
+                const itemsWithWarnings = itemsWithData.filter(item => {
+                  const result = validationResults.get(item.id);
+                  return result && result.warnings.length > 0;
                 });
+                
+                if (itemsWithWarnings.length > 0) {
+                  logger.info('Approval proceeding with warnings', {
+                    submissionId: item.id,
+                    warningCount: itemsWithWarnings.length
+                  });
+                }
+              } catch (error) {
+                // Check if this is a validation error or system error
+                if (getErrorMessage(error).includes('Validation failed:')) {
+                  // This is expected - validation rules preventing approval
+                  handleError(error, {
+                    action: 'Validation Blocked Approval',
+                    userId: user?.id,
+                    metadata: {
+                      submissionId: item.id,
+                      submissionType: item.submission_type,
+                      selectedItemCount: itemsWithData.length
+                    }
+                  });
+                  
+                  toast({
+                    title: 'Cannot Approve - Validation Errors',
+                    description: getErrorMessage(error),
+                    variant: 'destructive',
+                  });
+                  
+                  // Return early - do NOT proceed with approval
+                  return;
+                } else {
+                  // Unexpected validation system error
+                  const errorId = handleError(error, {
+                    action: 'Validation System Failure',
+                    userId: user?.id,
+                    metadata: {
+                      submissionId: item.id,
+                      submissionType: item.submission_type,
+                      phase: 'validation'
+                    }
+                  });
+                  
+                  toast({
+                    title: 'Validation System Error',
+                    description: `Unable to validate submission (ref: ${errorId.slice(0, 8)})`,
+                    variant: 'destructive',
+                  });
+                  
+                  // Return early - do NOT proceed with approval
+                  return;
+                }
               }
             }