From dc21e2a6aa4db96bc86ba1f5ab63ce59fefac2e8 Mon Sep 17 00:00:00 2001
From: "gpt-engineer-app[bot]"
 <159125892+gpt-engineer-app[bot]@users.noreply.github.com>
Date: Mon, 13 Oct 2025 20:22:34 +0000
Subject: [PATCH] Fix: Prevent approval with blocking errors

---
 src/components/moderation/ItemReviewCard.tsx  |  9 ++++-
 .../moderation/SubmissionReviewManager.tsx    | 40 ++++++++++++++++++-
 .../moderation/ValidationBlockerDialog.tsx    |  3 +-
 3 files changed, 49 insertions(+), 3 deletions(-)

diff --git a/src/components/moderation/ItemReviewCard.tsx b/src/components/moderation/ItemReviewCard.tsx
index a1f5696c..eac7e76c 100644
--- a/src/components/moderation/ItemReviewCard.tsx
+++ b/src/components/moderation/ItemReviewCard.tsx
@@ -74,8 +74,10 @@ export function ItemReviewCard({ item, onEdit, onStatusChange, submissionId }: I
     );
   };
 
+  const hasBlockingErrors = validationResult && validationResult.blockingErrors.length > 0;
+
   return (
-    <Card className="w-full">
+    <Card className={`w-full ${hasBlockingErrors ? 'border-destructive border-2' : ''}`}>
       <CardHeader className={isMobile ? "pb-3 p-4" : "pb-3"}>
         <div className={`flex gap-2 ${isMobile ? 'flex-col' : 'items-start justify-between'}`}>
           <div className="flex items-center gap-2 flex-wrap">
@@ -89,6 +91,11 @@ export function ItemReviewCard({ item, onEdit, onStatusChange, submissionId }: I
                 Moderator Edited
               </Badge>
             )}
+            {hasBlockingErrors && (
+              <Badge variant="destructive" className="text-xs">
+                Blocked
+              </Badge>
+            )}
           </div>
           <div className="flex items-center gap-2">
             <Badge variant={getStatusColor()} className={isMobile ? "text-xs" : ""}>
diff --git a/src/components/moderation/SubmissionReviewManager.tsx b/src/components/moderation/SubmissionReviewManager.tsx
index 43cc7800..87bb3b69 100644
--- a/src/components/moderation/SubmissionReviewManager.tsx
+++ b/src/components/moderation/SubmissionReviewManager.tsx
@@ -60,6 +60,7 @@ export function SubmissionReviewManager({
   const [showWarningConfirmDialog, setShowWarningConfirmDialog] = useState(false);
   const [validationResults, setValidationResults] = useState<Map<string, ValidationResult>>(new Map());
   const [userConfirmedWarnings, setUserConfirmedWarnings] = useState(false);
+  const [hasBlockingErrors, setHasBlockingErrors] = useState(false);
   
   const { toast } = useToast();
   const { isAdmin, isSuperuser } = useUserRole();
@@ -117,6 +118,9 @@ export function SubmissionReviewManager({
       } else {
         next.add(itemId);
       }
+      // Clear blocking errors when selection changes
+      setHasBlockingErrors(false);
+      setValidationResults(new Map());
       return next;
     });
   };
@@ -176,6 +180,7 @@ export function SubmissionReviewManager({
       });
       
       if (itemsWithBlockingErrors.length > 0 && !userConfirmedWarnings) {
+        setHasBlockingErrors(true);
         setShowValidationBlockerDialog(true);
         setLoading(false);
         return; // Block approval
@@ -475,6 +480,29 @@ export function SubmissionReviewManager({
         onOpenChange={setShowEditDialog}
         onComplete={handleEditComplete}
       />
+
+      <ValidationBlockerDialog
+        open={showValidationBlockerDialog}
+        onClose={() => setShowValidationBlockerDialog(false)}
+        blockingErrors={Array.from(validationResults.values()).flatMap(r => r.blockingErrors)}
+        itemNames={items.filter(i => selectedItemIds.has(i.id)).map(i => 
+          i.item_data?.name || i.item_type.replace('_', ' ')
+        )}
+      />
+
+      <WarningConfirmDialog
+        open={showWarningConfirmDialog}
+        onClose={() => setShowWarningConfirmDialog(false)}
+        onProceed={() => {
+          setUserConfirmedWarnings(true);
+          setShowWarningConfirmDialog(false);
+          handleApprove();
+        }}
+        warnings={Array.from(validationResults.values()).flatMap(r => r.warnings)}
+        itemNames={items.filter(i => selectedItemIds.has(i.id)).map(i => 
+          i.item_data?.name || i.item_type.replace('_', ' ')
+        )}
+      />
     </>
   );
 
@@ -532,11 +560,21 @@ export function SubmissionReviewManager({
           </TabsContent>
         </Tabs>
 
+        {/* Blocking error alert */}
+        {hasBlockingErrors && (
+          <Alert variant="destructive">
+            <AlertCircle className="w-4 h-4" />
+            <AlertDescription>
+              Cannot approve: Selected items have validation errors that must be fixed first.
+            </AlertDescription>
+          </Alert>
+        )}
+
         {/* Action buttons */}
         <div className="flex flex-col sm:flex-row gap-2 pt-4 border-t">
           <Button
             onClick={handleCheckConflicts}
-            disabled={selectedCount === 0 || loading}
+            disabled={selectedCount === 0 || loading || hasBlockingErrors}
             className="flex-1"
           >
             <CheckCircle2 className="w-4 h-4 mr-2" />
diff --git a/src/components/moderation/ValidationBlockerDialog.tsx b/src/components/moderation/ValidationBlockerDialog.tsx
index b9b04519..7896732a 100644
--- a/src/components/moderation/ValidationBlockerDialog.tsx
+++ b/src/components/moderation/ValidationBlockerDialog.tsx
@@ -33,7 +33,8 @@ export function ValidationBlockerDialog({
             Cannot Approve: Validation Errors
           </AlertDialogTitle>
           <AlertDialogDescription>
-            The following items have blocking validation errors that must be fixed before approval:
+            The following items have blocking validation errors that MUST be fixed before approval.
+            These items cannot be approved until the errors are resolved. Please edit or reject them.
           </AlertDialogDescription>
         </AlertDialogHeader>