Refactor: Implement state machine cleanup and fixes

This commit is contained in:
gpt-engineer-app[bot]
2025-10-21 14:10:24 +00:00
parent 14b3305755
commit dcdb20386a
9 changed files with 55 additions and 209 deletions

View File

@@ -1,10 +1,9 @@
import { useState, useEffect, useReducer } from 'react';
import { useState, useEffect } from 'react';
import { useForm } from 'react-hook-form';
import { zodResolver } from '@hookform/resolvers/zod';
import * as z from 'zod';
import { entitySchemas } from '@/lib/entityValidationSchemas';
import { validateSubmissionHandler } from '@/lib/entityFormValidation';
import { submissionReducer, canSubmit } from '@/lib/submissionStateMachine';
import { getErrorMessage } from '@/lib/errorHandler';
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card';
import { Button } from '@/components/ui/button';
@@ -131,10 +130,6 @@ const STATUS_DB_TO_DISPLAY: Record<string, string> = {
export function ParkForm({ onSubmit, onCancel, initialData, isEditing = false }: ParkFormProps) {
const { isModerator } = useUserRole();
const [submissionState, dispatch] = useReducer(submissionReducer, {
status: 'draft' as const,
data: initialData || {}
});
// Validate that onSubmit uses submission helpers (dev mode only)
useEffect(() => {
@@ -184,18 +179,7 @@ export function ParkForm({ onSubmit, onCancel, initialData, isEditing = false }:
});
const handleFormSubmit = async (data: ParkFormData) => {
if (!canSubmit(submissionState)) {
toast({
title: 'Cannot submit',
description: 'Please wait for the current operation to complete',
variant: 'destructive',
});
return;
}
dispatch({ type: 'VALIDATE', payload: data });
const handleFormSubmit = async (data: ParkFormData) => {
try {
dispatch({ type: 'SUBMIT', payload: { submissionId: crypto.randomUUID() } });
@@ -535,12 +519,11 @@ export function ParkForm({ onSubmit, onCancel, initialData, isEditing = false }:
{/* Form Actions */}
<div className="flex gap-4 pt-6">
<Button
type="submit"
disabled={submissionState.status === 'validating' || submissionState.status === 'submitting' || !canSubmit(submissionState)}
type="submit"
className="flex-1"
>
<Save className="w-4 h-4 mr-2" />
{(submissionState.status === 'validating' || submissionState.status === 'submitting') ? 'Saving...' : (isEditing ? 'Update Park' : 'Create Park')}
{isEditing ? 'Update Park' : 'Create Park'}
</Button>
{onCancel && (