From e881778659670740d0bfe536f41fdeb9436cfd15 Mon Sep 17 00:00:00 2001
From: "gpt-engineer-app[bot]"
 <159125892+gpt-engineer-app[bot]@users.noreply.github.com>
Date: Thu, 16 Oct 2025 15:48:18 +0000
Subject: [PATCH] feat: Implement sidebar layout for filters

---
 src/components/profile/RideCreditFilters.tsx  |  33 ++-
 src/components/profile/RideCreditsManager.tsx | 277 ++++++++++--------
 2 files changed, 174 insertions(+), 136 deletions(-)

diff --git a/src/components/profile/RideCreditFilters.tsx b/src/components/profile/RideCreditFilters.tsx
index 1db2c4c2..e522fe4a 100644
--- a/src/components/profile/RideCreditFilters.tsx
+++ b/src/components/profile/RideCreditFilters.tsx
@@ -18,6 +18,7 @@ interface RideCreditFiltersProps {
   activeFilterCount: number;
   resultCount: number;
   totalCount: number;
+  compact?: boolean;
 }
 
 export function RideCreditFilters({
@@ -28,7 +29,11 @@ export function RideCreditFilters({
   activeFilterCount,
   resultCount,
   totalCount,
+  compact = false,
 }: RideCreditFiltersProps) {
+  const spacingClass = compact ? 'space-y-3' : 'space-y-4';
+  const sectionSpacing = compact ? 'space-y-2' : 'space-y-3';
+  const paddingClass = compact ? 'p-4' : 'pt-6';
   // Extract unique values from credits for filter options
   const filterOptions = useMemo(() => {
     const countries = new Set<string>();
@@ -99,9 +104,10 @@ export function RideCreditFilters({
   };
 
   return (
-    <div className="space-y-4">
-      {/* Search Bar - Always Visible */}
-      <div className="relative">
+    <div className={compact ? 'p-4' : ''}>
+      <div className={spacingClass}>
+        {/* Search Bar - Always Visible */}
+        <div className="relative">
         <Search className="absolute left-3 top-1/2 -translate-y-1/2 w-4 h-4 text-muted-foreground" />
         <Input
           placeholder="Search rides, parks, manufacturers..."
@@ -133,10 +139,10 @@ export function RideCreditFilters({
             {cat.label}
           </Badge>
         ))}
-      </div>
+        </div>
 
-      {/* Collapsible Filter Sections */}
-      <div className="space-y-2">
+        {/* Collapsible Filter Sections */}
+        <div className={sectionSpacing}>
         {/* Geographic Filters */}
         <Collapsible>
           <CollapsibleTrigger className="flex items-center justify-between w-full p-3 rounded-lg bg-muted/50 hover:bg-muted transition-colors">
@@ -356,11 +362,11 @@ export function RideCreditFilters({
             </div>
           </CollapsibleContent>
         </Collapsible>
-      </div>
+        </div>
 
-      {/* Active Filters Display */}
-      {activeFilterCount > 0 && (
-        <div className="space-y-2">
+        {/* Active Filters Display */}
+        {activeFilterCount > 0 && (
+          <div className={sectionSpacing}>
           <div className="flex items-center justify-between">
             <span className="text-sm text-muted-foreground">
               Showing <strong>{resultCount}</strong> of <strong>{totalCount}</strong> credits
@@ -410,10 +416,11 @@ export function RideCreditFilters({
                 Has inversions
                 <X className="w-3 h-3 cursor-pointer" onClick={() => removeFilter('hasInversions')} />
               </Badge>
-            )}
+              )}
+            </div>
           </div>
-        </div>
-      )}
+        )}
+      </div>
     </div>
   );
 }
diff --git a/src/components/profile/RideCreditsManager.tsx b/src/components/profile/RideCreditsManager.tsx
index cbad1b15..8cfd7043 100644
--- a/src/components/profile/RideCreditsManager.tsx
+++ b/src/components/profile/RideCreditsManager.tsx
@@ -12,6 +12,7 @@ import { SortableRideCreditCard } from './SortableRideCreditCard';
 import { RideCreditFilters } from './RideCreditFilters';
 import { UserRideCredit } from '@/types/database';
 import { useRideCreditFilters } from '@/hooks/useRideCreditFilters';
+import { useIsMobile } from '@/hooks/use-mobile';
 import {
   DndContext,
   DragEndEvent,
@@ -37,6 +38,7 @@ export function RideCreditsManager({ userId }: RideCreditsManagerProps) {
   const [sortBy, setSortBy] = useState<'date' | 'count' | 'name' | 'custom'>('custom');
   const [isAddDialogOpen, setIsAddDialogOpen] = useState(false);
   const [isEditMode, setIsEditMode] = useState(false);
+  const isMobile = useIsMobile();
 
   // Use the filter hook
   const {
@@ -328,146 +330,175 @@ export function RideCreditsManager({ userId }: RideCreditsManagerProps) {
         </Card>
       </div>
 
-      {/* Filters */}
-      <Card>
-        <CardContent className="pt-6">
-          <RideCreditFilters
-            filters={filters}
-            onFilterChange={updateFilter}
-            onClearFilters={clearFilters}
-            credits={credits}
-            activeFilterCount={activeFilterCount}
-            resultCount={displayCredits.length}
-            totalCount={credits.length}
-          />
-        </CardContent>
-      </Card>
-
-      {/* Controls */}
-      <div className="flex flex-wrap gap-4 items-center justify-between">
-        <div className="flex gap-2">
-          <Button onClick={() => setIsAddDialogOpen(true)}>
-            <Plus className="w-4 h-4 mr-2" />
-            Add Credit
-          </Button>
-          
-          <Button 
-            variant={isEditMode ? 'default' : 'outline'}
-            onClick={() => setIsEditMode(!isEditMode)}
-          >
-            <GripVertical className="w-4 h-4 mr-2" />
-            {isEditMode ? 'Done Editing' : 'Edit Order'}
-          </Button>
-        </div>
-
-        <div className="flex gap-2">
-          <Select value={sortBy} onValueChange={(value) => setSortBy(value as typeof sortBy)}>
-            <SelectTrigger className="w-[180px]">
-              <SelectValue placeholder="Sort by" />
-            </SelectTrigger>
-            <SelectContent>
-              <SelectItem value="custom">Custom Order</SelectItem>
-              <SelectItem value="date">Most Recent</SelectItem>
-              <SelectItem value="count">Most Ridden</SelectItem>
-              <SelectItem value="name">Ride Name</SelectItem>
-            </SelectContent>
-          </Select>
-
-          <div className="flex border rounded-md">
-            <Button
-              variant={viewMode === 'grid' ? 'default' : 'ghost'}
-              size="icon"
-              onClick={() => setViewMode('grid')}
-            >
-              <LayoutGrid className="w-4 h-4" />
-            </Button>
-            <Button
-              variant={viewMode === 'list' ? 'default' : 'ghost'}
-              size="icon"
-              onClick={() => setViewMode('list')}
-            >
-              <List className="w-4 h-4" />
-            </Button>
-          </div>
-        </div>
-      </div>
-
-      {/* Credits Display */}
-      {displayCredits.length === 0 ? (
-        <Card>
-          <CardContent className="py-12">
-            <div className="text-center">
-              {credits.length === 0 ? (
-                <>
-                  <h3 className="text-xl font-semibold mb-2">No Ride Credits Yet</h3>
-                  <p className="text-muted-foreground mb-4">
-                    Start tracking your ride experiences
-                  </p>
-                  <Button onClick={() => setIsAddDialogOpen(true)}>
-                    <Plus className="w-4 h-4 mr-2" />
-                    Add Your First Credit
-                  </Button>
-                </>
-              ) : (
-                <>
-                  <h3 className="text-xl font-semibold mb-2">No Results Found</h3>
-                  <p className="text-muted-foreground mb-4">
-                    Try adjusting your filters
-                  </p>
-                  <Button onClick={clearFilters} variant="outline">
-                    Clear Filters
-                  </Button>
-                </>
-              )}
+      {/* Main Content Area with Sidebar */}
+      <div className="flex gap-6 items-start">
+        {/* Left Sidebar - Desktop Only */}
+        {!isMobile && (
+          <aside className="w-80 flex-shrink-0">
+            <div className="sticky top-4">
+              <div className="rounded-lg border bg-card">
+                <RideCreditFilters
+                  filters={filters}
+                  onFilterChange={updateFilter}
+                  onClearFilters={clearFilters}
+                  credits={credits}
+                  activeFilterCount={activeFilterCount}
+                  resultCount={displayCredits.length}
+                  totalCount={credits.length}
+                  compact={true}
+                />
+              </div>
             </div>
-          </CardContent>
-        </Card>
-      ) : isEditMode ? (
-        <DndContext
-          sensors={sensors}
-          collisionDetection={closestCenter}
-          onDragEnd={handleDragEnd}
-        >
-          <SortableContext
-            items={displayCredits.map(c => c.id)}
-            strategy={verticalListSortingStrategy}
+          </aside>
+        )}
+
+        {/* Right Content Area */}
+        <div className="flex-1 min-w-0 space-y-4">
+          {/* Mobile Filters - Collapsible Card */}
+          {isMobile && (
+            <Card>
+              <CardContent className="pt-6">
+                <RideCreditFilters
+                  filters={filters}
+                  onFilterChange={updateFilter}
+                  onClearFilters={clearFilters}
+                  credits={credits}
+                  activeFilterCount={activeFilterCount}
+                  resultCount={displayCredits.length}
+                  totalCount={credits.length}
+                  compact={false}
+                />
+              </CardContent>
+            </Card>
+          )}
+
+          {/* Controls */}
+          <div className="flex flex-wrap gap-4 items-center justify-between">
+            <div className="flex gap-2">
+              <Button onClick={() => setIsAddDialogOpen(true)}>
+                <Plus className="w-4 h-4 mr-2" />
+                Add Credit
+              </Button>
+              
+              <Button 
+                variant={isEditMode ? 'default' : 'outline'}
+                onClick={() => setIsEditMode(!isEditMode)}
+              >
+                <GripVertical className="w-4 h-4 mr-2" />
+                {isEditMode ? 'Done Editing' : 'Edit Order'}
+              </Button>
+            </div>
+
+            <div className="flex gap-2">
+              <Select value={sortBy} onValueChange={(value) => setSortBy(value as typeof sortBy)}>
+                <SelectTrigger className="w-[180px]">
+                  <SelectValue placeholder="Sort by" />
+                </SelectTrigger>
+                <SelectContent>
+                  <SelectItem value="custom">Custom Order</SelectItem>
+                  <SelectItem value="date">Most Recent</SelectItem>
+                  <SelectItem value="count">Most Ridden</SelectItem>
+                  <SelectItem value="name">Ride Name</SelectItem>
+                </SelectContent>
+              </Select>
+
+              <div className="flex border rounded-md">
+                <Button
+                  variant={viewMode === 'grid' ? 'default' : 'ghost'}
+                  size="icon"
+                  onClick={() => setViewMode('grid')}
+                >
+                  <LayoutGrid className="w-4 h-4" />
+                </Button>
+                <Button
+                  variant={viewMode === 'list' ? 'default' : 'ghost'}
+                  size="icon"
+                  onClick={() => setViewMode('list')}
+                >
+                  <List className="w-4 h-4" />
+                </Button>
+              </div>
+            </div>
+          </div>
+
+          {/* Credits Display */}
+          {displayCredits.length === 0 ? (
+            <Card>
+              <CardContent className="py-12">
+                <div className="text-center">
+                  {credits.length === 0 ? (
+                    <>
+                      <h3 className="text-xl font-semibold mb-2">No Ride Credits Yet</h3>
+                      <p className="text-muted-foreground mb-4">
+                        Start tracking your ride experiences
+                      </p>
+                      <Button onClick={() => setIsAddDialogOpen(true)}>
+                        <Plus className="w-4 h-4 mr-2" />
+                        Add Your First Credit
+                      </Button>
+                    </>
+                  ) : (
+                    <>
+                      <h3 className="text-xl font-semibold mb-2">No Results Found</h3>
+                      <p className="text-muted-foreground mb-4">
+                        Try adjusting your filters
+                      </p>
+                      <Button onClick={clearFilters} variant="outline">
+                        Clear Filters
+                      </Button>
+                    </>
+                  )}
+                </div>
+              </CardContent>
+            </Card>
+          ) : isEditMode ? (
+          <DndContext
+            sensors={sensors}
+            collisionDetection={closestCenter}
+            onDragEnd={handleDragEnd}
           >
+            <SortableContext
+              items={displayCredits.map(c => c.id)}
+              strategy={verticalListSortingStrategy}
+            >
+              <div className={viewMode === 'grid' 
+                ? 'grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-4'
+                : 'space-y-4'
+              }>
+                {displayCredits.map((credit, index) => (
+                  <SortableRideCreditCard
+                    key={credit.id}
+                    credit={credit}
+                    position={index + 1}
+                    maxPosition={displayCredits.length}
+                    viewMode={viewMode}
+                    onUpdate={handleCreditUpdated}
+                    onDelete={() => handleCreditDeleted(credit.id)}
+                    onReorder={handleReorder}
+                  />
+                ))}
+              </div>
+            </SortableContext>
+          </DndContext>
+          ) : (
             <div className={viewMode === 'grid' 
               ? 'grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-4'
               : 'space-y-4'
             }>
               {displayCredits.map((credit, index) => (
-                <SortableRideCreditCard
+                <RideCreditCard
                   key={credit.id}
                   credit={credit}
                   position={index + 1}
-                  maxPosition={displayCredits.length}
                   viewMode={viewMode}
                   onUpdate={handleCreditUpdated}
                   onDelete={() => handleCreditDeleted(credit.id)}
-                  onReorder={handleReorder}
                 />
               ))}
             </div>
-          </SortableContext>
-        </DndContext>
-      ) : (
-        <div className={viewMode === 'grid' 
-          ? 'grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-4'
-          : 'space-y-4'
-        }>
-          {displayCredits.map((credit, index) => (
-            <RideCreditCard
-              key={credit.id}
-              credit={credit}
-              position={index + 1}
-              viewMode={viewMode}
-              onUpdate={handleCreditUpdated}
-              onDelete={() => handleCreditDeleted(credit.id)}
-            />
-          ))}
+          )}
         </div>
-      )}
+      </div>
 
       {/* Add Credit Dialog */}
       <AddRideCreditDialog