Commit Graph

229 Commits

Author SHA1 Message Date
Claude
571bf07b84 Fix critical error handling gaps in submission pipeline
Addressed real error handling issues identified during comprehensive
pipeline review:

1. **process-selective-approval edge function**
   - Added try-catch blocks around idempotency key updates (lines 216-262)
   - Prevents silent failures when updating submission status tracking
   - Updates are now non-blocking to ensure proper response delivery

2. **submissionItemsService.ts**
   - Added error logging before throwing in fetchSubmissionItems (line 75-81)
   - Added error handling for park location fetch failures (lines 99-107)
   - Location fetch errors are now logged as non-critical and don't block
     submission item retrieval

3. **notify-moderators-submission edge function**
   - Added error handling for notification log insert (lines 216-236)
   - Log failures are now non-blocking and properly logged
   - Ensures notification delivery isn't blocked by logging issues

4. **upload-image edge function**
   - Fixed CORS headers scope issue (line 127)
   - Moved corsHeaders definition outside try block
   - Prevents undefined reference in catch block error responses

All changes maintain backward compatibility and improve pipeline
resilience without altering functionality. Error handling is now
consistent with non-blocking patterns for auxiliary operations.
2025-11-08 03:47:54 +00:00
gpt-engineer-app[bot]
bdea5f0cc4 Fix timeline event updates and edge function
Update `update_entity_from_submission` and `delete_entity_from_submission` to support timeline events. Remove unused `p_idempotency_key` parameter from `process_approval_transaction` RPC call in `process-selective-approval` edge function.
2025-11-08 02:56:40 +00:00
gpt-engineer-app[bot]
576899cf25 Add ban evasion reporting to edge function
Added ban evasion reporting to the `upload-image` edge function for both DELETE and POST operations. This ensures that all ban evasion attempts, including those via direct API calls, are logged to `system_alerts` and visible on the `/admin/error-monitoring` dashboard.
2025-11-08 00:58:00 +00:00
gpt-engineer-app[bot]
91a5b0e7dd Implement Phase 3: Enhanced Error Handling
This commit implements Phase 3 of the Sacred Pipeline, focusing on enhanced error handling. It includes:

- **Transaction Status Polling Endpoint**: A new edge function `check-transaction-status` allows clients to poll the status of moderation transactions using idempotency keys.
- **Expanded Error Sanitizer Patterns**: The `src/lib/errorSanitizer.ts` file has been updated with more comprehensive patterns to remove sensitive information from error messages, making them safer for display and logging. User-friendly replacements for common errors are also included.
- **Rate Limiting for Submission Creation**: Client-side rate limiting has been implemented in `src/lib/submissionRateLimiter.ts` and applied to key submission functions within `src/lib/entitySubmissionHelpers.ts` (e.g., `submitParkCreation`, `submitRideCreation`, `submitParkUpdate`, `submitRideUpdate`) to prevent abuse and accidental duplicate submissions.
2025-11-07 18:22:27 +00:00
gpt-engineer-app[bot]
44f50f1f3c Fix edge function import error
Corrected an import error in the `run-cleanup-jobs` edge function. The function was attempting to import from a non-existent `../_shared/cors.ts` file. This has been resolved by defining the `corsHeaders` inline within the function, aligning with the pattern used in other edge functions.
2025-11-07 18:06:01 +00:00
gpt-engineer-app[bot]
93b9553e2c Connect to Lovable Cloud
Connect to Lovable Cloud using the supabase--enable tool.
2025-11-07 18:02:30 +00:00
gpt-engineer-app[bot]
d903e96e13 Implement pipeline monitoring alerts
Approve and implement the Supabase migration for the pipeline monitoring alert system. This includes expanding alert types, adding new monitoring functions, and updating existing ones with escalating thresholds.
2025-11-07 05:05:32 +00:00
gpt-engineer-app[bot]
a74b8d6e74 Fix: Implement pipeline error handling
Implement comprehensive error handling and robustness measures across the entire pipeline as per the detailed plan. This includes database-level security, client-side validation, scheduled maintenance, and fallback mechanisms for edge function failures.
2025-11-07 04:50:17 +00:00
gpt-engineer-app[bot]
13c6e20f11 Implement Phase 2 improvements
Implement slug uniqueness constraints, foreign key validation, and rate limiting.
2025-11-06 23:59:48 +00:00
gpt-engineer-app[bot]
24dbf5bbba Implement critical fixes
Approve and implement Phase 1 critical fixes including CORS, RPC rollback, idempotency, timeouts, and deadlock retry.
2025-11-06 21:51:39 +00:00
gpt-engineer-app[bot]
bd2f9a5a9e Remove old approval flow
Implement the destructive migration plan to remove the old approval flow entirely. This includes deleting the legacy edge function, removing the toggle component, simplifying frontend code, and updating documentation.
2025-11-06 21:14:59 +00:00
gpt-engineer-app[bot]
87fae37d90 Implement plan
Implements the plan to update the timeline event card component.
2025-11-06 20:10:09 +00:00
gpt-engineer-app[bot]
5217102ded Fix session variable pollution
Implement all phases to fix session variable pollution by changing `is_local` to `true` in the `create_submission_with_items` database function and the `process-selective-approval` edge function. This ensures session variables are transaction-scoped, preventing data corruption and attribution errors. Includes database migration, edge function updates, and monitoring for attribution mismatches.
2025-11-06 19:46:51 +00:00
gpt-engineer-app[bot]
5c1fbced45 Fix high priority pipeline issues
Implement orphaned image cleanup, temp refs cleanup, deadlock retry, and lock cleanup. These fixes address critical areas of data integrity, resource management, and system resilience within the submission pipeline.
2025-11-06 18:54:47 +00:00
gpt-engineer-app[bot]
85436b5c1e feat: Integrate idempotency
Implement idempotency for the process-selective-approval edge function as per the detailed plan.
2025-11-06 17:24:21 +00:00
gpt-engineer-app[bot]
1cc80e0dc4 Fix edge function transaction boundaries
Wrap edge function approval loop in database transaction to prevent partial data on failures. This change ensures atomicity for approval operations, preventing inconsistent data states in case of errors.
2025-11-06 16:11:52 +00:00
gpt-engineer-app[bot]
5b0ac813e2 Fix park submission locations
Implement Phase 1 of the JSONB violation fix by creating the `park_submission_locations` table. This includes migrating existing data from `park_submissions.temp_location_data` and updating relevant code to read and write to the new relational table. The `temp_location_data` column will be dropped after data migration.
2025-11-06 15:45:12 +00:00
gpt-engineer-app[bot]
bd4f75bfb2 Fix entity submission pipelines
Refactor park updates, ride updates, and timeline event submissions to use dedicated relational tables instead of JSON blobs in `submission_items.item_data`. This enforces the "NO JSON IN SQL" rule, improving queryability, data integrity, and consistency across the pipeline.
2025-11-06 15:13:36 +00:00
gpt-engineer-app[bot]
ed9d17bf10 Fix ride model technical specs
Implement plan to fix ride model technical specifications pipeline. This includes creating a new migration for the `ride_model_submission_technical_specifications` table, updating `entitySubmissionHelpers.ts` to handle insertion of technical specifications, and modifying the edge function `process-selective-approval/index.ts` to fetch these specifications. This ensures no data loss for ride model technical specifications.
2025-11-06 15:03:51 +00:00
gpt-engineer-app[bot]
de9a48951f Fix ride submission data loss
Implement the plan to fix critical data loss in ride submissions. This includes:
- Storing ride technical specifications, coaster statistics, and name history in submission tables.
- Adding missing category-specific fields to the `ride_submissions` table via a new migration.
- Updating submission helpers and the edge function to include these new fields.
- Fixing the park location Zod schema to include `street_address`.
2025-11-06 14:51:36 +00:00
gpt-engineer-app[bot]
9f5240ae95 Fix: Add street_address to composite submission approval
Implement the plan to add `street_address` to the location creation logic within the `process-selective-approval` edge function. This ensures that `street_address` is preserved when approving composite submissions, completing the end-to-end pipeline for this field.
2025-11-06 14:24:48 +00:00
gpt-engineer-app[bot]
b189f40c1f Fix date display and edit form issues 2025-11-06 05:01:51 +00:00
gpt-engineer-app[bot]
328a77a0a8 Fix: Normalize park_type in approval function 2025-11-06 04:50:48 +00:00
gpt-engineer-app[bot]
93e48ac457 Fix park type and moderator ID 2025-11-06 04:31:58 +00:00
gpt-engineer-app[bot]
090f6aca48 Refactor: Redeploy edge function 2025-11-06 04:25:29 +00:00
gpt-engineer-app[bot]
dfd17e8244 Refactor park submission location handling 2025-11-05 20:46:02 +00:00
gpt-engineer-app[bot]
f9c11cb064 Fix: Improve validation error handling 2025-11-05 20:36:02 +00:00
gpt-engineer-app[bot]
c8018b827e feat: Implement retry logic and tracking 2025-11-05 20:19:43 +00:00
gpt-engineer-app[bot]
028ea433bb Fix edge function query ambiguity 2025-11-05 20:09:44 +00:00
gpt-engineer-app[bot]
bd3bffcc20 Fix edge function errors 2025-11-05 19:40:35 +00:00
gpt-engineer-app[bot]
bdd4e046f5 Fix: Resolve edge function auth error 2025-11-05 19:23:25 +00:00
gpt-engineer-app[bot]
435ddf476b Fix edge function bundle timeout 2025-11-05 19:16:31 +00:00
gpt-engineer-app[bot]
e8fc479b10 Fix duplicate variable declaration 2025-11-05 19:12:48 +00:00
gpt-engineer-app[bot]
d62b3c2412 feat: Implement temp ref cleanup 2025-11-05 18:15:21 +00:00
gpt-engineer-app[bot]
b036fb4785 Add temp ref cleanup 2025-11-05 18:09:44 +00:00
gpt-engineer-app[bot]
40ebc3c11b Fix logging policy violation 2025-11-04 21:52:42 +00:00
gpt-engineer-app[bot]
deabb72330 feat: Implement sitemap generator 2025-11-04 21:48:50 +00:00
gpt-engineer-app[bot]
2a2f172c3b feat: Implement test data generation plan 2025-11-04 17:25:58 +00:00
gpt-engineer-app[bot]
e1c7d5599f Fix duplicate variable name 2025-11-04 16:20:02 +00:00
gpt-engineer-app[bot]
83e20bfd56 Fix seed-test-data edge function 2025-11-04 16:04:04 +00:00
gpt-engineer-app[bot]
f979637ba3 Fix stale references in seed data 2025-11-03 23:35:40 +00:00
gpt-engineer-app[bot]
62504da252 Fix seed-test-data edge function 2025-11-03 22:41:55 +00:00
gpt-engineer-app[bot]
22f4a68bd8 Refactor: Database and UI updates 2025-11-03 21:32:04 +00:00
gpt-engineer-app[bot]
2cd6b2c6c3 Fix remaining console logs and types 2025-11-03 20:04:11 +00:00
gpt-engineer-app[bot]
6fbaf0c606 Fix edge function logging and types 2025-11-03 19:57:27 +00:00
gpt-engineer-app[bot]
99ceacfe0c Fix remaining console statements 2025-11-03 19:24:38 +00:00
gpt-engineer-app[bot]
ba6bb8a317 Fix edge function console statements 2025-11-03 19:16:06 +00:00
gpt-engineer-app[bot]
c0f468451f Fix edge function console statements 2025-11-03 19:09:28 +00:00
gpt-engineer-app[bot]
7663205512 Fix remaining compliance violations 2025-11-03 18:47:59 +00:00
gpt-engineer-app[bot]
6efb6dda66 Fix all compliance violations 2025-11-03 18:38:46 +00:00