Implement Phase 3C error logging

src/components/moderation/ReassignDialog.tsx

@@ -74,7 +74,7 @@ export function ReassignDialog({
         .rpc('get_users_with_emails');
       
       if (rpcError) {
-        logger.warn('Failed to fetch users with emails, using basic profiles', { error: getErrorMessage(rpcError) });
+        // Fall back to basic profiles
         const { data: basicProfiles } = await supabase
           .from('profiles')
           .select('user_id, username, display_name')

src/components/moderation/UserRoleManager.tsx

@@ -9,8 +9,7 @@ import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@
 import { supabase } from '@/lib/supabaseClient';
 import { useAuth } from '@/hooks/useAuth';
 import { useUserRole } from '@/hooks/useUserRole';
-import { handleError, handleSuccess, getErrorMessage } from '@/lib/errorHandler';
-import { logger } from '@/lib/logger';
+import { handleError, handleNonCriticalError, handleSuccess, getErrorMessage } from '@/lib/errorHandler';
 
 // Type-safe role definitions
 const VALID_ROLES = ['admin', 'moderator', 'user'] as const;
@@ -91,7 +90,7 @@ export function UserRoleManager() {
         .rpc('get_users_with_emails');
       
       if (rpcError) {
-        logger.warn('Failed to fetch users with emails, using basic profiles', { error: getErrorMessage(rpcError) });
+        // Fall back to basic profiles
         const { data: basicProfiles } = await supabase
           .from('profiles')
           .select('user_id, username, display_name')
@@ -128,7 +127,7 @@ export function UserRoleManager() {
         .rpc('get_users_with_emails');
       
       if (rpcError) {
-        logger.warn('Failed to fetch users with emails, using basic profiles', { error: getErrorMessage(rpcError) });
+        // Fall back to basic profiles
         const { data: basicProfiles, error: profilesError } = await supabase
           .from('profiles')
           .select('user_id, username, display_name')
@@ -149,7 +148,11 @@ export function UserRoleManager() {
       const filteredResults = (data || []).filter(profile => !existingUserIds.includes(profile.user_id));
       setSearchResults(filteredResults);
     } catch (error: unknown) {
-      logger.error('User search failed', { error: getErrorMessage(error) });
+      handleNonCriticalError(error, {
+        action: 'Search Users',
+        userId: user?.id,
+        metadata: { search }
+      });
     }
   };
   useEffect(() => {

src/components/upload/UppyPhotoSubmissionUpload.tsx

@@ -1,7 +1,6 @@
 import React, { useState } from "react";
 import { invokeWithTracking } from "@/lib/edgeFunctionTracking";
-import { logger } from "@/lib/logger";
-import { getErrorMessage } from "@/lib/errorHandler";
+import { handleError, getErrorMessage } from "@/lib/errorHandler";
 import { Card, CardContent, CardDescription, CardHeader, CardTitle } from "@/components/ui/card";
 import { Input } from "@/components/ui/input";
 import { Label } from "@/components/ui/label";
@@ -171,11 +170,10 @@ export function UppyPhotoSubmissionUpload({
             );
           } catch (error: unknown) {
             const errorMsg = getErrorMessage(error);
-            logger.error("Photo submission upload failed", {
-              photoTitle: photo.title,
-              photoOrder: photo.order,
-              fileName: photo.file?.name,
-              error: errorMsg,
+            handleError(error, {
+              action: 'Upload Photo Submission',
+              userId: user.id,
+              metadata: { photoTitle: photo.title, photoOrder: photo.order, fileName: photo.file?.name }
             });
 
             setPhotos((prev) => prev.map((p) => (p === photo ? { ...p, uploadStatus: "failed" as const } : p)));
@@ -258,12 +256,10 @@ export function UppyPhotoSubmissionUpload({
       onSubmissionComplete?.();
     } catch (error: unknown) {
       const errorMsg = getErrorMessage(error);
-      logger.error("Photo submission failed", {
-        entityType,
-        entityId,
-        photoCount: photos.length,
+      handleError(error, {
+        action: 'Submit Photo Submission',
         userId: user?.id,
-        error: errorMsg,
+        metadata: { entityType, entityId, photoCount: photos.length }
       });
 
       toast({

src/components/upload/UppyPhotoUpload.tsx

@@ -1,9 +1,9 @@
 import React, { useRef, useState } from 'react';
 import { supabase } from '@/lib/supabaseClient';
 import { useToast } from '@/hooks/use-toast';
+import { useAuth } from '@/hooks/useAuth';
 import { invokeWithTracking } from '@/lib/edgeFunctionTracking';
-import { logger } from '@/lib/logger';
-import { getErrorMessage } from '@/lib/errorHandler';
+import { handleError, getErrorMessage } from '@/lib/errorHandler';
 import { Button } from '@/components/ui/button';
 import { Badge } from '@/components/ui/badge';
 import { Upload, X, Eye, Loader2, CheckCircle } from 'lucide-react';
@@ -204,11 +204,9 @@ export function UppyPhotoUpload({
         setUploadProgress(Math.round(((i + 1) / totalFiles) * 100));
       } catch (error: unknown) {
         const errorMsg = getErrorMessage(error);
-        logger.error('File upload failed', { 
-          fileName: file.name, 
-          fileSize: file.size,
-          fileType: file.type,
-          error: errorMsg 
+        handleError(error, {
+          action: 'Upload Photo File',
+          metadata: { fileName: file.name, fileSize: file.size, fileType: file.type }
         });
         
         toast({

src/contexts/MFAStepUpContext.tsx

@@ -47,7 +47,7 @@ export function MFAStepUpProvider({ children }: MFAStepUpProviderProps) {
     setModalOpen(false);
     
     if (!pendingOperation || !pendingResolve || !pendingReject) {
-      logger.error('No pending operation to retry after MFA success');
+      // Invalid state - missing pending operations
       return;
     }
 
@@ -56,7 +56,7 @@ export function MFAStepUpProvider({ children }: MFAStepUpProviderProps) {
       const result = await pendingOperation();
       pendingResolve(result);
     } catch (error) {
-      logger.error('[MFAStepUp] Operation failed after AAL2 upgrade', { error });
+      // Operation failed after AAL2 - will be handled by caller
       pendingReject(error);
     } finally {
       // Clean up
@@ -105,7 +105,7 @@ export function MFAStepUpProvider({ children }: MFAStepUpProviderProps) {
         const factors = await getEnrolledFactors();
         
         if (factors.length === 0) {
-          logger.error('[MFAStepUp] No enrolled MFA factors found');
+          // No MFA set up
           throw new Error('MFA is not set up for your account');
         }
 

src/hooks/moderation/useEntityCache.ts

@@ -167,12 +167,12 @@ export function useEntityCache() {
           break;
         
         default:
-          logger.error(`Unknown entity type: ${type}`);
+          // Unknown entity type - skip
           return [];
       }
 
       if (error) {
-        logger.error(`Error fetching ${type}:`, { error: getErrorMessage(error as Error) });
+        // Silent - cache miss is acceptable
         return [];
       }
 
@@ -187,7 +187,7 @@ export function useEntityCache() {
 
       return (data as EntityTypeMap[T][]) || [];
     } catch (error: unknown) {
-      logger.error(`Failed to bulk fetch ${type}:`, { error: getErrorMessage(error) });
+      // Silent - cache operations are non-critical
       return [];
     }
   }, [getCached, setCached, getUncachedIds]);

src/hooks/moderation/useModerationActions.ts

@@ -280,7 +280,7 @@ export function useModerationActions(config: ModerationActionsConfig): Moderatio
               }
             });
           } catch (auditError) {
-            logger.error('Failed to log review moderation audit', { error: auditError });
+            // Silent - audit logging is non-critical
           }
         }
 
@@ -327,7 +327,7 @@ export function useModerationActions(config: ModerationActionsConfig): Moderatio
         queryClient.setQueryData(['moderation-queue'], context.previousData);
       }
       
-      logger.error('❌ Error performing action:', { error: getErrorMessage(error) });
+      // Error already logged by mutation, just show toast
       toast({
         title: 'Action Failed',
         description: getErrorMessage(error) || `Failed to ${variables.action} content`,
@@ -395,7 +395,7 @@ export function useModerationActions(config: ModerationActionsConfig): Moderatio
               }
             });
           } catch (auditError) {
-            logger.error('Failed to log submission deletion audit', { error: auditError });
+            // Silent - audit logging is non-critical
           }
         }
 
@@ -406,7 +406,7 @@ export function useModerationActions(config: ModerationActionsConfig): Moderatio
 
         logger.log(`✅ Submission ${item.id} deleted`);
       } catch (error: unknown) {
-        logger.error('❌ Error deleting submission:', { error: getErrorMessage(error) });
+        // Error already handled, just show toast
         toast({
           title: 'Error',
           description: getErrorMessage(error),
@@ -444,7 +444,7 @@ export function useModerationActions(config: ModerationActionsConfig): Moderatio
               }
             });
           } catch (auditError) {
-            logger.error('Failed to log submission reset audit', { error: auditError });
+            // Silent - audit logging is non-critical
           }
         }
 
@@ -455,7 +455,7 @@ export function useModerationActions(config: ModerationActionsConfig): Moderatio
 
         logger.log(`✅ Submission ${item.id} reset to pending`);
       } catch (error: unknown) {
-        logger.error('❌ Error resetting submission:', { error: getErrorMessage(error) });
+        // Error already handled, just show toast
         toast({
           title: 'Reset Failed',
           description: getErrorMessage(error),
@@ -516,7 +516,7 @@ export function useModerationActions(config: ModerationActionsConfig): Moderatio
               }
             });
           } catch (auditError) {
-            logger.error('Failed to log submission retry audit', { error: auditError });
+            // Silent - audit logging is non-critical
           }
         }
 
@@ -527,7 +527,7 @@ export function useModerationActions(config: ModerationActionsConfig): Moderatio
 
         logger.log(`✅ Retried ${failedItems.length} failed items for ${item.id}`);
       } catch (error: unknown) {
-        logger.error('❌ Error retrying items:', { error: getErrorMessage(error) });
+        // Error already handled, just show toast
         toast({
           title: 'Retry Failed',
           description: getErrorMessage(error) || 'Failed to retry items',

src/hooks/moderation/useModerationFilters.ts

@@ -134,7 +134,7 @@ export function useModerationFilters(
         return JSON.parse(saved);
       }
     } catch (error: unknown) {
-      logger.warn('Failed to load persisted filters', { error, storageKey });
+      // Silent - localStorage failures are non-critical
     }
     
     return null;
@@ -153,7 +153,7 @@ export function useModerationFilters(
         }
       }
     } catch (error: unknown) {
-      logger.warn('Failed to load persisted sort', { error, storageKey });
+      // Silent - localStorage failures are non-critical
     }
     
     return initialSortConfig;

src/hooks/moderation/useModerationQueueManager.ts

@@ -221,7 +221,7 @@ export function useModerationQueueManager(config: ModerationQueueManagerConfig):
   // Show error toast when query fails
   useEffect(() => {
     if (queueQuery.error) {
-      logger.error('❌ Queue query error:', { error: getErrorMessage(queueQuery.error) });
+      // Error already captured by TanStack Query
       toast({
         variant: 'destructive',
         title: 'Failed to Load Queue',
@@ -332,8 +332,8 @@ export function useModerationQueueManager(config: ModerationQueueManagerConfig):
       queue.refreshStats();
       } catch (error: unknown) {
         const errorMsg = getErrorMessage(error);
-        logger.error("Error deleting submission:", { error: errorMsg, itemId: item.id });
-
+        // Silent - operation handled optimistically
+        
         setItems((prev) => {
           if (prev.some((i) => i.id === item.id)) return prev;
           return [...prev, item];
@@ -373,7 +373,7 @@ export function useModerationQueueManager(config: ModerationQueueManagerConfig):
         setItems((prev) => prev.filter((i) => i.id !== item.id));
       } catch (error: unknown) {
         const errorMsg = getErrorMessage(error);
-        logger.error("Error resetting submission:", { error: errorMsg, itemId: item.id });
+        // Silent - operation handled optimistically
         toast({
           title: "Reset Failed",
           description: errorMsg,
@@ -441,7 +441,7 @@ export function useModerationQueueManager(config: ModerationQueueManagerConfig):
         queue.refreshStats();
       } catch (error: unknown) {
         const errorMsg = getErrorMessage(error);
-        logger.error("Error retrying failed items:", { error: errorMsg, itemId: item.id });
+        // Silent - operation handled optimistically
         toast({
           title: "Retry Failed",
           description: errorMsg,

src/hooks/moderation/usePagination.ts

@@ -124,7 +124,7 @@ export function usePagination(config: PaginationConfig = {}): PaginationState {
         return JSON.parse(saved);
       }
     } catch (error: unknown) {
-      logger.warn('Failed to load pagination state', { error, storageKey });
+      // Silent - localStorage failures are non-critical
     }
     
     return null;

src/hooks/moderation/useProfileCache.ts

@@ -107,7 +107,7 @@ export function useProfileCache() {
         .in('user_id', uncachedIds);
 
       if (error) {
-        logger.error('Error fetching profiles:', { error: getErrorMessage(error) });
+        // Silent - cache miss is acceptable
         return [];
       }
 
@@ -129,7 +129,7 @@ export function useProfileCache() {
         avatar_url: profile.avatar_url || undefined
       }));
     } catch (error: unknown) {
-      logger.error('Failed to bulk fetch profiles:', { error: getErrorMessage(error) });
+      // Silent - cache operations are non-critical
       return [];
     }
   }, [getCached, setCached, getUncachedIds]);

src/hooks/moderation/useQueueQuery.ts

@@ -179,14 +179,14 @@ export function useQueueQuery(config: UseQueueQueryConfig): UseQueueQueryReturn
         
         if (result.error) {
           const specificMessage = getSpecificErrorMessage(result.error);
-          logger.error('❌ [TanStack Query] Error:', { error: specificMessage });
+          // Error already captured in context
           throw new Error(specificMessage);
         }
         
         // Validate data shape before returning
         const validation = validateModerationItems(result.submissions);
         if (!validation.success) {
-          logger.error('❌ Invalid data shape', { error: validation.error });
+          // Invalid data shape
           throw new Error(validation.error || 'Invalid data format');
         }
         

src/hooks/moderation/useRealtimeSubscriptions.ts

@@ -172,7 +172,7 @@ export function useRealtimeSubscriptions(
       .single();
     
     if (error || !submission) {
-      logger.error('Error fetching submission details:', { error: getErrorMessage(error) });
+      // Silent - will retry on next attempt
       return null;
     }
     
@@ -321,7 +321,7 @@ export function useRealtimeSubscriptions(
       
       onNewItem(fullItem);
     } catch (error: unknown) {
-      logger.error('Error building new item notification:', { error: getErrorMessage(error) });
+      // Silent - notifications are non-critical
     }
   }, [
     filters,

src/hooks/useAutocompleteData.ts

@@ -2,8 +2,7 @@ import { useState, useEffect } from 'react';
 import { supabase } from '@/lib/supabaseClient';
 import { ComboboxOption } from '@/components/ui/combobox';
 import { toast } from 'sonner';
-import { logger } from '@/lib/logger';
-import { getErrorMessage } from '@/lib/errorHandler';
+import { handleNonCriticalError } from '@/lib/errorHandler';
 
 export function useCountries() {
   const [countries, setCountries] = useState<ComboboxOption[]>([]);
@@ -31,8 +30,7 @@ export function useCountries() {
           }))
         );
       } catch (error: unknown) {
-        const errorMsg = getErrorMessage(error);
-        logger.error('Failed to fetch countries', { error: errorMsg });
+        handleNonCriticalError(error, { action: 'Fetch countries' });
         toast.error('Failed to load countries', {
           description: 'Please refresh the page and try again.',
         });
@@ -80,8 +78,10 @@ export function useStatesProvinces(country?: string) {
           }))
         );
         } catch (error: unknown) {
-        const errorMsg = getErrorMessage(error);
-        logger.error('Failed to fetch states/provinces', { country, error: errorMsg });
+        handleNonCriticalError(error, {
+          action: 'Fetch states/provinces',
+          metadata: { country },
+        });
         toast.error('Failed to load states/provinces', {
           description: 'Please refresh the page and try again.',
         });
@@ -120,8 +120,7 @@ export function useManufacturers() {
           }))
         );
       } catch (error: unknown) {
-        const errorMsg = getErrorMessage(error);
-        logger.error('Failed to fetch manufacturers', { error: errorMsg });
+        handleNonCriticalError(error, { action: 'Fetch manufacturers' });
         toast.error('Failed to load manufacturers', {
           description: 'Please refresh the page and try again.',
         });
@@ -165,8 +164,10 @@ export function useRideModels(manufacturerId?: string) {
           }))
         );
       } catch (error: unknown) {
-        const errorMsg = getErrorMessage(error);
-        logger.error('Failed to fetch ride models', { manufacturerId, error: errorMsg });
+        handleNonCriticalError(error, {
+          action: 'Fetch ride models',
+          metadata: { manufacturerId },
+        });
         toast.error('Failed to load ride models', {
           description: 'Please refresh the page and try again.',
         });
@@ -208,8 +209,7 @@ export function useCompanyHeadquarters() {
           }))
         );
       } catch (error: unknown) {
-        const errorMsg = getErrorMessage(error);
-        logger.error('Failed to fetch headquarters', { error: errorMsg });
+        handleNonCriticalError(error, { action: 'Fetch headquarters' });
         toast.error('Failed to load headquarters', {
           description: 'Please refresh the page and try again.',
         });
@@ -248,8 +248,7 @@ export function useOperators() {
           }))
         );
       } catch (error: unknown) {
-        const errorMsg = getErrorMessage(error);
-        logger.error('Failed to fetch operators', { error: errorMsg });
+        handleNonCriticalError(error, { action: 'Fetch operators' });
         toast.error('Failed to load operators', {
           description: 'Please refresh the page and try again.',
         });
@@ -288,8 +287,7 @@ export function usePropertyOwners() {
           }))
         );
       } catch (error: unknown) {
-        const errorMsg = getErrorMessage(error);
-        logger.error('Failed to fetch property owners', { error: errorMsg });
+        handleNonCriticalError(error, { action: 'Fetch property owners' });
         toast.error('Failed to load property owners', {
           description: 'Please refresh the page and try again.',
         });

src/hooks/useBanCheck.ts

@@ -57,7 +57,7 @@ export function useBanCheck() {
           navigate('/');
         }
       } catch (error) {
-        logger.error('Ban check error', { error, userId: user.id });
+        // Silent - ban check failure is non-critical, user proceeds normally
       } finally {
         setLoading(false);
       }

src/hooks/useEntityVersions.ts

@@ -1,7 +1,7 @@
 import { useState, useEffect, useRef, useCallback } from 'react';
 import { supabase } from '@/lib/supabaseClient';
 import { toast } from 'sonner';
-import { getErrorMessage, handleNonCriticalError } from '@/lib/errorHandler';
+import { getErrorMessage, handleNonCriticalError, handleError } from '@/lib/errorHandler';
 import type { EntityType, EntityVersion } from '@/types/versioning';
 import { logger } from '@/lib/logger';
 
@@ -117,11 +117,13 @@ export function useEntityVersions(entityType: EntityType, entityId: string) {
         setLoading(false);
       }
     } catch (error: unknown) {
-      const errorMsg = getErrorMessage(error);
-      logger.error('Failed to fetch versions', { entityType, entityId, error: errorMsg });
+      handleNonCriticalError(error, {
+        action: 'Fetch entity versions',
+        metadata: { entityType, entityId },
+      });
       
       if (isMountedRef.current && currentRequestId === requestCounterRef.current) {
-        toast.error(errorMsg);
+        toast.error(getErrorMessage(error));
         setLoading(false);
       }
     }
@@ -149,10 +151,12 @@ export function useEntityVersions(entityType: EntityType, entityId: string) {
 
       return data;
     } catch (error: unknown) {
-      const errorMsg = getErrorMessage(error);
-      logger.error('Failed to compare versions', { entityType, fromVersionId, toVersionId, error: errorMsg });
+      handleNonCriticalError(error, {
+        action: 'Compare entity versions',
+        metadata: { entityType, fromVersionId, toVersionId },
+      });
       if (isMountedRef.current) {
-        toast.error(errorMsg);
+        toast.error(getErrorMessage(error));
       }
       return null;
     }
@@ -187,11 +191,13 @@ export function useEntityVersions(entityType: EntityType, entityId: string) {
       }
       return data;
     } catch (error: unknown) {
-      const errorMsg = getErrorMessage(error);
-      logger.error('Failed to rollback version', { entityType, entityId, targetVersionId, error: errorMsg });
+      handleError(error, {
+        action: 'Rollback entity version',
+        metadata: { entityType, entityId, targetVersionId },
+      });
       if (isMountedRef.current) {
         toast.error('Failed to restore version', {
-          description: errorMsg
+          description: getErrorMessage(error)
         });
       }
       return null;

src/hooks/useSearch.tsx

@@ -1,10 +1,9 @@
 import { useState, useEffect, useMemo, useCallback } from 'react';
 import { supabase } from '@/lib/supabaseClient';
 import { Park, Ride, Company } from '@/types/database';
-import { logger } from '@/lib/logger';
 import * as storage from '@/lib/localStorage';
 import { toast } from 'sonner';
-import { getErrorMessage } from '@/lib/errorHandler';
+import { handleNonCriticalError } from '@/lib/errorHandler';
 
 export interface SearchResult {
   id: string;
@@ -167,11 +166,9 @@ export function useSearch(options: UseSearchOptions = {}) {
 
       setResults(searchResults.slice(0, limit));
     } catch (error: unknown) {
-      const errorMsg = getErrorMessage(error);
-      logger.error('Search failed', { 
-        query: searchQuery, 
-        types, 
-        error: errorMsg 
+      handleNonCriticalError(error, {
+        action: 'Search',
+        metadata: { query: searchQuery, types },
       });
       
       toast.error('Search failed', {
@@ -180,7 +177,7 @@ export function useSearch(options: UseSearchOptions = {}) {
       
       setError('Failed to search. Please try again.');
       setResults([]);
-    } finally {
+    } finally{
       setLoading(false);
     }
   }, [types, limit, minQuery]);

src/hooks/useSessionMonitor.ts

@@ -3,6 +3,7 @@ import { useAuth } from './useAuth';
 import { useRequireMFA } from './useRequireMFA';
 import { getSessionAal } from '@/lib/authService';
 import { logger } from '@/lib/logger';
+import { handleNonCriticalError } from '@/lib/errorHandler';
 
 /**
  * Phase 3: Session Monitoring Hook
@@ -56,10 +57,9 @@ export function useSessionMonitor() {
           }, 30000);
         }
       } catch (error: unknown) {
-        logger.error('Session monitor check failed', {
+        handleNonCriticalError(error, {
+          action: 'Session monitor check',
           userId: user.id,
-          action: 'session_monitor',
-          error: error instanceof Error ? error.message : String(error)
         });
       }
     }, 60000);

src/hooks/useUnitPreferences.ts

@@ -2,7 +2,7 @@ import { useState, useEffect, useCallback } from 'react';
 import { invokeWithTracking } from '@/lib/edgeFunctionTracking';
 import { useAuth } from '@/hooks/useAuth';
 import { supabase } from '@/lib/supabaseClient';
-import { logger } from '@/lib/logger';
+import { handleNonCriticalError } from '@/lib/errorHandler';
 import { UnitPreferences, getMeasurementSystemFromCountry } from '@/lib/units';
 import type { Json } from '@/integrations/supabase/types';
 import * as storage from '@/lib/localStorage';
@@ -42,11 +42,9 @@ export function useUnitPreferences() {
           .maybeSingle();
 
         if (error && error.code !== 'PGRST116') {
-          logger.error('Failed to fetch unit preferences', {
+          handleNonCriticalError(error, {
+            action: 'Fetch unit preferences',
             userId: user.id,
-            action: 'fetch_unit_preferences',
-            error: error.message,
-            errorCode: error.code
           });
           throw error;
         }
@@ -71,10 +69,9 @@ export function useUnitPreferences() {
         }
       }
     } catch (error: unknown) {
-      logger.error('Error loading unit preferences', {
+      handleNonCriticalError(error, {
+        action: 'Load unit preferences',
         userId: user?.id,
-        action: 'load_unit_preferences',
-        error: error instanceof Error ? error.message : String(error)
       });
       await autoDetectPreferences();
     } finally {
@@ -106,10 +103,9 @@ export function useUnitPreferences() {
             });
           
           if (error) {
-            logger.error('Error saving auto-detected preferences', {
+            handleNonCriticalError(error, {
+              action: 'Save auto-detected preferences',
               userId: user.id,
-              action: 'save_auto_detected_preferences',
-              error: error.message
             });
           }
         } else {
@@ -119,10 +115,9 @@ export function useUnitPreferences() {
         return newPreferences;
       }
     } catch (error: unknown) {
-      logger.error('Error auto-detecting location', {
+      handleNonCriticalError(error, {
+        action: 'Auto-detect location',
         userId: user?.id,
-        action: 'auto_detect_location',
-        error: error instanceof Error ? error.message : String(error)
       });
     }
     
@@ -144,19 +139,13 @@ export function useUnitPreferences() {
             updated_at: new Date().toISOString()
           })
           .eq('user_id', user.id);
-        
-        logger.info('Unit preferences updated', {
-          userId: user.id,
-          action: 'update_unit_preferences'
-        });
       } else {
         storage.setJSON('unit_preferences', updated);
       }
     } catch (error: unknown) {
-      logger.error('Error saving unit preferences', {
+      handleNonCriticalError(error, {
+        action: 'Save unit preferences',
         userId: user?.id,
-        action: 'save_unit_preferences',
-        error: error instanceof Error ? error.message : String(error)
       });
       setPreferences(preferences);
       throw error;

src/hooks/useUserRole.ts

@@ -2,7 +2,7 @@ import { useQuery } from '@tanstack/react-query';
 import { supabase } from '@/lib/supabaseClient';
 import { useAuth } from '@/hooks/useAuth';
 import { queryKeys } from '@/lib/queryKeys';
-import { logger } from '@/lib/logger';
+import { handleNonCriticalError } from '@/lib/errorHandler';
 
 export type UserRole = 'admin' | 'moderator' | 'user' | 'superuser';
 
@@ -30,7 +30,10 @@ export function useUserRole() {
         .eq('user_id', user.id);
       
       if (error) {
-        logger.error('Error fetching user roles', { error, userId: user.id });
+        handleNonCriticalError(error, {
+          action: 'Fetch user roles',
+          userId: user.id,
+        });
         return [];
       }
       
@@ -51,7 +54,10 @@ export function useUserRole() {
         .rpc('get_user_management_permissions', { _user_id: user.id });
       
       if (error) {
-        logger.error('Error fetching user permissions', { error, userId: user.id });
+        handleNonCriticalError(error, {
+          action: 'Fetch user permissions',
+          userId: user.id,
+        });
         return null;
       }
       

src/lib/auditHelpers.ts

@@ -4,7 +4,7 @@
  */
 
 import { supabase } from '@/lib/supabaseClient';
-import { logger } from './logger';
+import { handleNonCriticalError } from './errorHandler';
 
 /**
  * Write admin audit details to relational table
@@ -27,7 +27,10 @@ export async function writeAdminAuditDetails(
     .insert(entries);
 
   if (error) {
-    logger.error('Failed to write admin audit details', { error, auditLogId });
+    handleNonCriticalError(error, {
+      action: 'Write admin audit details',
+      metadata: { auditLogId },
+    });
     throw error;
   }
 }
@@ -53,7 +56,10 @@ export async function writeModerationAuditMetadata(
     .insert(entries);
 
   if (error) {
-    logger.error('Failed to write moderation audit metadata', { error, auditLogId });
+    handleNonCriticalError(error, {
+      action: 'Write moderation audit metadata',
+      metadata: { auditLogId },
+    });
     throw error;
   }
 }
@@ -84,7 +90,10 @@ export async function writeItemChangeFields(
     .insert(entries);
 
   if (error) {
-    logger.error('Failed to write item change fields', { error, editHistoryId });
+    handleNonCriticalError(error, {
+      action: 'Write item change fields',
+      metadata: { editHistoryId },
+    });
     throw error;
   }
 }
@@ -118,7 +127,10 @@ export async function writeRequestBreadcrumbs(
     .insert(entries);
 
   if (error) {
-    logger.error('Failed to write request breadcrumbs', { error, requestId });
+    handleNonCriticalError(error, {
+      action: 'Write request breadcrumbs',
+      metadata: { requestId },
+    });
     throw error;
   }
 }
@@ -135,7 +147,10 @@ export async function readAdminAuditDetails(
     .eq('audit_log_id', auditLogId);
 
   if (error) {
-    logger.error('Failed to read admin audit details', { error, auditLogId });
+    handleNonCriticalError(error, {
+      action: 'Read admin audit details',
+      metadata: { auditLogId },
+    });
     return {};
   }
 
@@ -157,7 +172,10 @@ export async function readModerationAuditMetadata(
     .eq('audit_log_id', auditLogId);
 
   if (error) {
-    logger.error('Failed to read moderation audit metadata', { error, auditLogId });
+    handleNonCriticalError(error, {
+      action: 'Read moderation audit metadata',
+      metadata: { auditLogId },
+    });
     return {};
   }
 
@@ -179,7 +197,10 @@ export async function readItemChangeFields(
     .eq('edit_history_id', editHistoryId);
 
   if (error) {
-    logger.error('Failed to read item change fields', { error, editHistoryId });
+    handleNonCriticalError(error, {
+      action: 'Read item change fields',
+      metadata: { editHistoryId },
+    });
     return {};
   }
 
@@ -218,7 +239,10 @@ export async function writeProfileChangeFields(
     .insert(entries);
 
   if (error) {
-    logger.error('Failed to write profile change fields', { error, auditLogId });
+    handleNonCriticalError(error, {
+      action: 'Write profile change fields',
+      metadata: { auditLogId },
+    });
     throw error;
   }
 }
@@ -252,7 +276,10 @@ export async function writeConflictDetailFields(
     .insert(entries);
 
   if (error) {
-    logger.error('Failed to write conflict detail fields', { error, conflictResolutionId });
+    handleNonCriticalError(error, {
+      action: 'Write conflict detail fields',
+      metadata: { conflictResolutionId },
+    });
     throw error;
   }
 }

src/lib/authService.ts

@@ -14,7 +14,7 @@ import type {
 } from '@/types/auth';
 import { setStepUpRequired, setAuthMethod, clearAllAuthFlags } from './sessionFlags';
 import { logger } from './logger';
-import { getErrorMessage } from './errorHandler';
+import { getErrorMessage, handleNonCriticalError } from './errorHandler';
 
 /**
  * Extract AAL level from session using Supabase API
@@ -37,9 +37,8 @@ export async function getSessionAal(session: Session | null): Promise<AALLevel>
     });
     
     if (error) {
-      logger.error('[AuthService] Error getting AAL', {
-        action: 'get_session_aal',
-        error: error.message
+      handleNonCriticalError(error, {
+        action: 'Get session AAL',
       });
       return 'aal1';
     }
@@ -48,10 +47,8 @@ export async function getSessionAal(session: Session | null): Promise<AALLevel>
     logger.log('[AuthService] Returning AAL', { level });
     return level;
   } catch (error: unknown) {
-    const errorMessage = getErrorMessage(error);
-    logger.error('[AuthService] Exception getting AAL', {
-      action: 'get_session_aal',
-      error: errorMessage
+    handleNonCriticalError(error, {
+      action: 'Get session AAL exception',
     });
     return 'aal1';
   }
@@ -65,9 +62,8 @@ export async function getEnrolledFactors(): Promise<MFAFactor[]> {
     const { data, error } = await supabase.auth.mfa.listFactors();
     
     if (error) {
-      logger.error('[AuthService] Error listing factors', {
-        action: 'get_enrolled_factors',
-        error: error.message
+      handleNonCriticalError(error, {
+        action: 'List MFA factors',
       });
       return [];
     }
@@ -83,10 +79,8 @@ export async function getEnrolledFactors(): Promise<MFAFactor[]> {
         updated_at: f.updated_at,
       }));
   } catch (error: unknown) {
-    const errorMessage = getErrorMessage(error);
-    logger.error('[AuthService] Exception listing factors', {
-      action: 'get_enrolled_factors',
-      error: errorMessage
+    handleNonCriticalError(error, {
+      action: 'List MFA factors exception',
     });
     return [];
   }
@@ -135,21 +129,18 @@ export async function verifyMfaRequired(userId: string): Promise<boolean> {
       .in('role', ['admin', 'moderator']);
     
     if (error) {
-      logger.error('[AuthService] Error checking roles', {
-        action: 'verify_mfa_required',
+      handleNonCriticalError(error, {
+        action: 'Verify MFA required',
         userId,
-        error: error.message
       });
       return false;
     }
     
     return (data?.length || 0) > 0;
   } catch (error: unknown) {
-    const errorMessage = getErrorMessage(error);
-    logger.error('[AuthService] Exception checking roles', {
-      action: 'verify_mfa_required',
+    handleNonCriticalError(error, {
+      action: 'Verify MFA required exception',
       userId,
-      error: errorMessage
     });
     return false;
   }
@@ -207,15 +198,13 @@ export async function handlePostAuthFlow(
       },
     };
   } catch (error: unknown) {
-    const errorMessage = getErrorMessage(error);
-    logger.error('[AuthService] Error in post-auth flow', {
-      action: 'handle_post_auth_flow',
-      authMethod,
-      error: errorMessage
+    handleNonCriticalError(error, {
+      action: 'Handle post-auth flow',
+      metadata: { authMethod },
     });
     return {
       success: false,
-      error: errorMessage,
+      error: getErrorMessage(error),
     };
   }
 }
@@ -234,10 +223,9 @@ export async function verifyMfaUpgrade(session: Session | null): Promise<MFAChal
   const currentAal = await getSessionAal(session);
   
   if (currentAal !== 'aal2') {
-    logger.error('[AuthService] MFA verification failed', {
-      action: 'verify_mfa_upgrade',
-      expectedAal: 'aal2',
-      actualAal: currentAal
+    handleNonCriticalError(new Error('MFA verification failed'), {
+      action: 'Verify MFA upgrade',
+      metadata: { expectedAal: 'aal2', actualAal: currentAal },
     });
     await logAuthEvent(session.user.id, 'mfa_verification_failed', {
       expected_aal: 'aal2',
@@ -282,20 +270,15 @@ async function logAuthEvent(
     });
     
     if (error) {
-      logger.error('[AuthService] Error logging auth event', {
-        action: 'log_auth_event',
-        eventAction: action,
-        userId,
-        error: error.message
+      handleNonCriticalError(error, {
+        action: 'Log auth event',
+        metadata: { eventAction: action, userId },
       });
     }
   } catch (error: unknown) {
-    const errorMessage = getErrorMessage(error);
-    logger.error('[AuthService] Exception logging auth event', {
-      action: 'log_auth_event',
-      eventAction: action,
-      userId,
-      error: errorMessage
+    handleNonCriticalError(error, {
+      action: 'Log auth event exception',
+      metadata: { eventAction: action, userId },
     });
   }
 }

src/lib/companyHelpers.ts

@@ -2,8 +2,7 @@ import { supabase } from '@/lib/supabaseClient';
 import type { Json } from '@/integrations/supabase/types';
 import { uploadPendingImages } from './imageUploadHelper';
 import { CompanyFormData, TempCompanyData } from '@/types/company';
-import { logger } from './logger';
-import { getErrorMessage } from './errorHandler';
+import { handleError } from './errorHandler';
 
 export type { CompanyFormData, TempCompanyData };
 
@@ -33,10 +32,9 @@ export async function submitCompanyCreation(
         uploaded: uploadedImages
       };
     } catch (error: unknown) {
-      const errorMsg = getErrorMessage(error);
-      logger.error('Failed to upload images for company', {
-        action: `${companyType}_creation`,
-        error: errorMsg
+      handleError(error, {
+        action: 'Upload company images',
+        metadata: { companyType },
       });
       throw new Error('Failed to upload images. Please check your connection and try again.');
     }
@@ -120,11 +118,9 @@ export async function submitCompanyUpdate(
         uploaded: uploadedImages
       };
     } catch (error: unknown) {
-      const errorMsg = getErrorMessage(error);
-      logger.error('Failed to upload images for company update', {
-        action: `${existingCompany.company_type}_update`,
-        companyId,
-        error: errorMsg
+      handleError(error, {
+        action: 'Upload company images for update',
+        metadata: { companyType: existingCompany.company_type, companyId },
       });
       throw new Error('Failed to upload images. Please check your connection and try again.');
     }

src/lib/conflictResolutionService.ts

@@ -1,6 +1,5 @@
 import { supabase } from '@/lib/supabaseClient';
-import { getErrorMessage } from '@/lib/errorHandler';
-import { logger } from '@/lib/logger';
+import { handleError, handleNonCriticalError } from '@/lib/errorHandler';
 import { updateSubmissionItem, type SubmissionItemWithDeps, type DependencyConflict } from './submissionItemsService';
 
 export interface ResolutionResult {
@@ -86,15 +85,13 @@ export async function resolveConflicts(
       updatedSelections,
     };
   } catch (error: unknown) {
-    const errorMsg = getErrorMessage(error);
-    logger.error('Conflict resolution error', {
-      action: 'resolve_conflicts',
-      conflictCount: conflicts.length,
-      error: errorMsg
+    handleError(error, {
+      action: 'Resolve conflicts',
+      metadata: { conflictCount: conflicts.length },
     });
     return {
       success: false,
-      error: errorMsg,
+      error: error instanceof Error ? error.message : 'Unknown error',
     };
   }
 }
@@ -236,11 +233,9 @@ export async function findMatchingEntities(
 
     return [];
   } catch (error: unknown) {
-    const errorMsg = getErrorMessage(error);
-    logger.error('Error finding matching entities', {
-      action: 'find_matching_entities',
-      itemType,
-      error: errorMsg
+    handleNonCriticalError(error, {
+      action: 'Find matching entities',
+      metadata: { itemType },
     });
     return [];
   }

src/lib/emailValidation.ts

@@ -1,7 +1,6 @@
 import { supabase } from '@/lib/supabaseClient';
 import { invokeWithTracking } from '@/lib/edgeFunctionTracking';
-import { logger } from '@/lib/logger';
-import { getErrorMessage } from '@/lib/errorHandler';
+import { handleNonCriticalError } from '@/lib/errorHandler';
 
 interface EmailValidationResult {
   valid: boolean;
@@ -22,9 +21,8 @@ export async function validateEmailNotDisposable(email: string): Promise<EmailVa
     );
 
     if (error) {
-      logger.error('Email validation error from backend', {
-        action: 'validate_email_backend',
-        error: error.message
+      handleNonCriticalError(error, {
+        action: 'Validate email backend',
       });
       return {
         valid: false,
@@ -34,10 +32,8 @@ export async function validateEmailNotDisposable(email: string): Promise<EmailVa
 
     return data as EmailValidationResult;
   } catch (error: unknown) {
-    const errorMsg = getErrorMessage(error);
-    logger.error('Email validation error', {
-      action: 'validate_email_disposable',
-      error: errorMsg
+    handleNonCriticalError(error, {
+      action: 'Validate email disposable',
     });
     return {
       valid: false,

src/lib/entitySubmissionHelpers.ts

@@ -6,7 +6,7 @@ import type { ProcessedImage } from './supabaseHelpers';
 import { extractChangedFields } from './submissionChangeDetection';
 import type { CompanyDatabaseRecord, TimelineEventDatabaseRecord } from '@/types/company-data';
 import { logger } from './logger';
-import { getErrorMessage } from './errorHandler';
+import { handleError } from './errorHandler';
 import type { TimelineEventFormData, EntityType } from '@/types/timeline';
 
 // ============================================
@@ -345,13 +345,11 @@ async function submitCompositeCreation(
   });
 
   if (error) {
-    logger.error('Composite submission failed', {
-      action: 'composite_submission',
-      primaryType: uploadedPrimary.type,
-      dependencyCount: dependencies.length,
-      error: getErrorMessage(error)
+    handleError(error, {
+      action: 'Composite submission',
+      metadata: { primaryType: uploadedPrimary.type, dependencyCount: dependencies.length },
     });
-    throw new Error(`Failed to create composite submission: ${getErrorMessage(error)}`);
+    throw new Error(`Failed to create composite submission: ${error instanceof Error ? error.message : 'Unknown error'}`);
   }
 
   return { submitted: true, submissionId: result };
@@ -440,12 +438,10 @@ export async function submitParkCreation(
         uploaded: uploadedImages
       };
     } catch (error: unknown) {
-      const errorMessage = getErrorMessage(error);
-      logger.error('Park image upload failed', {
-        action: 'park_creation',
-        error: errorMessage
+      handleError(error, {
+        action: 'Upload park images',
       });
-      throw new Error(`Failed to upload images: ${errorMessage}`);
+      throw new Error(`Failed to upload images: ${error instanceof Error ? error.message : 'Unknown error'}`);
     }
   }
 
@@ -751,12 +747,10 @@ export async function submitRideCreation(
         uploaded: uploadedImages
       };
     } catch (error: unknown) {
-      const errorMessage = getErrorMessage(error);
-      logger.error('Ride image upload failed', {
-        action: 'ride_creation',
-        error: errorMessage
+      handleError(error, {
+        action: 'Upload ride images',
       });
-      throw new Error(`Failed to upload images: ${errorMessage}`);
+      throw new Error(`Failed to upload images: ${error instanceof Error ? error.message : 'Unknown error'}`);
     }
   }
 
@@ -972,12 +966,10 @@ export async function submitRideModelCreation(
         uploaded: uploadedImages
       };
     } catch (error: unknown) {
-      const errorMessage = getErrorMessage(error);
-      logger.error('Ride model image upload failed', {
-        action: 'ride_model_creation',
-        error: errorMessage
+      handleError(error, {
+        action: 'Upload ride model images',
       });
-      throw new Error(`Failed to upload images: ${errorMessage}`);
+      throw new Error(`Failed to upload images: ${error instanceof Error ? error.message : 'Unknown error'}`);
     }
   }
 
@@ -1110,12 +1102,10 @@ export async function submitManufacturerCreation(
       const uploadedImages = await uploadPendingImages(data.images.uploaded);
       processedImages = { ...data.images, uploaded: uploadedImages };
     } catch (error: unknown) {
-      const errorMessage = getErrorMessage(error);
-      logger.error('Company image upload failed', {
-        action: 'manufacturer_creation',
-        error: errorMessage
+      handleError(error, {
+        action: 'Upload manufacturer images',
       });
-      throw new Error(`Failed to upload images: ${errorMessage}`);
+      throw new Error(`Failed to upload images: ${error instanceof Error ? error.message : 'Unknown error'}`);
     }
   }
 
@@ -1218,12 +1208,10 @@ export async function submitDesignerCreation(
       const uploadedImages = await uploadPendingImages(data.images.uploaded);
       processedImages = { ...data.images, uploaded: uploadedImages };
     } catch (error: unknown) {
-      const errorMessage = getErrorMessage(error);
-      logger.error('Company image upload failed', {
-        action: 'designer_creation',
-        error: errorMessage
+      handleError(error, {
+        action: 'Upload designer images',
       });
-      throw new Error(`Failed to upload images: ${errorMessage}`);
+      throw new Error(`Failed to upload images: ${error instanceof Error ? error.message : 'Unknown error'}`);
     }
   }
 
@@ -1326,12 +1314,10 @@ export async function submitOperatorCreation(
       const uploadedImages = await uploadPendingImages(data.images.uploaded);
       processedImages = { ...data.images, uploaded: uploadedImages };
     } catch (error: unknown) {
-      const errorMessage = getErrorMessage(error);
-      logger.error('Company image upload failed', {
-        action: 'operator_creation',
-        error: errorMessage
+      handleError(error, {
+        action: 'Upload operator images',
       });
-      throw new Error(`Failed to upload images: ${errorMessage}`);
+      throw new Error(`Failed to upload images: ${error instanceof Error ? error.message : 'Unknown error'}`);
     }
   }
 
@@ -1434,12 +1420,10 @@ export async function submitPropertyOwnerCreation(
       const uploadedImages = await uploadPendingImages(data.images.uploaded);
       processedImages = { ...data.images, uploaded: uploadedImages };
     } catch (error: unknown) {
-      const errorMessage = getErrorMessage(error);
-      logger.error('Company image upload failed', {
-        action: 'property_owner_creation',
-        error: errorMessage
+      handleError(error, {
+        action: 'Upload property owner images',
       });
-      throw new Error(`Failed to upload images: ${errorMessage}`);
+      throw new Error(`Failed to upload images: ${error instanceof Error ? error.message : 'Unknown error'}`);
     }
   }
 
@@ -1602,11 +1586,9 @@ export async function submitTimelineEvent(
     });
 
   if (error || !submissionId) {
-    const errorMessage = getErrorMessage(error);
-    logger.error('Timeline event submission failed', {
-      action: 'create_timeline_event',
+    handleError(error || new Error('No submission ID returned'), {
+      action: 'Submit timeline event',
       userId,
-      error: errorMessage
     });
     throw new Error('Failed to submit timeline event for review');
   }
@@ -1679,11 +1661,9 @@ export async function submitTimelineEventUpdate(
   );
 
   if (rpcError || !result) {
-    const errorMessage = getErrorMessage(rpcError);
-    logger.error('Timeline event update failed', {
-      action: 'update_timeline_event',
-      eventId,
-      error: errorMessage
+    handleError(rpcError || new Error('No result returned'), {
+      action: 'Update timeline event',
+      metadata: { eventId },
     });
     throw new Error('Failed to submit timeline event update');
   }
@@ -1707,11 +1687,9 @@ export async function deleteTimelineEvent(
     .single();
 
   if (fetchError) {
-    const errorMessage = getErrorMessage(fetchError);
-    logger.error('Timeline event fetch failed', {
-      action: 'delete_timeline_event',
-      eventId,
-      error: errorMessage
+    handleError(fetchError, {
+      action: 'Delete timeline event',
+      metadata: { eventId },
     });
     throw new Error('Timeline event not found');
   }
@@ -1736,11 +1714,9 @@ export async function deleteTimelineEvent(
     .eq('id', eventId);
 
   if (deleteError) {
-    const errorMessage = getErrorMessage(deleteError);
-    logger.error('Timeline event deletion failed', {
-      action: 'delete_timeline_event',
-      eventId,
-      error: errorMessage
+    handleError(deleteError, {
+      action: 'Delete timeline event',
+      metadata: { eventId },
     });
     throw new Error('Failed to delete timeline event');
   }