pacnpal/thrillwiki_django_no_react
1
1
Fork 0
mirror of https://github.com/pacnpal/thrillwiki_django_no_react.git synced 2025-12-20 05:51:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor code structure and remove redundant sections for improved readability and maintainability

Browse Source
This commit is contained in:
pacnpal
2025-08-28 16:01:24 -04:00
parent 67db0aa46e
commit 02ac587216
12 changed files with 5342 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

117
cline_docs/activeContext.md
View File

@@ -1,15 +1,48 @@
c# Active Context
## Current Focus
- **COMPLETED: RideModel API Directory Structure Reorganization**: Successfully reorganized API directory structure to match nested URL organization with mandatory nested file structure
- **COMPLETED: RideModel API Reorganization**: Successfully reorganized RideModel endpoints from separate top-level `/api/v1/ride-models/` to nested `/api/v1/rides/manufacturers/<manufacturerSlug>/<ridemodelSlug>/` structure
- **COMPLETED: django-cloudflare-images Integration**: Successfully implemented complete Cloudflare Images integration across rides and parks models with full API support including banner/card image settings
- **COMPLETED: Enhanced Stats API Endpoint**: Successfully updated `/api/v1/stats/` endpoint with comprehensive platform statistics
- **COMPLETED: Maps API Implementation**: Successfully implemented all map endpoints with full functionality
- **COMPLETED: Comprehensive Rides Filtering System**: Successfully implemented comprehensive filtering capabilities for rides API with 25+ filter parameters and enhanced filter options endpoint
- **Features Implemented**:
- **RideModel API Directory Structure**: Moved files from `backend/apps/api/v1/ride_models/` to `backend/apps/api/v1/rides/manufacturers/` to match nested URL organization
- **RideModel API Reorganization**: Nested endpoints under rides/manufacturers, manufacturer-scoped slugs, integrated with ride creation/editing, removed top-level endpoint
- **Cloudflare Images**: Model field updates, API serializer enhancements, image variants, transformations, upload examples, comprehensive documentation
- **Stats API**: Entity counts, photo counts, category breakdowns, status breakdowns, review counts, automatic cache invalidation, caching, public access, OpenAPI documentation
- **Maps API**: Location retrieval, bounds filtering, text search, location details, clustering support, caching, comprehensive serializers, OpenAPI documentation
- **Comprehensive Rides Filtering**: 25+ filter parameters, enhanced filter options endpoint, roller coaster specific filters, range filters, boolean filters, multiple value support, comprehensive ordering options
## Recent Changes
**RideModel API Directory Structure Reorganization - COMPLETED:**
- **Reorganized**: API directory structure from `backend/apps/api/v1/ride_models/` to `backend/apps/api/v1/rides/manufacturers/`
- **Files Moved**:
- `backend/apps/api/v1/ride_models/__init__.py` → `backend/apps/api/v1/rides/manufacturers/__init__.py`
- `backend/apps/api/v1/ride_models/urls.py` → `backend/apps/api/v1/rides/manufacturers/urls.py`
- `backend/apps/api/v1/ride_models/views.py` → `backend/apps/api/v1/rides/manufacturers/views.py`
- **Import Path Updated**: `backend/apps/api/v1/rides/urls.py` - Updated include path from `apps.api.v1.ride_models.urls` to `apps.api.v1.rides.manufacturers.urls`
- **Directory Structure**: Now properly nested to match URL organization as mandated
- **Testing**: All endpoints verified working correctly with new nested structure
**RideModel API Reorganization - COMPLETED:**
- **Reorganized**: RideModel endpoints from `/api/v1/ride-models/` to `/api/v1/rides/manufacturers/<manufacturerSlug>/<ridemodelSlug>/`
- **Slug System**: Updated to manufacturer-scoped slugs (e.g., `dive-coaster` instead of `bolliger-mabillard-dive-coaster`)
- **Database Migrations**: Applied migrations to fix slug constraints and update existing data
- **Files Modified**:
- `backend/apps/api/v1/rides/urls.py` - Added nested include for manufacturers.urls
- `backend/apps/api/v1/urls.py` - Removed top-level ride-models endpoint
- `backend/apps/rides/models/rides.py` - Updated slug generation and unique constraints
- **Endpoint Structure**: All RideModel functionality now accessible under `/api/v1/rides/manufacturers/<manufacturerSlug>/`
- **Integration**: RideModel selection already integrated in ride creation/editing serializers via `ride_model_id` field
- **Testing**: All endpoints verified working correctly:
- `/api/v1/rides/manufacturers/<manufacturerSlug>/` - List/create ride models for manufacturer
- `/api/v1/rides/manufacturers/<manufacturerSlug>/<ridemodelSlug>/` - Detailed ride model view
- `/api/v1/rides/manufacturers/<manufacturerSlug>/<ridemodelSlug>/photos/` - Ride model photos
- `/api/v1/rides/search/ride-models/` - Ride model search for ride creation
- **Old Endpoint**: `/api/v1/ride-models/` now returns 404 as expected
**django-cloudflare-images Integration - COMPLETED:**
- **Implemented**: Complete Cloudflare Images integration for rides and parks models
- **Files Created/Modified**:
@@ -39,6 +72,31 @@ c# Active Context
- `backend/apps/api/v1/serializers/maps.py` - Comprehensive map serializers
- `backend/apps/api/v1/maps/urls.py` - Map URL routing (existing)
**Comprehensive Rides Filtering System - COMPLETED:**
- **Implemented**: Complete comprehensive filtering system for rides API
- **Files Modified**:
- `backend/apps/api/v1/rides/views.py` - Enhanced RideListCreateAPIView with 25+ filter parameters and comprehensive FilterOptionsAPIView
- **Filter Categories Implemented**:
- **Basic Filters**: Text search, park filtering (ID/slug), pagination
- **Category Filters**: Multiple ride categories (RC, DR, FR, WR, TR, OT) with multiple value support
- **Status Filters**: Multiple ride statuses with multiple value support
- **Company Filters**: Manufacturer and designer filtering by ID/slug
- **Ride Model Filters**: Filter by specific ride models (ID or slug with manufacturer)
- **Rating Filters**: Min/max average rating filtering (1-10 scale)
- **Physical Spec Filters**: Height requirements, capacity ranges
- **Date Filters**: Opening year, date ranges, specific years
- **Roller Coaster Specific**: Type, track material, launch type, height/speed/inversions
- **Boolean Filters**: Has inversions toggle
- **Ordering**: 14 different ordering options including coaster stats
- **Filter Options Endpoint**: Enhanced `/api/v1/rides/filter-options/` with comprehensive metadata
- Categories, statuses, roller coaster types, track materials, launch types
- Ordering options with human-readable labels
- Filter ranges with min/max/step/unit metadata
- Boolean filter definitions
- **Performance Optimizations**: Optimized querysets with select_related and prefetch_related
- **Error Handling**: Graceful handling of invalid filter values with try/catch blocks
- **Multiple Value Support**: Categories and statuses support multiple values via getlist()
**Technical Implementation:**
- **Stats Endpoint**: GET `/api/v1/stats/` - Returns comprehensive platform statistics
- **Maps Endpoints**:
@@ -56,6 +114,17 @@ c# Active Context
## Active Files
### RideModel API Reorganization Files
- `backend/apps/api/v1/rides/urls.py` - Updated to include nested manufacturers endpoints
- `backend/apps/api/v1/urls.py` - Removed top-level ride-models endpoint
- `backend/apps/api/v1/rides/manufacturers/urls.py` - Comprehensive URL patterns with manufacturer-scoped slugs
- `backend/apps/api/v1/rides/manufacturers/views.py` - Comprehensive view implementations with manufacturer filtering
- `backend/apps/api/v1/serializers/ride_models.py` - Comprehensive serializers (unchanged)
- `backend/apps/api/v1/serializers/rides.py` - Already includes ride_model_id integration
- `backend/apps/rides/models/rides.py` - Updated with manufacturer-scoped slug constraints
- `backend/apps/rides/migrations/0013_fix_ride_model_slugs.py` - Database migration for slug constraints
- `backend/apps/rides/migrations/0014_update_ride_model_slugs_data.py` - Data migration to update existing slugs
### Cloudflare Images Integration Files
- `backend/apps/rides/models/media.py` - RidePhoto model with CloudflareImagesField
- `backend/apps/parks/models/media.py` - ParkPhoto model with CloudflareImagesField
@@ -75,25 +144,48 @@ c# Active Context
- `backend/apps/api/v1/serializers/maps.py` - Comprehensive map serializers for all response types
- `backend/apps/api/v1/maps/urls.py` - Map URL routing configuration
## Permanent Rules Established
**CREATED**: `cline_docs/permanent_rules.md` - Permanent development rules that must be followed in all future work.
**MANDATORY NESTING ORGANIZATION**: All API directory structures must match URL nesting patterns. No exceptions.
**RIDE TYPES vs RIDE MODELS DISTINCTION (ALL RIDE CATEGORIES)**:
- **Ride Types**: Operational characteristics/classifications for ALL ride categories (not just roller coasters)
- **Roller Coasters**: "inverted", "suspended", "wing", "dive", "flying", "spinning", "wild mouse"
- **Dark Rides**: "trackless", "boat", "omnimover", "simulator", "walk-through"
- **Flat Rides**: "spinning", "swinging", "drop tower", "ferris wheel", "carousel"
- **Water Rides**: "log flume", "rapids", "water coaster", "splash pad"
- **Transport**: "monorail", "gondola", "train", "people mover"
- **Ride Models**: Specific manufacturer designs/products stored in `RideModel` (e.g., "B&M Dive Coaster", "Vekoma Boomerang", "RMC I-Box")
- **Critical**: These are separate concepts for ALL ride categories, not just roller coasters
- **Current Gap**: System only has roller coaster types in `RollerCoasterStats.roller_coaster_type` - needs extension to all categories
- Individual ride installations reference both: the `RideModel` (what specific design) and the type classification (how it operates)
## Next Steps
1. **Cloudflare Images Enhancements**:
1. **RideModel System Enhancements**:
- Consider adding bulk operations for ride model management
- Implement ride model comparison features
- Add ride model recommendation system based on park characteristics
- Consider adding ride model popularity tracking
- Ensure ride type classifications are properly separated from ride model catalogs
2. **Cloudflare Images Enhancements**:
- Consider implementing custom variants for specific use cases
- Add signed URLs for private images
- Implement batch upload capabilities
- Add image analytics integration
2. **Maps API Enhancements**:
3. **Maps API Enhancements**:
- Implement clustering algorithm for high-density areas
- Add nearby locations functionality
- Implement relevance scoring for search results
- Add cache statistics tracking
- Add admin permission checks for cache management endpoints
3. **Stats API Enhancements**:
4. **Stats API Enhancements**:
- Consider adding more granular statistics if needed
- Monitor cache performance and adjust cache duration if necessary
- Add unit tests for the stats endpoint
- Consider adding filtering or query parameters for specific stat categories
4. **Testing**: Add comprehensive unit tests for all endpoints
5. **Performance**: Monitor and optimize database queries for large datasets
5. **Testing**: Add comprehensive unit tests for all endpoints
6. **Performance**: Monitor and optimize database queries for large datasets
## Current Development State
- Django backend with comprehensive stats API
@@ -102,6 +194,21 @@ c# Active Context
- All middleware issues resolved
## Testing Results
- **RideModel API Directory Structure**: ✅ Successfully reorganized to match nested URL organization
- **Directory Structure**: Files moved from `backend/apps/api/v1/ride_models/` to `backend/apps/api/v1/rides/manufacturers/`
- **Import Paths**: Updated to use new nested structure
- **System Check**: ✅ Django system check passes with no issues
- **URL Routing**: ✅ All URLs properly resolved with new nested structure
- **RideModel API Reorganization**: ✅ Successfully reorganized and tested
- **New Endpoints**: All RideModel functionality now under `/api/v1/rides/manufacturers/<manufacturerSlug>/`
- **List Endpoint**: `/api/v1/rides/manufacturers/bolliger-mabillard/` - ✅ Returns 2 models for B&M
- **Detail Endpoint**: `/api/v1/rides/manufacturers/bolliger-mabillard/dive-coaster/` - ✅ Returns comprehensive model details
- **Manufacturer Filtering**: `/api/v1/rides/manufacturers/rocky-mountain-construction/` - ✅ Returns 1 model for RMC
- **Slug System**: ✅ Updated to manufacturer-scoped slugs (e.g., `dive-coaster`, `i-box-track`)
- **Database**: ✅ All 6 existing models updated with new slug format
- **Integration**: `/api/v1/rides/search/ride-models/` - ✅ Available for ride creation
- **Old Endpoint**: `/api/v1/ride-models/` - ✅ Returns 404 as expected
- **Ride Integration**: RideModel selection available via `ride_model_id` in ride serializers
- **Cloudflare Images Integration**: ✅ Fully implemented and functional
- **Models**: RidePhoto and ParkPhoto using CloudflareImagesField
- **API Serializers**: Enhanced with image_url and image_variants fields

46
cline_docs/permanent_rules.md Normal file
View File

@@ -0,0 +1,46 @@
# Permanent Development Rules
## API Organization Rules
### MANDATORY NESTING ORGANIZATION
All API directory structures MUST match URL nesting patterns. No exceptions. If URLs are nested like `/api/v1/rides/manufacturers/<slug>/`, then the directory structure must be `backend/apps/api/v1/rides/manufacturers/`.
## Data Model Rules
### RIDE TYPES vs RIDE MODELS DISTINCTION
**CRITICAL RULE**: Ride Types and Ride Models are completely separate concepts that must never be conflated:
#### Ride Types (Operational Classifications)
- **Definition**: How a ride operates or what experience it provides
- **Scope**: Applies to ALL ride categories (not just roller coasters)
- **Examples**:
- **Roller Coasters**: "inverted", "suspended", "wing", "dive", "flying", "spinning", "wild mouse"
- **Dark Rides**: "trackless", "boat", "omnimover", "simulator", "walk-through"
- **Flat Rides**: "spinning", "swinging", "drop tower", "ferris wheel", "carousel"
- **Water Rides**: "log flume", "rapids", "water coaster", "splash pad"
- **Transport**: "monorail", "gondola", "train", "people mover"
- **Storage**: Should be stored as type classifications for each ride category
- **Purpose**: Describes the ride experience and operational characteristics
#### Ride Models (Manufacturer Products)
- **Definition**: Specific designs/products manufactured by companies
- **Scope**: Catalog of available ride designs that can be purchased and installed
- **Examples**: "B&M Dive Coaster", "Vekoma Boomerang", "RMC I-Box", "Intamin Blitz", "Mack PowerSplash"
- **Storage**: Stored in `RideModel` table with manufacturer relationships
- **Purpose**: Product catalog for ride installations
#### Relationship
- Individual ride installations reference BOTH:
- The `RideModel` (what specific product/design was purchased)
- The ride type classification (how it operates within its category)
- A ride model can have a type, but they serve different purposes in the data structure
- Example: "Silver Star at Europa-Park" is a "B&M Hyper Coaster" (model) that is a "sit-down" type roller coaster
#### Implementation Requirements
- Ride types must be available for ALL ride categories, not just roller coasters
- Current system only has roller coaster types in `RollerCoasterStats.roller_coaster_type`
- Need to extend type classifications to all ride categories
- Maintain clear separation between type (how it works) and model (what product it is)
## Enforcement
These rules are MANDATORY and must be followed in all development work. Any violation should be immediately corrected.