mirror of
https://github.com/pacnpal/thrillwiki_django_no_react.git
synced 2025-12-23 02:51:09 -05:00
feat: Refactor rides app with unique constraints, mixins, and enhanced documentation
- Added migration to convert unique_together constraints to UniqueConstraint for RideModel. - Introduced RideFormMixin for handling entity suggestions in ride forms. - Created comprehensive code standards documentation outlining formatting, docstring requirements, complexity guidelines, and testing requirements. - Established error handling guidelines with a structured exception hierarchy and best practices for API and view error handling. - Documented view pattern guidelines, emphasizing the use of CBVs, FBVs, and ViewSets with examples. - Implemented a benchmarking script for query performance analysis and optimization. - Developed security documentation detailing measures, configurations, and a security checklist. - Compiled a database optimization guide covering indexing strategies, query optimization patterns, and computed fields.
This commit is contained in:
@@ -203,11 +203,12 @@ class Command(BaseCommand):
|
||||
)
|
||||
|
||||
def create_parks(self):
|
||||
"""Create parks with proper operator relationships"""
|
||||
"""Create parks with proper operator relationships."""
|
||||
self.stdout.write("Creating parks...")
|
||||
|
||||
# TODO: Implement park creation - parks_data defined but not used yet
|
||||
parks_data = [ # noqa: F841
|
||||
# Park creation data - will be used to create parks in the database
|
||||
# TODO(THRILLWIKI-111): Complete park creation implementation
|
||||
parks_data = [
|
||||
{
|
||||
"name": "Magic Kingdom",
|
||||
"slug": "magic-kingdom",
|
||||
|
||||
@@ -194,10 +194,9 @@ class Command(BaseCommand):
|
||||
missing_tables = []
|
||||
for model in required_models:
|
||||
try:
|
||||
# Check if the table exists by trying to get the table name
|
||||
table_name = model._meta.db_table
|
||||
with connection.cursor() as cursor:
|
||||
cursor.execute(f"SELECT 1 FROM {table_name} LIMIT 1")
|
||||
# Security: Use Django ORM to check table existence instead of raw SQL
|
||||
# This is safer as it avoids any potential SQL injection via model metadata
|
||||
model.objects.exists()
|
||||
except Exception:
|
||||
missing_tables.append(model._meta.label)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user