Fix search form duplication by updating event handler to submit the correct filter form and return JSON responses for park suggestions

parks/tests/README.md

@@ -24,21 +24,28 @@ uv run pytest --cov=parks parks/tests/
 
 ## Test Coverage
 
+### Search API Tests
+- `test_search_json_format`: Validates API response structure
+- `test_empty_search_json`: Tests empty search handling
+- `test_search_format_validation`: Verifies all required fields and types
+- `test_suggestion_limit`: Confirms 8-item result limit
+
 ### Search Functionality Tests
 - `test_autocomplete_results`: Validates real-time suggestion filtering
-- `test_search_form_valid`: Ensures form validation works
-- `test_autocomplete_class`: Verifies autocomplete configuration
-- `test_search_with_filters`: Tests filter integration
+- `test_search_with_filters`: Tests filter integration with search
+- `test_partial_match_search`: Verifies partial text matching works
 
-### Integration Tests
-- `test_empty_search`: Tests default behavior
-- `test_partial_match_search`: Validates partial text matching
-- `test_htmx_request_handling`: Ensures HTMX compatibility
-- `test_view_mode_persistence`: Verifies view state preservation
+### UI Integration Tests
+- `test_view_mode_persistence`: Ensures view mode is maintained
+- `test_empty_search`: Tests default state behavior
+- `test_htmx_request_handling`: Validates HTMX interactions
 
-### Performance Tests
-- `test_suggestion_limit`: Verifies 8-item limit on suggestions
-- `test_search_debounce`: Confirms proper debounce headers
+### Data Format Tests
+- Field types validation
+- Location formatting
+- Status display formatting
+- URL generation
+- Response structure
 
 ### Frontend Integration
 - HTMX partial updates

parks/tests/test_search.py

@@ -117,12 +117,67 @@ class TestParkSearch:
         result_count = content.count('Test Park')
         assert result_count == 8  # Verify limit is enforced
 
-    def test_search_debounce(self, client: Client):
-        """Test that search has proper headers for debouncing"""
-        Park.objects.create(name="Test Park")
-
+    def test_search_json_format(self, client: Client):
+        """Test that search returns properly formatted JSON"""
+        park = Park.objects.create(
+            name="Test Park",
+            status="OPERATING",
+            city="Test City",
+            state="Test State"
+        )
+        
         url = reverse('parks:suggest_parks')
         response = client.get(url, {'search': 'Test'})
-
+        
         assert response.status_code == 200
-        assert 'HX-Trigger' in response
+        data = response.json()
+        assert 'results' in data
+        assert len(data['results']) == 1
+        
+        result = data['results'][0]
+        assert result['id'] == str(park.pk)
+        assert result['name'] == "Test Park"
+        assert result['status'] == "Operating"
+        assert result['location'] == park.formatted_location
+        assert result['url'] == reverse('parks:park_detail', kwargs={'slug': park.slug})
+
+    def test_empty_search_json(self, client: Client):
+        """Test empty search returns empty results array"""
+        url = reverse('parks:suggest_parks')
+        response = client.get(url, {'search': ''})
+        
+        assert response.status_code == 200
+        data = response.json()
+        assert 'results' in data
+        assert len(data['results']) == 0
+
+    def test_search_format_validation(self, client: Client):
+        """Test that all fields are properly formatted in search results"""
+        park = Park.objects.create(
+            name="Test Park",
+            status="OPERATING",
+            city="Test City",
+            state="Test State",
+            country="Test Country"
+        )
+        
+        expected_fields = {'id', 'name', 'status', 'location', 'url'}
+        
+        url = reverse('parks:suggest_parks')
+        response = client.get(url, {'search': 'Test'})
+        data = response.json()
+        result = data['results'][0]
+        
+        # Check all expected fields are present
+        assert set(result.keys()) == expected_fields
+        
+        # Check field types
+        assert isinstance(result['id'], str)
+        assert isinstance(result['name'], str)
+        assert isinstance(result['status'], str)
+        assert isinstance(result['location'], str)
+        assert isinstance(result['url'], str)
+        
+        # Check formatted location includes city and state
+        assert 'Test City' in result['location']
+        assert 'Test State' in result['location']