feat: Implement avatar upload system with Cloudflare integration

- Added migration to transition avatar data from CloudflareImageField to ForeignKey structure in UserProfile.
- Fixed UserProfileEvent avatar field to align with new avatar structure.
- Created serializers for social authentication, including connected and available providers.
- Developed request logging middleware for comprehensive request/response logging.
- Updated moderation and parks migrations to remove outdated triggers and adjust foreign key relationships.
- Enhanced rides migrations to ensure proper handling of image uploads and triggers.
- Introduced a test script for the 3-step avatar upload process, ensuring functionality with Cloudflare.
- Documented the fix for avatar upload issues, detailing root cause, implementation, and verification steps.
- Implemented automatic deletion of Cloudflare images upon avatar, park, and ride photo changes or removals.

backend/apps/api/v1/rides/manufacturers/views.py

@@ -502,13 +502,13 @@ class RideModelFilterOptionsAPIView(APIView):
             .values("id", "name", "slug")
         )
 
-        categories = (
+        (
             RideModel.objects.exclude(category="")
             .values_list("category", flat=True)
             .distinct()
         )
 
-        target_markets = (
+        (
             RideModel.objects.exclude(target_market="")
             .values_list("target_market", flat=True)
             .distinct()

backend/apps/api/v1/rides/photo_views.py

@@ -204,6 +204,19 @@ class RidePhotoViewSet(ModelViewSet):
             )
 
         try:
+            # Delete from Cloudflare first if image exists
+            if instance.image:
+                try:
+                    from django_cloudflareimages_toolkit.services import CloudflareImagesService
+                    service = CloudflareImagesService()
+                    service.delete_image(instance.image)
+                    logger.info(
+                        f"Successfully deleted ride photo from Cloudflare: {instance.image.cloudflare_id}")
+                except Exception as e:
+                    logger.error(
+                        f"Failed to delete ride photo from Cloudflare: {str(e)}")
+                    # Continue with database deletion even if Cloudflare deletion fails
+
             RideMediaService.delete_photo(
                 instance, deleted_by=self.request.user  # type: ignore
             )
@@ -407,3 +420,133 @@ class RidePhotoViewSet(ModelViewSet):
         except Exception as e:
             logger.error(f"Error in set_primary_photo: {str(e)}", exc_info=True)
             return Response({"error": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+
+    @extend_schema(
+        summary="Save Cloudflare image as ride photo",
+        description="Save a Cloudflare image as a ride photo after direct upload to Cloudflare",
+        request=OpenApiTypes.OBJECT,
+        responses={
+            201: RidePhotoOutputSerializer,
+            400: OpenApiTypes.OBJECT,
+            401: OpenApiTypes.OBJECT,
+            404: OpenApiTypes.OBJECT,
+        },
+        tags=["Ride Media"],
+    )
+    @action(detail=False, methods=["post"])
+    def save_image(self, request, **kwargs):
+        """Save a Cloudflare image as a ride photo after direct upload to Cloudflare."""
+        ride_pk = self.kwargs.get("ride_pk")
+        if not ride_pk:
+            return Response(
+                {"error": "Ride ID is required"},
+                status=status.HTTP_400_BAD_REQUEST,
+            )
+
+        try:
+            ride = Ride.objects.get(pk=ride_pk)
+        except Ride.DoesNotExist:
+            return Response(
+                {"error": "Ride not found"},
+                status=status.HTTP_404_NOT_FOUND,
+            )
+
+        cloudflare_image_id = request.data.get("cloudflare_image_id")
+        if not cloudflare_image_id:
+            return Response(
+                {"error": "cloudflare_image_id is required"},
+                status=status.HTTP_400_BAD_REQUEST,
+            )
+
+        try:
+            # Import CloudflareImage model and service
+            from django_cloudflareimages_toolkit.models import CloudflareImage
+            from django_cloudflareimages_toolkit.services import CloudflareImagesService
+            from django.utils import timezone
+
+            # Always fetch the latest image data from Cloudflare API
+            try:
+                # Get image details from Cloudflare API
+                service = CloudflareImagesService()
+                image_data = service.get_image(cloudflare_image_id)
+
+                if not image_data:
+                    return Response(
+                        {"error": "Image not found in Cloudflare"},
+                        status=status.HTTP_400_BAD_REQUEST,
+                    )
+
+                # Try to find existing CloudflareImage record by cloudflare_id
+                cloudflare_image = None
+                try:
+                    cloudflare_image = CloudflareImage.objects.get(
+                        cloudflare_id=cloudflare_image_id)
+
+                    # Update existing record with latest data from Cloudflare
+                    cloudflare_image.status = 'uploaded'
+                    cloudflare_image.uploaded_at = timezone.now()
+                    cloudflare_image.metadata = image_data.get('meta', {})
+                    # Extract variants from nested result structure
+                    cloudflare_image.variants = image_data.get(
+                        'result', {}).get('variants', [])
+                    cloudflare_image.cloudflare_metadata = image_data
+                    cloudflare_image.width = image_data.get('width')
+                    cloudflare_image.height = image_data.get('height')
+                    cloudflare_image.format = image_data.get('format', '')
+                    cloudflare_image.save()
+
+                except CloudflareImage.DoesNotExist:
+                    # Create new CloudflareImage record from API response
+                    cloudflare_image = CloudflareImage.objects.create(
+                        cloudflare_id=cloudflare_image_id,
+                        user=request.user,
+                        status='uploaded',
+                        upload_url='',  # Not needed for uploaded images
+                        expires_at=timezone.now() + timezone.timedelta(days=365),  # Set far future expiry
+                        uploaded_at=timezone.now(),
+                        metadata=image_data.get('meta', {}),
+                        # Extract variants from nested result structure
+                        variants=image_data.get('result', {}).get('variants', []),
+                        cloudflare_metadata=image_data,
+                        width=image_data.get('width'),
+                        height=image_data.get('height'),
+                        format=image_data.get('format', ''),
+                    )
+
+            except Exception as api_error:
+                logger.error(
+                    f"Error fetching image from Cloudflare API: {str(api_error)}", exc_info=True)
+                return Response(
+                    {"error": f"Failed to fetch image from Cloudflare: {str(api_error)}"},
+                    status=status.HTTP_400_BAD_REQUEST,
+                )
+
+            # Create the ride photo with the CloudflareImage reference
+            photo = RidePhoto.objects.create(
+                ride=ride,
+                image=cloudflare_image,
+                uploaded_by=request.user,
+                caption=request.data.get("caption", ""),
+                alt_text=request.data.get("alt_text", ""),
+                photo_type=request.data.get("photo_type", "exterior"),
+                is_primary=request.data.get("is_primary", False),
+                is_approved=False,  # Default to requiring approval
+            )
+
+            # Handle primary photo logic if requested
+            if request.data.get("is_primary", False):
+                try:
+                    RideMediaService.set_primary_photo(ride=ride, photo=photo)
+                except Exception as e:
+                    logger.error(f"Error setting primary photo: {e}")
+                    # Don't fail the entire operation, just log the error
+
+            serializer = RidePhotoOutputSerializer(photo, context={"request": request})
+            return Response(serializer.data, status=status.HTTP_201_CREATED)
+
+        except Exception as e:
+            logger.error(f"Error saving ride photo: {e}")
+            return Response(
+                {"error": f"Failed to save photo: {str(e)}"},
+                status=status.HTTP_400_BAD_REQUEST,
+            )

backend/apps/api/v1/rides/views.py

@@ -630,11 +630,36 @@ class RideDetailAPIView(APIView):
                 },
                 status=status.HTTP_501_NOT_IMPLEMENTED,
             )
-        for key, value in serializer_in.validated_data.items():
+        
+        validated_data = serializer_in.validated_data
+        park_change_info = None
+        
+        # Handle park change specially if park_id is being updated
+        if 'park_id' in validated_data:
+            new_park_id = validated_data.pop('park_id')
+            try:
+                new_park = Park.objects.get(id=new_park_id)  # type: ignore
+                if new_park.id != ride.park_id:
+                    # Use the move_to_park method for proper handling
+                    park_change_info = ride.move_to_park(new_park)
+            except Park.DoesNotExist:  # type: ignore
+                raise NotFound("Target park not found")
+        
+        # Apply other field updates
+        for key, value in validated_data.items():
             setattr(ride, key, value)
+        
         ride.save()
+        
+        # Prepare response data
         serializer = RideDetailOutputSerializer(ride, context={"request": request})
-        return Response(serializer.data)
+        response_data = serializer.data
+        
+        # Add park change information to response if applicable
+        if park_change_info:
+            response_data['park_change_info'] = park_change_info
+        
+        return Response(response_data)
 
     def put(self, request: Request, pk: int) -> Response:
         # Full replace - reuse patch behavior for simplicity