Compare commits

..

2 Commits

Author SHA1 Message Date
gpt-engineer-app[bot]
c8bea4b798 Changes 2025-11-12 14:36:37 +00:00
gpt-engineer-app[bot]
250e7c488a Changes 2025-11-12 14:36:07 +00:00
2 changed files with 11 additions and 50 deletions

View File

@@ -1,14 +1,12 @@
import { ChevronDown, ChevronUp } from 'lucide-react';
import { Collapsible, CollapsibleTrigger, CollapsibleContent } from '@/components/ui/collapsible';
import { Button } from '@/components/ui/button';
import { Badge } from '@/components/ui/badge';
import { cn } from '@/lib/utils';
interface DetailedViewCollapsibleProps {
isCollapsed: boolean;
onToggle: () => void;
children: React.ReactNode;
fieldCount?: number;
className?: string;
}
@@ -20,7 +18,6 @@ export function DetailedViewCollapsible({
isCollapsed,
onToggle,
children,
fieldCount,
className
}: DetailedViewCollapsibleProps) {
return (
@@ -30,35 +27,25 @@ export function DetailedViewCollapsible({
<Button
variant="ghost"
size="sm"
className="w-full flex items-center justify-between hover:bg-muted/50 p-2 h-auto transition-colors"
className="w-full flex items-center justify-between hover:bg-muted/50 p-2 h-auto"
>
<div className="flex items-center gap-2">
<span className="text-xs font-semibold text-muted-foreground uppercase tracking-wide">
All Fields (Detailed View)
</span>
{fieldCount !== undefined && fieldCount > 0 && (
<Badge
variant="secondary"
className="h-5 px-1.5 text-xs font-normal transition-transform duration-200 hover:scale-105"
>
{fieldCount}
</Badge>
)}
<div className="text-xs font-semibold text-muted-foreground uppercase tracking-wide">
All Fields (Detailed View)
</div>
<div className="flex items-center gap-2">
<span className="text-xs text-muted-foreground normal-case font-normal">
{isCollapsed ? 'Show' : 'Hide'}
</span>
{isCollapsed ? (
<ChevronDown className="h-4 w-4 text-muted-foreground transition-transform duration-200" />
<ChevronDown className="h-4 w-4 text-muted-foreground" />
) : (
<ChevronUp className="h-4 w-4 text-muted-foreground transition-transform duration-200" />
<ChevronUp className="h-4 w-4 text-muted-foreground" />
)}
</div>
</Button>
</CollapsibleTrigger>
<CollapsibleContent className="mt-3 data-[state=closed]:animate-accordion-up data-[state=open]:animate-accordion-down">
<CollapsibleContent className="mt-3">
{children}
</CollapsibleContent>
</div>

View File

@@ -42,12 +42,6 @@ export const SubmissionItemsList = memo(function SubmissionItemsList({
fetchSubmissionItems();
}, [submissionId]);
// Helper function to count non-null fields in entity data
const countFields = (data: any): number => {
if (!data || typeof data !== 'object') return 0;
return Object.values(data).filter(value => value !== null && value !== undefined).length;
};
const fetchSubmissionItems = async () => {
try {
// Only show skeleton on initial load, show refreshing indicator on refresh
@@ -197,11 +191,7 @@ export const SubmissionItemsList = memo(function SubmissionItemsList({
data={entityData as unknown as ParkSubmissionData}
actionType={actionType}
/>
<DetailedViewCollapsible
isCollapsed={isCollapsed}
onToggle={toggle}
fieldCount={countFields(entityData)}
>
<DetailedViewCollapsible isCollapsed={isCollapsed} onToggle={toggle}>
<SubmissionChangesDisplay
item={item}
view="detailed"
@@ -221,11 +211,7 @@ export const SubmissionItemsList = memo(function SubmissionItemsList({
data={entityData as unknown as RideSubmissionData}
actionType={actionType}
/>
<DetailedViewCollapsible
isCollapsed={isCollapsed}
onToggle={toggle}
fieldCount={countFields(entityData)}
>
<DetailedViewCollapsible isCollapsed={isCollapsed} onToggle={toggle}>
<SubmissionChangesDisplay
item={item}
view="detailed"
@@ -245,11 +231,7 @@ export const SubmissionItemsList = memo(function SubmissionItemsList({
data={entityData as unknown as CompanySubmissionData}
actionType={actionType}
/>
<DetailedViewCollapsible
isCollapsed={isCollapsed}
onToggle={toggle}
fieldCount={countFields(entityData)}
>
<DetailedViewCollapsible isCollapsed={isCollapsed} onToggle={toggle}>
<SubmissionChangesDisplay
item={item}
view="detailed"
@@ -269,11 +251,7 @@ export const SubmissionItemsList = memo(function SubmissionItemsList({
data={entityData as unknown as RideModelSubmissionData}
actionType={actionType}
/>
<DetailedViewCollapsible
isCollapsed={isCollapsed}
onToggle={toggle}
fieldCount={countFields(entityData)}
>
<DetailedViewCollapsible isCollapsed={isCollapsed} onToggle={toggle}>
<SubmissionChangesDisplay
item={item}
view="detailed"
@@ -293,11 +271,7 @@ export const SubmissionItemsList = memo(function SubmissionItemsList({
data={entityData as unknown as TimelineSubmissionData}
actionType={actionType}
/>
<DetailedViewCollapsible
isCollapsed={isCollapsed}
onToggle={toggle}
fieldCount={countFields(entityData)}
>
<DetailedViewCollapsible isCollapsed={isCollapsed} onToggle={toggle}>
<SubmissionChangesDisplay
item={item}
view="detailed"